[INFO] fetching crate tari_crypto 0.20.3... [INFO] checking tari_crypto-0.20.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate tari_crypto 0.20.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate tari_crypto 0.20.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate tari_crypto 0.20.3 [INFO] finished tweaking crates.io crate tari_crypto 0.20.3 [INFO] tweaked toml for crates.io crate tari_crypto 0.20.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 115 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding base58-monero v0.3.2 (available: v2.0.0) [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding snafu v0.7.5 (available: v0.8.5) [INFO] [stderr] Adding snafu-derive v0.7.5 (available: v0.8.5) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e76cfaaa8c0af9a1f2d8fb03eabae7b609ccd38a5bd0130a164c6a765dfa9b48 [INFO] running `Command { std: "docker" "start" "-a" "e76cfaaa8c0af9a1f2d8fb03eabae7b609ccd38a5bd0130a164c6a765dfa9b48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e76cfaaa8c0af9a1f2d8fb03eabae7b609ccd38a5bd0130a164c6a765dfa9b48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e76cfaaa8c0af9a1f2d8fb03eabae7b609ccd38a5bd0130a164c6a765dfa9b48", kill_on_drop: false }` [INFO] [stdout] e76cfaaa8c0af9a1f2d8fb03eabae7b609ccd38a5bd0130a164c6a765dfa9b48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20af770f25198f94fa28707b8cf575ac2a94e182b31d4ed41d726d9e3c8312d3 [INFO] running `Command { std: "docker" "start" "-a" "20af770f25198f94fa28707b8cf575ac2a94e182b31d4ed41d726d9e3c8312d3", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling portable-atomic v1.9.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling critical-section v1.1.3 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling borsh v1.5.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking newtype-ops v0.1.4 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling thiserror-impl-no-std v2.0.2 [INFO] [stderr] Checking thiserror-no-std v2.0.2 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling syn_derive v0.1.8 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Compiling borsh-derive v1.5.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking base58-monero v0.3.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tari_utilities v0.7.0 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking tari_bulletproofs_plus v0.4.0 [INFO] [stderr] Checking tari_crypto v0.20.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `P` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures/commitment_and_public_key_signature.rs:204:25 [INFO] [stdout] | [INFO] [stdout] 193 | let w = K::random(rng); // must be random and not Fiat-Shamir! [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let verifier_lhs = factory [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | verifier_lhs == verifier_rhs_unweighted + verifier_rhs_weighted [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>, ProofError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ristretto/bulletproofs_plus.rs:429:15 [INFO] [stdout] | [INFO] [stdout] 420 | let range_statements = self.prepare_public_range_statements(statements); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | let mut transcripts = vec![Transcript::new(self.transcript_label.as_bytes()); range_statements.len()]; [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | match RistrettoRangeProof::verify_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 430 | | &mut transcripts, [INFO] [stdout] 431 | | &range_statements, [INFO] [stdout] 432 | | &range_proofs, [INFO] [stdout] 433 | | VerifyAction::VerifyOnly, [INFO] [stdout] 434 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_crypto` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `P` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures/commitment_and_public_key_signature.rs:204:25 [INFO] [stdout] | [INFO] [stdout] 193 | let w = K::random(rng); // must be random and not Fiat-Shamir! [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let verifier_lhs = factory [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | verifier_lhs == verifier_rhs_unweighted + verifier_rhs_weighted [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>, ProofError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ristretto/bulletproofs_plus.rs:429:15 [INFO] [stdout] | [INFO] [stdout] 420 | let range_statements = self.prepare_public_range_statements(statements); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 426 | let mut transcripts = vec![Transcript::new(self.transcript_label.as_bytes()); range_statements.len()]; [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | match RistrettoRangeProof::verify_batch( [INFO] [stdout] | _______________^ [INFO] [stdout] 430 | | &mut transcripts, [INFO] [stdout] 431 | | &range_statements, [INFO] [stdout] 432 | | &range_proofs, [INFO] [stdout] 433 | | VerifyAction::VerifyOnly, [INFO] [stdout] 434 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ristretto_keys::RistrettoSecretKey` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ristretto/pedersen/extended_commitment_factory.rs:529:17 [INFO] [stdout] | [INFO] [stdout] 526 | let v_zero = RistrettoSecretKey::default(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 527 | let k_zero = vec![RistrettoSecretKey::default(); ExtensionDegree::AddFiveBasePoints as usize]; [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 528 | for extension_degree in EXTENSION_DEGREE { [INFO] [stdout] 529 | let mut v_sum = RistrettoSecretKey::default(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tari_crypto` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "20af770f25198f94fa28707b8cf575ac2a94e182b31d4ed41d726d9e3c8312d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20af770f25198f94fa28707b8cf575ac2a94e182b31d4ed41d726d9e3c8312d3", kill_on_drop: false }` [INFO] [stdout] 20af770f25198f94fa28707b8cf575ac2a94e182b31d4ed41d726d9e3c8312d3