[INFO] fetching crate syncfast 0.2.0... [INFO] checking syncfast-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate syncfast 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate syncfast 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate syncfast 0.2.0 [INFO] finished tweaking crates.io crate syncfast 0.2.0 [INFO] tweaked toml for crates.io crate syncfast 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate syncfast 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d24063fe2165c0c1b870788ca95aa69fe131af05665df5ab34c591c7041d99cb [INFO] running `Command { std: "docker" "start" "-a" "d24063fe2165c0c1b870788ca95aa69fe131af05665df5ab34c591c7041d99cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d24063fe2165c0c1b870788ca95aa69fe131af05665df5ab34c591c7041d99cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d24063fe2165c0c1b870788ca95aa69fe131af05665df5ab34c591c7041d99cb", kill_on_drop: false }` [INFO] [stdout] d24063fe2165c0c1b870788ca95aa69fe131af05665df5ab34c591c7041d99cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc8c6b1e055ee1b037274ba46c5fd47d7b6879f7618c4c501a39b9fb4f3559d8 [INFO] running `Command { std: "docker" "start" "-a" "cc8c6b1e055ee1b037274ba46c5fd47d7b6879f7618c4c501a39b9fb4f3559d8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Compiling tokio v1.11.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking cdchunking v0.2.1 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling libsqlite3-sys v0.11.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking rusqlite v0.16.0 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking futures v0.3.17 [INFO] [stderr] Checking syncfast v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 81 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut rows = stmt.query(&[hash as &dyn ToSql])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 109 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut rows = stmt.query(&[name.to_str().ok_or(Error::BadFilenameEncoding)?])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 134 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let mut rows = stmt.query(&[name.to_str().ok_or(Error::BadFilenameEncoding)?])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:162:28 [INFO] [stdout] | [INFO] [stdout] 154 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let mut rows = stmt.query(&[file_id])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:90:28 [INFO] [stdout] | [INFO] [stdout] 81 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut rows = stmt.query(&[hash as &dyn ToSql])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 109 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let mut rows = stmt.query(&[name.to_str().ok_or(Error::BadFilenameEncoding)?])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 134 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let mut rows = stmt.query(&[name.to_str().ok_or(Error::BadFilenameEncoding)?])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, rusqlite::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:162:28 [INFO] [stdout] | [INFO] [stdout] 154 | let mut stmt = self.db.prepare( [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let mut rows = stmt.query(&[file_id])?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | if let Some(row) = rows.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `receive` and `parse` are never used [INFO] [stdout] --> src/sync/ssh/proto.rs:198:12 [INFO] [stdout] | [INFO] [stdout] 197 | impl Parser { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] 198 | pub fn receive<'a, E, F>(&'a mut self, func: F) -> Result, E> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 229 | pub fn parse<'a>(&'a mut self, input: &[u8]) -> Messages<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syncfast` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `parse` is never used [INFO] [stdout] --> src/sync/ssh/proto.rs:229:12 [INFO] [stdout] | [INFO] [stdout] 197 | impl Parser { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 229 | pub fn parse<'a>(&'a mut self, input: &[u8]) -> Messages<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syncfast` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "cc8c6b1e055ee1b037274ba46c5fd47d7b6879f7618c4c501a39b9fb4f3559d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc8c6b1e055ee1b037274ba46c5fd47d7b6879f7618c4c501a39b9fb4f3559d8", kill_on_drop: false }` [INFO] [stdout] cc8c6b1e055ee1b037274ba46c5fd47d7b6879f7618c4c501a39b9fb4f3559d8