[INFO] fetching crate sv 0.2.2... [INFO] checking sv-0.2.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sv 0.2.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sv 0.2.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sv 0.2.2 [INFO] finished tweaking crates.io crate sv 0.2.2 [INFO] tweaked toml for crates.io crate sv 0.2.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding block-buffer v0.3.3 (available: v0.10.4) [INFO] [stderr] Adding byte-tools v0.2.0 (available: v0.3.1) [INFO] [stderr] Adding cc v1.0.26 (available: v1.1.22) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding digest v0.7.6 (available: v0.10.7) [INFO] [stderr] Adding dns-lookup v0.9.1 (available: v2.0.4) [INFO] [stderr] Adding generic-array v0.9.1 (available: v1.1.0) [INFO] [stderr] Adding hex v0.3.2 (available: v0.4.3) [INFO] [stderr] Adding murmur3 v0.4.1 (available: v0.5.2) [INFO] [stderr] Adding num-bigint v0.2.6 (available: v0.4.6) [INFO] [stderr] Adding rand v0.3.23 (available: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand v0.5.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding ring v0.14.6 (available: v0.17.8) [INFO] [stderr] Adding ripemd160 v0.7.0 (available: v0.10.0) [INFO] [stderr] Adding secp256k1 v0.12.2 (available: v0.29.1) [INFO] [stderr] Adding socket2 v0.3.19 (available: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (available: v0.9.8) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.36) [INFO] [stderr] Adding untrusted v0.6.2 (available: v0.9.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b9be10bc42e9adef98d3cced469a1cf4a5c860b60fb7b158e0800f8487d5215 [INFO] running `Command { std: "docker" "start" "-a" "1b9be10bc42e9adef98d3cced469a1cf4a5c860b60fb7b158e0800f8487d5215", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b9be10bc42e9adef98d3cced469a1cf4a5c860b60fb7b158e0800f8487d5215", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b9be10bc42e9adef98d3cced469a1cf4a5c860b60fb7b158e0800f8487d5215", kill_on_drop: false }` [INFO] [stdout] 1b9be10bc42e9adef98d3cced469a1cf4a5c860b60fb7b158e0800f8487d5215 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0baf8271ba99e05efb64207b2ff9d477cf074e951fe8bd338004c8e49d154e0 [INFO] running `Command { std: "docker" "start" "-a" "b0baf8271ba99e05efb64207b2ff9d477cf074e951fe8bd338004c8e49d154e0", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling cc v1.0.26 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking generic-array v0.9.1 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking murmur3 v0.4.1 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling secp256k1 v0.12.2 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking dns-lookup v0.9.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rust-base58 v0.0.4 [INFO] [stderr] Checking sv v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 176 | let mut tcp_stream = self.tcp_writer.lock().unwrap(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | if let Some(peer) = self.strong_self() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 28 | let (poller, future) = Poller::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.subscribe(&poller); [INFO] [stdout] 30 | match future.get_timeout(duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>>>, TryLockError>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 82 | let weak_observer = Arc::downgrade(observer) as Weak>; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | match self.observers.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer/peer.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 176 | let mut tcp_stream = self.tcp_writer.lock().unwrap(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | if let Some(peer) = self.strong_self() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sv` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 28 | let (poller, future) = Poller::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.subscribe(&poller); [INFO] [stdout] 30 | match future.get_timeout(duration) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>>>, TryLockError>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/rx.rs:84:15 [INFO] [stdout] | [INFO] [stdout] 82 | let weak_observer = Arc::downgrade(observer) as Weak>; [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | match self.observers.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sv` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "b0baf8271ba99e05efb64207b2ff9d477cf074e951fe8bd338004c8e49d154e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0baf8271ba99e05efb64207b2ff9d477cf074e951fe8bd338004c8e49d154e0", kill_on_drop: false }` [INFO] [stdout] b0baf8271ba99e05efb64207b2ff9d477cf074e951fe8bd338004c8e49d154e0