[INFO] fetching crate sudo-rs 0.2.3... [INFO] checking sudo-rs-0.2.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sudo-rs 0.2.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sudo-rs 0.2.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sudo-rs 0.2.3 [INFO] finished tweaking crates.io crate sudo-rs 0.2.3 [INFO] tweaked toml for crates.io crate sudo-rs 0.2.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate sudo-rs 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd62238fa02ce035cc84c47dde3b9d24be8218f5ad81bdee1bd8ab8bba3804b9 [INFO] running `Command { std: "docker" "start" "-a" "cd62238fa02ce035cc84c47dde3b9d24be8218f5ad81bdee1bd8ab8bba3804b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd62238fa02ce035cc84c47dde3b9d24be8218f5ad81bdee1bd8ab8bba3804b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd62238fa02ce035cc84c47dde3b9d24be8218f5ad81bdee1bd8ab8bba3804b9", kill_on_drop: false }` [INFO] [stdout] cd62238fa02ce035cc84c47dde3b9d24be8218f5ad81bdee1bd8ab8bba3804b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17a14d818e476d7509d0d0b350b451e7a82fc2378816ed3f9d733a17446e36ee [INFO] running `Command { std: "docker" "start" "-a" "17a14d818e476d7509d0d0b350b451e7a82fc2378816ed3f9d733a17446e36ee", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling sudo-rs v0.2.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/resolve.rs:156:11 [INFO] [stdout] | [INFO] [stdout] 150 | from_name: impl FnOnce(&CStr) -> Result, E>, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | from_id: impl FnOnce(I) -> Result, E>, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | match input.as_ref().and_then(NameOrId::parse) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pam/mod.rs:45:56 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn build(self) -> PamResult> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | if let (Some(converser), Some(service_name)) = (self.converser, self.service_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sudo-rs` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/resolve.rs:156:11 [INFO] [stdout] | [INFO] [stdout] 150 | from_name: impl FnOnce(&CStr) -> Result, E>, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | from_id: impl FnOnce(I) -> Result, E>, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | match input.as_ref().and_then(NameOrId::parse) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pam/mod.rs:45:56 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn build(self) -> PamResult> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | if let (Some(converser), Some(service_name)) = (self.converser, self.service_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/common/bin_serde.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn different_types() { [INFO] [stdout] | ------------------------ move the `impl` block outside of this function `different_types` [INFO] [stdout] 118 | impl DeSerialize for u8 { [INFO] [stdout] | ^^^^^-----------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `DeSerialize` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/system/interface.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 100 | fn test_default() { [INFO] [stdout] | ----------------- move the `impl` block outside of this function `test_default` [INFO] [stdout] 101 | impl UnixUser for () {} [INFO] [stdout] | ^^^^^--------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `UnixUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sudo-rs` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "17a14d818e476d7509d0d0b350b451e7a82fc2378816ed3f9d733a17446e36ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17a14d818e476d7509d0d0b350b451e7a82fc2378816ed3f9d733a17446e36ee", kill_on_drop: false }` [INFO] [stdout] 17a14d818e476d7509d0d0b350b451e7a82fc2378816ed3f9d733a17446e36ee