[INFO] fetching crate subsrch 0.1.0... [INFO] checking subsrch-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate subsrch 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate subsrch 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate subsrch 0.1.0 [INFO] finished tweaking crates.io crate subsrch 0.1.0 [INFO] tweaked toml for crates.io crate subsrch 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding quote v0.3.15 (available: v1.0.37) [INFO] [stderr] Adding strsim v0.8.0 (available: v0.11.1) [INFO] [stderr] Adding structopt v0.1.7 (available: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.1.6 (available: v0.4.18) [INFO] [stderr] Adding syn v0.11.11 (available: v2.0.79) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding unicode-xid v0.0.4 (available: v0.2.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ac728c40b3760f6f11ce5301fcdcc9108c2667db8d73cdc558ebe3eb8e797f9 [INFO] running `Command { std: "docker" "start" "-a" "9ac728c40b3760f6f11ce5301fcdcc9108c2667db8d73cdc558ebe3eb8e797f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ac728c40b3760f6f11ce5301fcdcc9108c2667db8d73cdc558ebe3eb8e797f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ac728c40b3760f6f11ce5301fcdcc9108c2667db8d73cdc558ebe3eb8e797f9", kill_on_drop: false }` [INFO] [stdout] 9ac728c40b3760f6f11ce5301fcdcc9108c2667db8d73cdc558ebe3eb8e797f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7041234e255d5ab565baec4204439b4ed2276ce94f2b41a55d1476e7b5480b55 [INFO] running `Command { std: "docker" "start" "-a" "7041234e255d5ab565baec4204439b4ed2276ce94f2b41a55d1476e7b5480b55", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling structopt-derive v0.1.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking structopt v0.1.7 [INFO] [stderr] Checking subsrch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/range.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub trait RangeStrategy [INFO] [stdout] | ------------- associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 61 | fn new(initial_len: usize) -> Range { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(StructOpt)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SubSrch` is not local [INFO] [stdout] | `StructOpt` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_STRUCTOPT_FOR_SubSrch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `StructOpt` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `StructOpt` may come from an old version of the `structopt_derive` crate, try updating your dependency with `cargo update -p structopt_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `StructOpt` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(StructOpt)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SubSrch` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_STRUCTOPT_FOR_SubSrch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `StructOpt` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `StructOpt` may come from an old version of the `structopt_derive` crate, try updating your dependency with `cargo update -p structopt_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `StructOpt` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RangeNext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/maximal.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 133 | let mut range = MaximalRange::new(4); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | match range.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RangeNext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minimal.rs:150:15 [INFO] [stdout] | [INFO] [stdout] 145 | let mut range = MinimalRange::new(4); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | match range.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(StructOpt)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SubSrch` is not local [INFO] [stdout] | `StructOpt` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_STRUCTOPT_FOR_SubSrch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `StructOpt` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `StructOpt` may come from an old version of the `structopt_derive` crate, try updating your dependency with `cargo update -p structopt_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `StructOpt` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(StructOpt)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SubSrch` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_STRUCTOPT_FOR_SubSrch` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `StructOpt` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `StructOpt` may come from an old version of the `structopt_derive` crate, try updating your dependency with `cargo update -p structopt_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `StructOpt` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `subsrch` (bin "subsrch" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7041234e255d5ab565baec4204439b4ed2276ce94f2b41a55d1476e7b5480b55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7041234e255d5ab565baec4204439b4ed2276ce94f2b41a55d1476e7b5480b55", kill_on_drop: false }` [INFO] [stdout] 7041234e255d5ab565baec4204439b4ed2276ce94f2b41a55d1476e7b5480b55