[INFO] fetching crate structsy-derive 0.5.2... [INFO] checking structsy-derive-0.5.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate structsy-derive 0.5.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate structsy-derive 0.5.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate structsy-derive 0.5.2 [INFO] finished tweaking crates.io crate structsy-derive 0.5.2 [INFO] tweaked toml for crates.io crate structsy-derive 0.5.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1bc92fbeae3d6a22aad19d73ca17b5aa6c76bbb62e1b08f8180063b29d6718a [INFO] running `Command { std: "docker" "start" "-a" "a1bc92fbeae3d6a22aad19d73ca17b5aa6c76bbb62e1b08f8180063b29d6718a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1bc92fbeae3d6a22aad19d73ca17b5aa6c76bbb62e1b08f8180063b29d6718a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1bc92fbeae3d6a22aad19d73ca17b5aa6c76bbb62e1b08f8180063b29d6718a", kill_on_drop: false }` [INFO] [stdout] a1bc92fbeae3d6a22aad19d73ca17b5aa6c76bbb62e1b08f8180063b29d6718a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83f5b11735942fe7fe53373bbe15b9a6b9c4378ca047166cf166c70ca9584e27 [INFO] running `Command { std: "docker" "start" "-a" "83f5b11735942fe7fe53373bbe15b9a6b9c4378ca047166cf166c70ca9584e27", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking darling_core v0.14.4 [INFO] [stderr] Checking synstructure v0.12.6 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking darling v0.14.4 [INFO] [stderr] Checking structsy-derive v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `TraitItemMethod` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries.rs:160:30 [INFO] [stdout] | [INFO] [stdout] 159 | fn impl_trait_methods(item: TraitItem, target_type: &str, embedded: bool) -> Option { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | if let TraitItem::Method(m) = item { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 210 | Some(quote! { [INFO] [stdout] | __________________________- [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] 211 | | #sign { [INFO] [stdout] 212 | | use structsy::internal::EmbeddedQuery; [INFO] [stdout] 213 | | let mut filter = structsy::Filter::<#type_ident>::new(); [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] 218 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | } else { [INFO] [stdout] 220 | Some(quote! { [INFO] [stdout] | __________________________- [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] 221 | | #sign { [INFO] [stdout] 222 | | use structsy::internal::Query; [INFO] [stdout] 223 | | let mut filter = structsy::Filter::<#type_ident>::new(); [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | Some(quote! { [INFO] [stdout] | ______________________- [INFO] [stdout] | |______________________| [INFO] [stdout] | |______________________| [INFO] [stdout] | |______________________| [INFO] [stdout] | |______________________| [INFO] [stdout] 232 | | #sign { [INFO] [stdout] 233 | | let filter = &mut self; [INFO] [stdout] 234 | | #( #conditions)* [INFO] [stdout] 235 | | self [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TraitItemMethod` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/queries.rs:160:30 [INFO] [stdout] | [INFO] [stdout] 159 | fn impl_trait_methods(item: TraitItem, target_type: &str, embedded: bool) -> Option { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | if let TraitItem::Method(m) = item { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 210 | Some(quote! { [INFO] [stdout] | __________________________- [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] 211 | | #sign { [INFO] [stdout] 212 | | use structsy::internal::EmbeddedQuery; [INFO] [stdout] 213 | | let mut filter = structsy::Filter::<#type_ident>::new(); [INFO] [stdout] ... | [INFO] [stdout] 217 | | } [INFO] [stdout] 218 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | } else { [INFO] [stdout] 220 | Some(quote! { [INFO] [stdout] | __________________________- [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________| [INFO] [stdout] 221 | | #sign { [INFO] [stdout] 222 | | use structsy::internal::Query; [INFO] [stdout] 223 | | let mut filter = structsy::Filter::<#type_ident>::new(); [INFO] [stdout] ... | [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | Some(quote! { [INFO] [stdout] | ______________________- [INFO] [stdout] | |______________________| [INFO] [stdout] | |______________________| [INFO] [stdout] | |______________________| [INFO] [stdout] | |______________________| [INFO] [stdout] 232 | | #sign { [INFO] [stdout] 233 | | let filter = &mut self; [INFO] [stdout] 234 | | #( #conditions)* [INFO] [stdout] 235 | | self [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/queries.rs:114:49 [INFO] [stdout] | [INFO] [stdout] 114 | if let Type::Path(ref p) = t.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `syn::Type` does not implement `Borrow`, so calling `borrow` on `&syn::Type` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 114 - if let Type::Path(ref p) = t.borrow() { [INFO] [stdout] 114 + if let Type::Path(ref p) = t { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `syn::Type`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/macros.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | $mac!([$(#[$m])* #[derive(Clone)] [INFO] [stdout] | ++++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structsy-derive` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/queries.rs:114:49 [INFO] [stdout] | [INFO] [stdout] 114 | if let Type::Path(ref p) = t.borrow() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `syn::Type` does not implement `Borrow`, so calling `borrow` on `&syn::Type` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 114 - if let Type::Path(ref p) = t.borrow() { [INFO] [stdout] 114 + if let Type::Path(ref p) = t { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `syn::Type`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/macros.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | $mac!([$(#[$m])* #[derive(Clone)] [INFO] [stdout] | ++++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structsy-derive` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "83f5b11735942fe7fe53373bbe15b9a6b9c4378ca047166cf166c70ca9584e27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83f5b11735942fe7fe53373bbe15b9a6b9c4378ca047166cf166c70ca9584e27", kill_on_drop: false }` [INFO] [stdout] 83f5b11735942fe7fe53373bbe15b9a6b9c4378ca047166cf166c70ca9584e27