[INFO] fetching crate storage-trait 0.1.4... [INFO] checking storage-trait-0.1.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate storage-trait 0.1.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate storage-trait 0.1.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate storage-trait 0.1.4 [INFO] finished tweaking crates.io crate storage-trait 0.1.4 [INFO] tweaked toml for crates.io crate storage-trait 0.1.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate storage-trait 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91e9865571ea4a840260914e909ba31363d95dd83206b59745893f91960291fa [INFO] running `Command { std: "docker" "start" "-a" "91e9865571ea4a840260914e909ba31363d95dd83206b59745893f91960291fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91e9865571ea4a840260914e909ba31363d95dd83206b59745893f91960291fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91e9865571ea4a840260914e909ba31363d95dd83206b59745893f91960291fa", kill_on_drop: false }` [INFO] [stdout] 91e9865571ea4a840260914e909ba31363d95dd83206b59745893f91960291fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa9f409651a1cae5d06f48a9ceb7b46f20e146fe7ada69599361149f4d5fc123 [INFO] running `Command { std: "docker" "start" "-a" "aa9f409651a1cae5d06f48a9ceb7b46f20e146fe7ada69599361149f4d5fc123", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling async-trait v0.1.57 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking combine v4.6.4 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking dashmap v5.3.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking redis v0.21.5 [INFO] [stderr] Checking storage-trait v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 22 | fn set(&self, key: K, value: V) -> Result<(), Err> { [INFO] [stdout] | --- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | fn set_ex(&self, key: K, value: V, expire: Duration) -> Result<(), Err> { [INFO] [stdout] | --- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 40 | fn get(&self, key: K) -> Result, Err> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 56 | fn del(&self, key: K) -> Result, Err> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:66:15 [INFO] [stdout] | [INFO] [stdout] 65 | fn contains(&self, key: K) -> Result { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `storage-trait` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 22 | fn set(&self, key: K, value: V) -> Result<(), Err> { [INFO] [stdout] | --- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 31 | fn set_ex(&self, key: K, value: V, expire: Duration) -> Result<(), Err> { [INFO] [stdout] | --- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 40 | fn get(&self, key: K) -> Result, Err> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 56 | fn del(&self, key: K) -> Result, Err> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_storage.rs:66:15 [INFO] [stdout] | [INFO] [stdout] 65 | fn contains(&self, key: K) -> Result { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | match self.client.get_connection() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `storage-trait` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "aa9f409651a1cae5d06f48a9ceb7b46f20e146fe7ada69599361149f4d5fc123", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa9f409651a1cae5d06f48a9ceb7b46f20e146fe7ada69599361149f4d5fc123", kill_on_drop: false }` [INFO] [stdout] aa9f409651a1cae5d06f48a9ceb7b46f20e146fe7ada69599361149f4d5fc123