[INFO] fetching crate stateright 0.30.2... [INFO] checking stateright-0.30.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate stateright 0.30.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate stateright 0.30.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stateright 0.30.2 [INFO] finished tweaking crates.io crate stateright 0.30.2 [INFO] tweaked toml for crates.io crate stateright 0.30.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate stateright 0.30.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dae1c01afd1775b2516ed7853599e97bb9ba4255714081e4de495998d65d8b06 [INFO] running `Command { std: "docker" "start" "-a" "dae1c01afd1775b2516ed7853599e97bb9ba4255714081e4de495998d65d8b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dae1c01afd1775b2516ed7853599e97bb9ba4255714081e4de495998d65d8b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dae1c01afd1775b2516ed7853599e97bb9ba4255714081e4de495998d65d8b06", kill_on_drop: false }` [INFO] [stdout] dae1c01afd1775b2516ed7853599e97bb9ba4255714081e4de495998d65d8b06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f535cf58c978456449ca3b67c9c97110034d604415d6187230b34dea5f40e73 [INFO] running `Command { std: "docker" "start" "-a" "5f535cf58c978456449ca3b67c9c97110034d604415d6187230b34dea5f40e73", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking choice v0.0.2 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking id-set v0.2.2 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking stateright v0.30.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `parking_lot::lock_api::RwLockReadGuard<'_, parking_lot::RawRwLock, Snapshot<::Action>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checker/explorer.rs:188:22 [INFO] [stdout] | [INFO] [stdout] 171 | fn status(data: Data) -> StatusView [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | recent_path: snapshot.read().1.as_ref().map(|p| format!("{:?}", p)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, Vec<::State>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checker/visitor.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 93 | fn visit(&self, _: &M, path: Path) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | self.0.lock().unwrap().push(path.last_state().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, network::Envelope, usize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor/network.rs:229:65 [INFO] [stdout] | [INFO] [stdout] 219 | pub(crate) fn on_deliver(&mut self, envelope: Envelope) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Network::UnorderedNonDuplicating(multiset) => match multiset.entry(envelope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, network::Envelope, usize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor/network.rs:277:65 [INFO] [stdout] | [INFO] [stdout] 269 | pub(crate) fn on_drop(&mut self, envelope: Envelope) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | Network::UnorderedNonDuplicating(multiset) => match multiset.entry(envelope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::RwLockReadGuard<'_, parking_lot::RawRwLock, explorer::Snapshot<::Action>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checker/explorer.rs:188:22 [INFO] [stdout] | [INFO] [stdout] 171 | fn status(data: Data) -> StatusView [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | recent_path: snapshot.read().1.as_ref().map(|p| format!("{:?}", p)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stateright` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, Vec<::State>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checker/visitor.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 93 | fn visit(&self, _: &M, path: Path) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | self.0.lock().unwrap().push(path.last_state().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, network::Envelope, usize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor/network.rs:229:65 [INFO] [stdout] | [INFO] [stdout] 219 | pub(crate) fn on_deliver(&mut self, envelope: Envelope) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | Network::UnorderedNonDuplicating(multiset) => match multiset.entry(envelope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, network::Envelope, usize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actor/network.rs:277:65 [INFO] [stdout] | [INFO] [stdout] 269 | pub(crate) fn on_drop(&mut self, envelope: Envelope) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | Network::UnorderedNonDuplicating(multiset) => match multiset.entry(envelope) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stateright` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5f535cf58c978456449ca3b67c9c97110034d604415d6187230b34dea5f40e73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f535cf58c978456449ca3b67c9c97110034d604415d6187230b34dea5f40e73", kill_on_drop: false }` [INFO] [stdout] 5f535cf58c978456449ca3b67c9c97110034d604415d6187230b34dea5f40e73