[INFO] fetching crate starlight 0.4.0... [INFO] checking starlight-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate starlight 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate starlight 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlight 0.4.0 [INFO] finished tweaking crates.io crate starlight 0.4.0 [INFO] tweaked toml for crates.io crate starlight 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8908f71e17f175426d7a62e5eaf2ff6ecf12669ddac9595275224c09bcdd6465 [INFO] running `Command { std: "docker" "start" "-a" "8908f71e17f175426d7a62e5eaf2ff6ecf12669ddac9595275224c09bcdd6465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8908f71e17f175426d7a62e5eaf2ff6ecf12669ddac9595275224c09bcdd6465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8908f71e17f175426d7a62e5eaf2ff6ecf12669ddac9595275224c09bcdd6465", kill_on_drop: false }` [INFO] [stdout] 8908f71e17f175426d7a62e5eaf2ff6ecf12669ddac9595275224c09bcdd6465 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 047bd3d27a294cb9fc8064e6dbd589207f5b98a3922a8dd25210c0aba4e6fa01 [INFO] running `Command { std: "docker" "start" "-a" "047bd3d27a294cb9fc8064e6dbd589207f5b98a3922a8dd25210c0aba4e6fa01", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling const_fn v0.4.10 [INFO] [stderr] Compiling recasting v0.2.1 [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking triple_arena v0.13.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Compiling awint_internals v0.17.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling awint_core v0.17.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling awint_ext v0.17.0 [INFO] [stderr] Compiling awint_macro_internals v0.17.0 [INFO] [stderr] Compiling awint_macros v0.17.0 [INFO] [stderr] Checking awint_dag v0.17.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking awint v0.17.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking starlight v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/epoch.rs:201:44 [INFO] [stdout] | [INFO] [stdout] 200 | let mut current = top.borrow_mut(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | if let Some(ref to_drop) = current.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/epoch.rs:245:33 [INFO] [stdout] | [INFO] [stdout] 244 | let mut lock = self.epoch_data.borrow_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | if let Some(mut ours) = lock.responsible_for.remove(self.p_self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, EpochData>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/epoch.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn ensemble O>(&self, mut f: F) -> O { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | f(&self.epoch_data.borrow().ensemble) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, EpochData>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/temporal.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 226 | let epoch = get_current_epoch()?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let mut lock = epoch.epoch_data.borrow_mut(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `awint::awint_dag::smallvec::IntoIter<[std::option::Option; 1]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ensemble/rnode.rs:388:23 [INFO] [stdout] | [INFO] [stdout] 384 | let rnode = self.notary.rnodes.remove(p_rnode).unwrap().1; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | for p_back in rnode.bits { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/epoch.rs:201:44 [INFO] [stdout] | [INFO] [stdout] 200 | let mut current = top.borrow_mut(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | if let Some(ref to_drop) = current.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/epoch.rs:245:33 [INFO] [stdout] | [INFO] [stdout] 244 | let mut lock = self.epoch_data.borrow_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | if let Some(mut ours) = lock.responsible_for.remove(self.p_self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, EpochData>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/epoch.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn ensemble O>(&self, mut f: F) -> O { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | f(&self.epoch_data.borrow().ensemble) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, EpochData>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/awi_structs/temporal.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 226 | let epoch = get_current_epoch()?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let mut lock = epoch.epoch_data.borrow_mut(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmallVec<[PState; 4]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lower/meta.rs:863:13 [INFO] [stdout] | [INFO] [stdout] 81 | match create_static_lut( [INFO] [stdout] | _______________- [INFO] [stdout] | |_______________| [INFO] [stdout] | |_______________| [INFO] [stdout] 82 | | smallvec![$( [INFO] [stdout] 83 | | $inx.state(), [INFO] [stdout] 84 | | )*], [INFO] [stdout] 85 | | {use awi::*; awi!($lut)} [INFO] [stdout] 86 | | ) { [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 863 | | let mut out = SmallVec::with_capacity(lhs.bw()); [INFO] [stdout] | | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmallVec<[PState; 4]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lower/meta.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 81 | match create_static_lut( [INFO] [stdout] | _______________- [INFO] [stdout] | |_______________| [INFO] [stdout] | |_______________| [INFO] [stdout] 82 | | smallvec![$( [INFO] [stdout] 83 | | $inx.state(), [INFO] [stdout] 84 | | )*], [INFO] [stdout] 85 | | {use awi::*; awi!($lut)} [INFO] [stdout] 86 | | ) { [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 933 | | let mut out = SmallVec::with_capacity(lhs.bw()); [INFO] [stdout] | | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `awint::awint_dag::smallvec::IntoIter<[std::option::Option; 1]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ensemble/rnode.rs:388:23 [INFO] [stdout] | [INFO] [stdout] 384 | let rnode = self.notary.rnodes.remove(p_rnode).unwrap().1; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | for p_back in rnode.bits { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmallVec<[PState; 4]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lower/meta.rs:863:13 [INFO] [stdout] | [INFO] [stdout] 81 | match create_static_lut( [INFO] [stdout] | _______________- [INFO] [stdout] | |_______________| [INFO] [stdout] | |_______________| [INFO] [stdout] 82 | | smallvec![$( [INFO] [stdout] 83 | | $inx.state(), [INFO] [stdout] 84 | | )*], [INFO] [stdout] 85 | | {use awi::*; awi!($lut)} [INFO] [stdout] 86 | | ) { [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 863 | | let mut out = SmallVec::with_capacity(lhs.bw()); [INFO] [stdout] | | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmallVec<[PState; 4]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lower/meta.rs:933:13 [INFO] [stdout] | [INFO] [stdout] 81 | match create_static_lut( [INFO] [stdout] | _______________- [INFO] [stdout] | |_______________| [INFO] [stdout] | |_______________| [INFO] [stdout] 82 | | smallvec![$( [INFO] [stdout] 83 | | $inx.state(), [INFO] [stdout] 84 | | )*], [INFO] [stdout] 85 | | {use awi::*; awi!($lut)} [INFO] [stdout] 86 | | ) { [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 933 | | let mut out = SmallVec::with_capacity(lhs.bw()); [INFO] [stdout] | | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlight` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlight` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "047bd3d27a294cb9fc8064e6dbd589207f5b98a3922a8dd25210c0aba4e6fa01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "047bd3d27a294cb9fc8064e6dbd589207f5b98a3922a8dd25210c0aba4e6fa01", kill_on_drop: false }` [INFO] [stdout] 047bd3d27a294cb9fc8064e6dbd589207f5b98a3922a8dd25210c0aba4e6fa01