[INFO] fetching crate starlark_derive 0.12.0... [INFO] checking starlark_derive-0.12.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate starlark_derive 0.12.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate starlark_derive 0.12.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlark_derive 0.12.0 [INFO] finished tweaking crates.io crate starlark_derive 0.12.0 [INFO] tweaked toml for crates.io crate starlark_derive 0.12.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 35eedea8947d5d702d14e52c87872c7bf3bb5cd26929160864fe91182d877dea [INFO] running `Command { std: "docker" "start" "-a" "35eedea8947d5d702d14e52c87872c7bf3bb5cd26929160864fe91182d877dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "35eedea8947d5d702d14e52c87872c7bf3bb5cd26929160864fe91182d877dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35eedea8947d5d702d14e52c87872c7bf3bb5cd26929160864fe91182d877dea", kill_on_drop: false }` [INFO] [stdout] 35eedea8947d5d702d14e52c87872c7bf3bb5cd26929160864fe91182d877dea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dfbdce5be046f498845a15c138dcfcb2c5d7ece174b57364a6ccd50a1d3dd406 [INFO] running `Command { std: "docker" "start" "-a" "dfbdce5be046f498845a15c138dcfcb2c5d7ece174b57364a6ccd50a1d3dd406", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Checking starlark_derive v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 32 | field_handler: impl Fn(&Ident, &Field) -> syn::Result, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let field_handlers = field_names [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 46 | | s.struct_token.span => { [INFO] [stdout] 47 | | let Self(#(#field_names),*) = self; [INFO] [stdout] 48 | | #(#field_handlers)* [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 60 | | s.struct_token.span => { [INFO] [stdout] 61 | | let Self { #(#field_names),* } = self; [INFO] [stdout] 62 | | #(#field_handlers)* [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let field_handlers = field_names [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 88 | | v.ident.span() => [INFO] [stdout] 89 | | Self::#variant_name(#(#field_names),*) => { [INFO] [stdout] 90 | | #(#field_handlers)* [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 102 | | v.ident.span() => [INFO] [stdout] 103 | | Self::#variant_name { #(#field_names),* } => { [INFO] [stdout] 104 | | #(#field_handlers)* [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 32 | field_handler: impl Fn(&Ident, &Field) -> syn::Result, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let field_handlers = field_names [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 46 | | s.struct_token.span => { [INFO] [stdout] 47 | | let Self(#(#field_names),*) = self; [INFO] [stdout] 48 | | #(#field_handlers)* [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 60 | | s.struct_token.span => { [INFO] [stdout] 61 | | let Self { #(#field_names),* } = self; [INFO] [stdout] 62 | | #(#field_handlers)* [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let field_handlers = field_names [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 88 | | v.ident.span() => [INFO] [stdout] 89 | | Self::#variant_name(#(#field_names),*) => { [INFO] [stdout] 90 | | #(#field_handlers)* [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 102 | | v.ident.span() => [INFO] [stdout] 103 | | Self::#variant_name { #(#field_names),* } => { [INFO] [stdout] 104 | | #(#field_handlers)* [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_derive` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_derive` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "dfbdce5be046f498845a15c138dcfcb2c5d7ece174b57364a6ccd50a1d3dd406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfbdce5be046f498845a15c138dcfcb2c5d7ece174b57364a6ccd50a1d3dd406", kill_on_drop: false }` [INFO] [stdout] dfbdce5be046f498845a15c138dcfcb2c5d7ece174b57364a6ccd50a1d3dd406