[INFO] fetching crate ssh-utils 0.1.3... [INFO] checking ssh-utils-0.1.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ssh-utils 0.1.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ssh-utils 0.1.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ssh-utils 0.1.3 [INFO] finished tweaking crates.io crate ssh-utils 0.1.3 [INFO] tweaked toml for crates.io crate ssh-utils 0.1.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate ssh-utils 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61b70c761317ce576b0e595cdbeb96520fe7bb7817b8358a77b35ba2c0698776 [INFO] running `Command { std: "docker" "start" "-a" "61b70c761317ce576b0e595cdbeb96520fe7bb7817b8358a77b35ba2c0698776", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61b70c761317ce576b0e595cdbeb96520fe7bb7817b8358a77b35ba2c0698776", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61b70c761317ce576b0e595cdbeb96520fe7bb7817b8358a77b35ba2c0698776", kill_on_drop: false }` [INFO] [stdout] 61b70c761317ce576b0e595cdbeb96520fe7bb7817b8358a77b35ba2c0698776 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3edbab4edf4a32dbd686d6f0113b85fa0188f3b21de8971701aaae1f817fb6e [INFO] running `Command { std: "docker" "start" "-a" "e3edbab4edf4a32dbd686d6f0113b85fa0188f3b21de8971701aaae1f817fb6e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling io-lifetimes v0.6.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking is_ci v1.1.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking supports-color v1.3.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking owo-colors v3.3.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Compiling typed-builder v0.10.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking clap v3.1.8 [INFO] [stderr] Checking clap-verbosity-flag v1.0.0 [INFO] [stderr] Checking tokio-io-utility v0.6.6 [INFO] [stderr] Checking sendfd v0.4.1 [INFO] [stderr] Checking tokio-pipe v0.2.11 [INFO] [stderr] Checking ssh_format v0.12.0 [INFO] [stderr] Checking openssh-mux-client v0.15.0 [INFO] [stderr] Checking openssh v0.9.0 [INFO] [stderr] Checking ssh-utils v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `RemoteChild<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping/logined.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 85 | session: Session, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut child = session [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | / tokio::select! { [INFO] [stdout] 100 | | res = main_loop_impl(args, verbose.clone(), stdin, stdout, stats) => { [INFO] [stdout] 101 | | res?; [INFO] [stdout] ... | [INFO] [stdout] 116 | | }, [INFO] [stdout] 117 | | }?; [INFO] [stdout] | |_____- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::time::Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping/login_failed.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let mut interval = interval(args.interval.0); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | tokio::pin!(shutdown_requested); [INFO] [stdout] | ------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let res = tokio::select! { [INFO] [stdout] | ___________________- [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] 28 | | res = builder.connect() => res, [INFO] [stdout] 29 | | _ = &mut shutdown_requested => { [INFO] [stdout] 30 | | println_on_level!(verbose, Level::Debug, "Ctrl C signal received"); [INFO] [stdout] 31 | | return Ok(()) [INFO] [stdout] 32 | | }, [INFO] [stdout] 33 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::time::Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speedtest/upload.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut interval = interval(Duration::from_secs(5)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | tokio::pin!(shutdown_requested); [INFO] [stdout] | ------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | / tokio::select! { [INFO] [stdout] 60 | | res = upload(&mut child_stdin, &mut n, &buffer, verbose.clone()) => res?, [INFO] [stdout] 61 | | _ = interval.tick() => (), [INFO] [stdout] 62 | | _ = &mut shutdown_requested => { [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::time::Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speedtest/download.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let mut interval = interval(Duration::from_secs(5)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | tokio::pin!(shutdown_requested); [INFO] [stdout] | ------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / tokio::select! { [INFO] [stdout] 59 | | res = download(&mut child_stdout, &mut n, &mut buffer, verbose.clone()) => { [INFO] [stdout] 60 | | res?; [INFO] [stdout] 61 | | // break on EOF [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RemoteChild<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping/logined.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 85 | session: Session, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let mut child = session [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | / tokio::select! { [INFO] [stdout] 100 | | res = main_loop_impl(args, verbose.clone(), stdin, stdout, stats) => { [INFO] [stdout] 101 | | res?; [INFO] [stdout] ... | [INFO] [stdout] 116 | | }, [INFO] [stdout] 117 | | }?; [INFO] [stdout] | |_____- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::time::Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ping/login_failed.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | let mut interval = interval(args.interval.0); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 21 | tokio::pin!(shutdown_requested); [INFO] [stdout] | ------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let res = tokio::select! { [INFO] [stdout] | ___________________- [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] | |___________________| [INFO] [stdout] 28 | | res = builder.connect() => res, [INFO] [stdout] 29 | | _ = &mut shutdown_requested => { [INFO] [stdout] 30 | | println_on_level!(verbose, Level::Debug, "Ctrl C signal received"); [INFO] [stdout] 31 | | return Ok(()) [INFO] [stdout] 32 | | }, [INFO] [stdout] 33 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::time::Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speedtest/upload.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut interval = interval(Duration::from_secs(5)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | tokio::pin!(shutdown_requested); [INFO] [stdout] | ------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | / tokio::select! { [INFO] [stdout] 60 | | res = upload(&mut child_stdin, &mut n, &buffer, verbose.clone()) => res?, [INFO] [stdout] 61 | | _ = interval.tick() => (), [INFO] [stdout] 62 | | _ = &mut shutdown_requested => { [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-utils` (bin "ssh-utils" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `tokio::time::Interval` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/speedtest/download.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let mut interval = interval(Duration::from_secs(5)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 53 | tokio::pin!(shutdown_requested); [INFO] [stdout] | ------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | / tokio::select! { [INFO] [stdout] 59 | | res = download(&mut child_stdout, &mut n, &mut buffer, verbose.clone()) => { [INFO] [stdout] 60 | | res?; [INFO] [stdout] 61 | | // break on EOF [INFO] [stdout] ... | [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ssh-utils` (bin "ssh-utils") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "e3edbab4edf4a32dbd686d6f0113b85fa0188f3b21de8971701aaae1f817fb6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3edbab4edf4a32dbd686d6f0113b85fa0188f3b21de8971701aaae1f817fb6e", kill_on_drop: false }` [INFO] [stdout] e3edbab4edf4a32dbd686d6f0113b85fa0188f3b21de8971701aaae1f817fb6e