[INFO] fetching crate sqlparser 0.51.0... [INFO] checking sqlparser-0.51.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sqlparser 0.51.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sqlparser 0.51.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sqlparser 0.51.0 [INFO] finished tweaking crates.io crate sqlparser 0.51.0 [INFO] tweaked toml for crates.io crate sqlparser 0.51.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate sqlparser 0.51.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22ccec5c8d1bd302e495f2041feb18ab681ef83ccd2a969a74db033933eac7d2 [INFO] running `Command { std: "docker" "start" "-a" "22ccec5c8d1bd302e495f2041feb18ab681ef83ccd2a969a74db033933eac7d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22ccec5c8d1bd302e495f2041feb18ab681ef83ccd2a969a74db033933eac7d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22ccec5c8d1bd302e495f2041feb18ab681ef83ccd2a969a74db033933eac7d2", kill_on_drop: false }` [INFO] [stdout] 22ccec5c8d1bd302e495f2041feb18ab681ef83ccd2a969a74db033933eac7d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f0000034160576de9c9497a5b4d8c9dc86a022ea520bc0782f8e95b425c59d76 [INFO] running `Command { std: "docker" "start" "-a" "f0000034160576de9c9497a5b4d8c9dc86a022ea520bc0782f8e95b425c59d76", kill_on_drop: false }` [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking sqlparser v0.51.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking simple_logger v5.0.0 [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:3486:24 [INFO] [stdout] | [INFO] [stdout] 3481 | pub fn maybe_parse(&mut self, mut f: F) -> Option [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3486 | if let Ok(t) = f(self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Box, T)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn one_of_identical_results(&self, f: F) -> T [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | / parse_results [INFO] [stdout] 62 | | .fold(None, |s, (dialect, parsed)| { [INFO] [stdout] 63 | | if let Some((prev_dialect, prev_parsed)) = s { [INFO] [stdout] 64 | | assert_eq!( [INFO] [stdout] ... | [INFO] [stdout] 70 | | }) [INFO] [stdout] 71 | | .expect("tested dialects cannot be empty") [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils.rs:257:33 [INFO] [stdout] | [INFO] [stdout] 256 | let mut iter = v.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | if let (Some(item), None) = (iter.next(), iter.next()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqlparser` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:3486:24 [INFO] [stdout] | [INFO] [stdout] 3481 | pub fn maybe_parse(&mut self, mut f: F) -> Option [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3486 | if let Ok(t) = f(self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Box, T)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn one_of_identical_results(&self, f: F) -> T [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | / parse_results [INFO] [stdout] 62 | | .fold(None, |s, (dialect, parsed)| { [INFO] [stdout] 63 | | if let Some((prev_dialect, prev_parsed)) = s { [INFO] [stdout] 64 | | assert_eq!( [INFO] [stdout] ... | [INFO] [stdout] 70 | | }) [INFO] [stdout] 71 | | .expect("tested dialects cannot be empty") [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils.rs:257:33 [INFO] [stdout] | [INFO] [stdout] 256 | let mut iter = v.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | if let (Some(item), None) = (iter.next(), iter.next()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqlparser` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "f0000034160576de9c9497a5b4d8c9dc86a022ea520bc0782f8e95b425c59d76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0000034160576de9c9497a5b4d8c9dc86a022ea520bc0782f8e95b425c59d76", kill_on_drop: false }` [INFO] [stdout] f0000034160576de9c9497a5b4d8c9dc86a022ea520bc0782f8e95b425c59d76