[INFO] fetching crate spacetimedb-commitlog 0.11.1... [INFO] checking spacetimedb-commitlog-0.11.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate spacetimedb-commitlog 0.11.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate spacetimedb-commitlog 0.11.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spacetimedb-commitlog 0.11.1 [INFO] finished tweaking crates.io crate spacetimedb-commitlog 0.11.1 [INFO] tweaked toml for crates.io crate spacetimedb-commitlog 0.11.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 93 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (available: v0.5.1) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding proptest-derive v0.4.0 (available: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 791202cfb65e66cc07d8784390240eaeeba3f79907af0fd0d8f78caa07b6d93f [INFO] running `Command { std: "docker" "start" "-a" "791202cfb65e66cc07d8784390240eaeeba3f79907af0fd0d8f78caa07b6d93f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "791202cfb65e66cc07d8784390240eaeeba3f79907af0fd0d8f78caa07b6d93f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "791202cfb65e66cc07d8784390240eaeeba3f79907af0fd0d8f78caa07b6d93f", kill_on_drop: false }` [INFO] [stdout] 791202cfb65e66cc07d8784390240eaeeba3f79907af0fd0d8f78caa07b6d93f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbb83bd48ceef1d5f57919d8376bb1a34e8c108abbd127c86789a31c3d90e12e [INFO] running `Command { std: "docker" "start" "-a" "cbb83bd48ceef1d5f57919d8376bb1a34e8c108abbd127c86789a31c3d90e12e", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling nohash-hasher v0.2.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking spacetimedb-primitives v0.11.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking second-stack v0.3.5 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking decorum v0.3.1 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling spacetimedb-bindings-macro v0.11.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling proptest-derive v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking spacetimedb-sats v0.11.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking spacetimedb-commitlog v0.11.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::iter::Zip, impl Iterator, as payload::Decoder>::Error>> + '_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:812:24 [INFO] [stdout] | [INFO] [stdout] 809 | let mut log = mem_log::<[u8; 32]>(32); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 812 | for (i, tx) in (0..total_txs).zip(log.transactions_from(0, &ArrayDecoder)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/payload/txdata.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 247 | #[cfg_attr(test, derive(proptest_derive::Arbitrary))] [INFO] [stdout] | ^------------------------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_Inputs` [INFO] [stdout] 248 | pub struct Inputs { [INFO] [stdout] | ------ `Inputs` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `proptest_derive::Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/payload/txdata.rs:296:25 [INFO] [stdout] | [INFO] [stdout] 296 | #[cfg_attr(test, derive(proptest_derive::Arbitrary))] [INFO] [stdout] | ^------------------------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_Outputs` [INFO] [stdout] 297 | pub struct Outputs { [INFO] [stdout] | ------- `Outputs` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `proptest_derive::Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spacetimedb-commitlog` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cbb83bd48ceef1d5f57919d8376bb1a34e8c108abbd127c86789a31c3d90e12e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbb83bd48ceef1d5f57919d8376bb1a34e8c108abbd127c86789a31c3d90e12e", kill_on_drop: false }` [INFO] [stdout] cbb83bd48ceef1d5f57919d8376bb1a34e8c108abbd127c86789a31c3d90e12e