[INFO] fetching crate sonnerie 0.9.1... [INFO] checking sonnerie-0.9.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sonnerie 0.9.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate sonnerie 0.9.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sonnerie 0.9.1 [INFO] finished tweaking crates.io crate sonnerie 0.9.1 [INFO] tweaked toml for crates.io crate sonnerie 0.9.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate sonnerie 0.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 44f6b1943680ad618bb51aefa95b01beab5bf0c10177e66bcdf6264bbd2aa15f [INFO] running `Command { std: "docker" "start" "-a" "44f6b1943680ad618bb51aefa95b01beab5bf0c10177e66bcdf6264bbd2aa15f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "44f6b1943680ad618bb51aefa95b01beab5bf0c10177e66bcdf6264bbd2aa15f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44f6b1943680ad618bb51aefa95b01beab5bf0c10177e66bcdf6264bbd2aa15f", kill_on_drop: false }` [INFO] [stdout] 44f6b1943680ad618bb51aefa95b01beab5bf0c10177e66bcdf6264bbd2aa15f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 03818abe9764fa48b08ae17678ae11ce8c4571b051f817b42f3b98ad1fb75c82 [INFO] running `Command { std: "docker" "start" "-a" "03818abe9764fa48b08ae17678ae11ce8c4571b051f817b42f3b98ad1fb75c82", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling syn v2.0.69 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling cc v1.0.106 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling static_init_macro v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling static_init v1.0.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking sorted-vec v0.8.3 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling lz4-sys v1.9.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking range_union_find v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking min-max-heap v1.3.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking tempfile-fast v0.3.4 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking lending-cell v0.1.1 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking unsigned-varint v0.8.0 [INFO] [stderr] Checking escape_string v0.1.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling concat-idents v1.1.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking choice-string v0.0.1 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking lines_from_request v0.3.1 [INFO] [stderr] Checking lz4 v1.25.0 [INFO] [stderr] Checking shardio v0.8.2 [INFO] [stderr] Checking sonnerie v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Either` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_reader.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(mut r: std::fs::File) -> std::io::Result> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | match SegmentReader::open(&mut r)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(database_reader::DatabaseRecordReader<'_>, database_reader::DatabaseRecordReader<'_>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rayon.rs:27:34 [INFO] [stdout] | [INFO] [stdout] 26 | fn split(self) -> (RecordProducer<'k>, Option>) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | if let Some((first, second)) = self.reader.split() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(bykey::DatabaseKeyReader<'_>, bykey::DatabaseKeyReader<'_>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rayon.rs:72:34 [INFO] [stdout] | [INFO] [stdout] 71 | fn split(self) -> (KeyProducer<'k>, Option>) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | if let Some((first, second)) = self.reader.split() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sonnerie` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Either` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key_reader.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(mut r: std::fs::File) -> std::io::Result> { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | match SegmentReader::open(&mut r)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(database_reader::DatabaseRecordReader<'_>, database_reader::DatabaseRecordReader<'_>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rayon.rs:27:34 [INFO] [stdout] | [INFO] [stdout] 26 | fn split(self) -> (RecordProducer<'k>, Option>) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | if let Some((first, second)) = self.reader.split() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(bykey::DatabaseKeyReader<'_>, bykey::DatabaseKeyReader<'_>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rayon.rs:72:34 [INFO] [stdout] | [INFO] [stdout] 71 | fn split(self) -> (KeyProducer<'k>, Option>) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | if let Some((first, second)) = self.reader.split() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sonnerie` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "03818abe9764fa48b08ae17678ae11ce8c4571b051f817b42f3b98ad1fb75c82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03818abe9764fa48b08ae17678ae11ce8c4571b051f817b42f3b98ad1fb75c82", kill_on_drop: false }` [INFO] [stdout] 03818abe9764fa48b08ae17678ae11ce8c4571b051f817b42f3b98ad1fb75c82