[INFO] fetching crate solana_libra_proptest_helpers 0.0.1-sol5... [INFO] checking solana_libra_proptest_helpers-0.0.1-sol5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate solana_libra_proptest_helpers 0.0.1-sol5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate solana_libra_proptest_helpers 0.0.1-sol5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solana_libra_proptest_helpers 0.0.1-sol5 [INFO] finished tweaking crates.io crate solana_libra_proptest_helpers 0.0.1-sol5 [INFO] tweaked toml for crates.io crate solana_libra_proptest_helpers 0.0.1-sol5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (available: v1.4.0) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding crossbeam v0.7.3 (available: v0.8.4) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (available: v0.5.13) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (available: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (available: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (available: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (available: v0.8.20) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding memoffset v0.5.6 (available: v0.9.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.86) [INFO] [stderr] Adding proptest v0.9.6 (available: v1.5.0) [INFO] [stderr] Adding proptest-derive v0.1.2 (available: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.37) [INFO] [stderr] Adding rand v0.6.5 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (available: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (available: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (available: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (available: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rusty-fork v0.2.2 (available: v0.3.0) [INFO] [stderr] Adding syn v0.15.44 (available: v2.0.79) [INFO] [stderr] Adding unicode-xid v0.1.0 (available: v0.2.6) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1f50f321e9737df5a82649f263eba064c41acc2e8b7725c1dc7929b8c309c38 [INFO] running `Command { std: "docker" "start" "-a" "d1f50f321e9737df5a82649f263eba064c41acc2e8b7725c1dc7929b8c309c38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1f50f321e9737df5a82649f263eba064c41acc2e8b7725c1dc7929b8c309c38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1f50f321e9737df5a82649f263eba064c41acc2e8b7725c1dc7929b8c309c38", kill_on_drop: false }` [INFO] [stdout] d1f50f321e9737df5a82649f263eba064c41acc2e8b7725c1dc7929b8c309c38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15a4984193a7cdea92ae2fe6dca8756a58aec5a9d539fe5087547fde2c119721 [INFO] running `Command { std: "docker" "start" "-a" "15a4984193a7cdea92ae2fe6dca8756a58aec5a9d539fe5087547fde2c119721", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rusty-fork v0.2.2 [INFO] [stderr] Checking proptest v0.9.6 [INFO] [stderr] Compiling proptest-derive v0.1.2 [INFO] [stderr] Checking solana_libra_proptest_helpers v0.0.1-sol5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/unit_tests/repeat_vec_tests.rs:136:23 [INFO] [stdout] | [INFO] [stdout] 136 | Self::next as (fn() -> Self) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 136 - Self::next as (fn() -> Self) [INFO] [stdout] 136 + Self::next as fn() -> Self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `::Tree` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_generator.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn generate(&mut self, strategy: S) -> S::Value { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / strategy [INFO] [stdout] 42 | | .new_tree(&mut self.runner) [INFO] [stdout] 43 | | .expect("creating a new value should succeed") [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:102:10 [INFO] [stdout] | [INFO] [stdout] 102 | #[derive(Arbitrary, Clone, Copy, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_Index` [INFO] [stdout] 103 | pub struct Index(PropIndex); [INFO] [stdout] | ----- `Index` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solana_libra_proptest_helpers` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `::Tree` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_generator.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn generate(&mut self, strategy: S) -> S::Value { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / strategy [INFO] [stdout] 42 | | .new_tree(&mut self.runner) [INFO] [stdout] 43 | | .expect("creating a new value should succeed") [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:102:10 [INFO] [stdout] | [INFO] [stdout] 102 | #[derive(Arbitrary, Clone, Copy, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_Index` [INFO] [stdout] 103 | pub struct Index(PropIndex); [INFO] [stdout] | ----- `Index` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/unit_tests/repeat_vec_tests.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | mem::replace(&mut self.items, new_items); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 112 | let _ = mem::replace(&mut self.items, new_items); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/unit_tests/repeat_vec_tests.rs:141:10 [INFO] [stdout] | [INFO] [stdout] 141 | #[derive(Arbitrary, Clone, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_RepeatVecOp` [INFO] [stdout] 142 | #[proptest(params = "usize")] [INFO] [stdout] 143 | enum RepeatVecOp { [INFO] [stdout] | ----------- `RepeatVecOp` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solana_libra_proptest_helpers` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "15a4984193a7cdea92ae2fe6dca8756a58aec5a9d539fe5087547fde2c119721", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15a4984193a7cdea92ae2fe6dca8756a58aec5a9d539fe5087547fde2c119721", kill_on_drop: false }` [INFO] [stdout] 15a4984193a7cdea92ae2fe6dca8756a58aec5a9d539fe5087547fde2c119721