[INFO] fetching crate sodium-rust 2.1.2... [INFO] checking sodium-rust-2.1.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sodium-rust 2.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sodium-rust 2.1.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sodium-rust 2.1.2 [INFO] finished tweaking crates.io crate sodium-rust 2.1.2 [INFO] tweaked toml for crates.io crate sodium-rust 2.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fdcf79d2260f7dd0617e47c0d4d80abdbb691bd5839efd5a565986ae964304c9 [INFO] running `Command { std: "docker" "start" "-a" "fdcf79d2260f7dd0617e47c0d4d80abdbb691bd5839efd5a565986ae964304c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fdcf79d2260f7dd0617e47c0d4d80abdbb691bd5839efd5a565986ae964304c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fdcf79d2260f7dd0617e47c0d4d80abdbb691bd5839efd5a565986ae964304c9", kill_on_drop: false }` [INFO] [stdout] fdcf79d2260f7dd0617e47c0d4d80abdbb691bd5839efd5a565986ae964304c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8964b576bbf8a63ff2856350a13676c29b1a9a791eb4bbee6b08493ba3cf3c40 [INFO] running `Command { std: "docker" "start" "-a" "8964b576bbf8a63ff2856350a13676c29b1a9a791eb4bbee6b08493ba3cf3c40", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking sodium-rust v2.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stdout] error: this value of type `WeakCell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 52 | let x = self.data.read().unwrap(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | (&*x).clone().unwrap().upgrade().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl_::stream::Stream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:239:25 [INFO] [stdout] | [INFO] [stdout] 224 | let s1 = self.updates(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let spark: Stream> = Stream::new(&sodium_ctx); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | s1.or_else(&spark.map(|x: &Lazy| x.run())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:260:25 [INFO] [stdout] | [INFO] [stdout] 258 | let mut l = f.lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let f = l.as_mut().unwrap(); [INFO] [stdout] 260 | f.call(&self_.sample()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 298 | let mut l = f.lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let f = l.as_mut().unwrap(); [INFO] [stdout] 300 | f.call(&lhs.run(), &rhs.run()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:328:25 [INFO] [stdout] | [INFO] [stdout] 324 | let l = state.lock(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let state2: &(Lazy, Lazy) = l.as_ref().unwrap(); [INFO] [stdout] 326 | let mut l = f.lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | let f = l.as_mut().unwrap(); [INFO] [stdout] 328 | f.call(&state2.0.run(), &state2.1.run()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl_::stream::Stream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 545 | let cca = cca.clone(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 546 | let sodium_ctx = cca.sodium_ctx(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 547 | / Stream::_new(&sodium_ctx, |sa: StreamWeakForwardRef| { [INFO] [stdout] 548 | | let node1 = Node::new( [INFO] [stdout] 549 | | &sodium_ctx, [INFO] [stdout] 550 | | "switch_c outer node", [INFO] [stdout] ... | [INFO] [stdout] 649 | | node2 [INFO] [stdout] 650 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/gc_node.rs:301:18 [INFO] [stdout] | [INFO] [stdout] 263 | let mut roots = Vec::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | for i in to_be_freed { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `WeakStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/stream.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 49 | let x = self.data.read().unwrap(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | (&*x).clone().unwrap().upgrade().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:489:39 [INFO] [stdout] | [INFO] [stdout] 489 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 489 | while let Some(firing) = &data.firing_op { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 489 | if let Some(firing) = &data.firing_op { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sodium-rust` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8964b576bbf8a63ff2856350a13676c29b1a9a791eb4bbee6b08493ba3cf3c40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8964b576bbf8a63ff2856350a13676c29b1a9a791eb4bbee6b08493ba3cf3c40", kill_on_drop: false }` [INFO] [stdout] 8964b576bbf8a63ff2856350a13676c29b1a9a791eb4bbee6b08493ba3cf3c40