[INFO] fetching crate sodium 0.1.3... [INFO] checking sodium-0.1.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sodium 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sodium 0.1.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sodium 0.1.3 [INFO] finished tweaking crates.io crate sodium 0.1.3 [INFO] tweaked toml for crates.io crate sodium 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 747818e389da5fc62dd2067a09289651ce191c070efa4d58e625710b60cfbea0 [INFO] running `Command { std: "docker" "start" "-a" "747818e389da5fc62dd2067a09289651ce191c070efa4d58e625710b60cfbea0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "747818e389da5fc62dd2067a09289651ce191c070efa4d58e625710b60cfbea0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "747818e389da5fc62dd2067a09289651ce191c070efa4d58e625710b60cfbea0", kill_on_drop: false }` [INFO] [stdout] 747818e389da5fc62dd2067a09289651ce191c070efa4d58e625710b60cfbea0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b1a4b9c01334a98dc724ed07ad6cf4b1695bf8b41a05b9034e4f5f01e0b420ea [INFO] running `Command { std: "docker" "start" "-a" "b1a4b9c01334a98dc724ed07ad6cf4b1695bf8b41a05b9034e4f5f01e0b420ea", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking sodium v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v3.2.25 [INFO] [stdout] error: this value of type `WeakCell` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | let x = self.data.read(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | x.clone().unwrap().upgrade().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl_::stream::Stream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:241:25 [INFO] [stdout] | [INFO] [stdout] 227 | let s1 = self.updates(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | let spark: Stream> = Stream::new(&sodium_ctx); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | s1.or_else(&spark.map(|x: &Lazy| x.run())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:261:25 [INFO] [stdout] | [INFO] [stdout] 260 | let mut f = f.lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | f.call(&self_.sample()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:299:25 [INFO] [stdout] | [INFO] [stdout] 298 | let mut f = f.lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | f.call(&lhs.run(), &rhs.run()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:323:25 [INFO] [stdout] | [INFO] [stdout] 321 | let state2 = state.lock(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | let mut f = f.lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | f.call(&state2.0.run(), &state2.1.run()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl_::stream::Stream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/cell.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 531 | let cca = cca.clone(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 532 | let sodium_ctx = cca.sodium_ctx(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | / Stream::_new(&sodium_ctx, |sa: StreamWeakForwardRef| { [INFO] [stdout] 534 | | let node1 = Node::new( [INFO] [stdout] 535 | | &sodium_ctx, [INFO] [stdout] 536 | | NodeName::CELL_SWITCH_C_OUTER, [INFO] [stdout] ... | [INFO] [stdout] 616 | | node2 [INFO] [stdout] 617 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/gc_node.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 281 | let mut roots = Vec::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | for i in to_be_freed { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `WeakStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impl_/stream.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | let x = self.data.read(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | x.clone().unwrap().upgrade().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:531:39 [INFO] [stdout] | [INFO] [stdout] 531 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 531 | while let Some(firing) = &data.firing_op { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 531 | if let Some(firing) = &data.firing_op { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sodium` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b1a4b9c01334a98dc724ed07ad6cf4b1695bf8b41a05b9034e4f5f01e0b420ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1a4b9c01334a98dc724ed07ad6cf4b1695bf8b41a05b9034e4f5f01e0b420ea", kill_on_drop: false }` [INFO] [stdout] b1a4b9c01334a98dc724ed07ad6cf4b1695bf8b41a05b9034e4f5f01e0b420ea