[INFO] fetching crate snocat-cli 0.8.0-alpha.5... [INFO] checking snocat-cli-0.8.0-alpha.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate snocat-cli 0.8.0-alpha.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate snocat-cli 0.8.0-alpha.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snocat-cli 0.8.0-alpha.5 [INFO] finished tweaking crates.io crate snocat-cli 0.8.0-alpha.5 [INFO] tweaked toml for crates.io crate snocat-cli 0.8.0-alpha.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate snocat-cli 0.8.0-alpha.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f912f9912f66829b06b5b2a4e7307c590d8a248962503f70be25d5dcbde50340 [INFO] running `Command { std: "docker" "start" "-a" "f912f9912f66829b06b5b2a4e7307c590d8a248962503f70be25d5dcbde50340", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f912f9912f66829b06b5b2a4e7307c590d8a248962503f70be25d5dcbde50340", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f912f9912f66829b06b5b2a4e7307c590d8a248962503f70be25d5dcbde50340", kill_on_drop: false }` [INFO] [stdout] f912f9912f66829b06b5b2a4e7307c590d8a248962503f70be25d5dcbde50340 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d6d3596e9eed7ef74a56f95fc46ea3f10c52de3687206b0a38adf9e612f203ea [INFO] running `Command { std: "docker" "start" "-a" "d6d3596e9eed7ef74a56f95fc46ea3f10c52de3687206b0a38adf9e612f203ea", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling syn v1.0.107 [INFO] [stderr] Checking once_cell v1.17.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling futures-core v0.3.26 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking futures-sink v0.3.26 [INFO] [stderr] Checking base64 v0.21.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling futures-channel v0.3.26 [INFO] [stderr] Compiling serde_derive v1.0.152 [INFO] [stderr] Compiling futures-task v0.3.26 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Compiling futures-util v0.3.26 [INFO] [stderr] Checking tracing-core v0.1.30 [INFO] [stderr] Compiling rustls v0.21.7 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Checking rustls-pemfile v1.0.2 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking futures-io v0.3.26 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking rustls-native-certs v0.6.2 [INFO] [stderr] Compiling indexmap v1.9.2 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.69 [INFO] [stderr] Compiling serde_json v1.0.93 [INFO] [stderr] Checking time-core v0.1.0 [INFO] [stderr] Checking ryu v1.0.12 [INFO] [stderr] Checking os_str_bytes v6.4.1 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking time v0.3.17 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking itoa v1.0.5 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking pem v3.0.2 [INFO] [stderr] Checking thread_local v1.1.5 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking arc-swap v1.6.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dashmap v5.4.0 [INFO] [stderr] Checking clap v3.2.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking rustls-webpki v0.101.6 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rcgen v0.11.3 [INFO] [stderr] Compiling tracing-attributes v0.1.23 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Compiling futures-macro v0.3.26 [INFO] [stderr] Compiling pin-project-internal v1.0.12 [INFO] [stderr] Checking pin-project v1.0.12 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking quinn-udp v0.4.1 [INFO] [stderr] Checking quinn-proto v0.10.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tracing-subscriber v0.3.16 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking tokio-stream v0.1.11 [INFO] [stderr] Checking quinn v0.10.2 [INFO] [stderr] Checking futures-executor v0.3.26 [INFO] [stderr] Checking futures v0.3.26 [INFO] [stderr] Checking uuid v1.3.0 [INFO] [stderr] Checking snocat v0.8.0-alpha.5 [INFO] [stderr] Checking snocat-cli v0.8.0-alpha.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, Vec + std::marker::Send + Sync>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/mod.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | self: std::sync::Arc, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / self [INFO] [stdout] 50 | | .services [INFO] [stdout] 51 | | .read() [INFO] [stdout] 52 | | .expect("Service registry lock poisoned") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 141 | let matches = app.get_matches(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | match rt.block_on(handler) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/services/demand_proxy.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | Box::new(stop_accepting).cancelled() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, Vec + std::marker::Send + Sync>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/mod.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 45 | self: std::sync::Arc, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / self [INFO] [stdout] 50 | | .services [INFO] [stdout] 51 | | .read() [INFO] [stdout] 52 | | .expect("Service registry lock poisoned") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snocat-cli` (bin "snocat-cli") due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 141 | let matches = app.get_matches(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | match rt.block_on(handler) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/services/demand_proxy.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | Box::new(stop_accepting).cancelled() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snocat-cli` (bin "snocat-cli" test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d6d3596e9eed7ef74a56f95fc46ea3f10c52de3687206b0a38adf9e612f203ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6d3596e9eed7ef74a56f95fc46ea3f10c52de3687206b0a38adf9e612f203ea", kill_on_drop: false }` [INFO] [stdout] d6d3596e9eed7ef74a56f95fc46ea3f10c52de3687206b0a38adf9e612f203ea