[INFO] fetching crate snocat 0.8.0-alpha.5... [INFO] checking snocat-0.8.0-alpha.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate snocat 0.8.0-alpha.5 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate snocat 0.8.0-alpha.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snocat 0.8.0-alpha.5 [INFO] finished tweaking crates.io crate snocat 0.8.0-alpha.5 [INFO] tweaked toml for crates.io crate snocat 0.8.0-alpha.5 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 185 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding float-cmp v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding fred v6.3.2 (available: v9.2.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding mockall v0.11.4 (available: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.11.4 (available: v0.13.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding predicates v2.1.5 (available: v3.1.2) [INFO] [stderr] Adding quinn v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding quinn-proto v0.10.6 (available: v0.11.8) [INFO] [stderr] Adding quinn-udp v0.4.1 (available: v0.5.5) [INFO] [stderr] Adding redis-protocol v4.1.0 (available: v5.0.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding ring v0.16.20 (available: v0.17.8) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding rustls v0.21.12 (available: v0.23.13) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (available: v0.102.8) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding spin v0.5.2 (available: v0.9.8) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding termtree v0.4.1 (available: v0.5.1) [INFO] [stderr] Adding untrusted v0.7.1 (available: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f01084f5838b5e515a37f9d00d29b81b8a3aad5229a7cca86e204ed5a800fd3f [INFO] running `Command { std: "docker" "start" "-a" "f01084f5838b5e515a37f9d00d29b81b8a3aad5229a7cca86e204ed5a800fd3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f01084f5838b5e515a37f9d00d29b81b8a3aad5229a7cca86e204ed5a800fd3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f01084f5838b5e515a37f9d00d29b81b8a3aad5229a7cca86e204ed5a800fd3f", kill_on_drop: false }` [INFO] [stdout] f01084f5838b5e515a37f9d00d29b81b8a3aad5229a7cca86e204ed5a800fd3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e962dbca7ebe2abd3c3813e231863f64507a17876d0d3867179139198c39e25 [INFO] running `Command { std: "docker" "start" "-a" "7e962dbca7ebe2abd3c3813e231863f64507a17876d0d3867179139198c39e25", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking quinn-udp v0.4.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking quinn-proto v0.10.6 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking quinn v0.10.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking snocat v0.8.0-alpha.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/common/daemon/mod.rs:706:34 [INFO] [stdout] | [INFO] [stdout] 706 | pub fn router<'a>(&'a self) -> &Arc { [INFO] [stdout] | -- ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/common/daemon/mod.rs:706:34 [INFO] [stdout] | [INFO] [stdout] 706 | pub fn router<'a>(&'a self) -> &Arc { [INFO] [stdout] | -- ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `futures::future::Either<(Result<::Ok, ::Error>, Pin::Error>> + std::marker::Send>>), (Result<(), ::Error>, Pin<&mut futures::future::MapOk>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mod.rs:219:11 [INFO] [stdout] | [INFO] [stdout] 217 | pin_mut!(fut); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | use future::Either; [INFO] [stdout] 219 | match future::select(fut, tokio::time::sleep(TIMEOUT).map(Ok).boxed()).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:122:34 [INFO] [stdout] | [INFO] [stdout] 120 | predicate: P, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | ) -> Option> { [INFO] [stdout] 122 | if let Some(peers_by_name) = self.by_name.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:125:35 [INFO] [stdout] | [INFO] [stdout] 124 | subtable.iter().find_map(|kv| { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | if let Some(upgraded) = kv.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:148:32 [INFO] [stdout] | [INFO] [stdout] 146 | comparator_predicate: P, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | ) -> Option> { [INFO] [stdout] 148 | if let Some(peers_by_id) = self.by_id.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:167:34 [INFO] [stdout] | [INFO] [stdout] 165 | comparator_predicate: P, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | ) -> Option> { [INFO] [stdout] 167 | if let Some(peers_by_name) = self.by_name.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), TunnelLifecycleError::Error, ::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:835:15 [INFO] [stdout] | [INFO] [stdout] 834 | let close_handle: Weak = Arc::downgrade(&tunnel); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 835 | match this [INFO] [stdout] | _______________^ [INFO] [stdout] 836 | | .clone() [INFO] [stdout] 837 | | .tunnel_lifecycle(tunnel, shutdown_request_listener) [INFO] [stdout] 838 | | .await [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(tokio::sync::watch::Sender>, tokio::sync::watch::Receiver>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/protocol/tunnel/quinn_tunnel.rs:154:40 [INFO] [stdout] | [INFO] [stdout] 81 | let outgoing_cancellation: Arc> = [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | authenticated_notifier: Arc::new(watch::channel(None).0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:122:34 [INFO] [stdout] | [INFO] [stdout] 120 | predicate: P, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | ) -> Option> { [INFO] [stdout] 122 | if let Some(peers_by_name) = self.by_name.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:125:35 [INFO] [stdout] | [INFO] [stdout] 124 | subtable.iter().find_map(|kv| { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | if let Some(upgraded) = kv.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:148:32 [INFO] [stdout] | [INFO] [stdout] 146 | comparator_predicate: P, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | ) -> Option> { [INFO] [stdout] 148 | if let Some(peers_by_id) = self.by_id.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:167:34 [INFO] [stdout] | [INFO] [stdout] 165 | comparator_predicate: P, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | ) -> Option> { [INFO] [stdout] 167 | if let Some(peers_by_name) = self.by_name.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/tunnel_source/mod.rs:76:47 [INFO] [stdout] | [INFO] [stdout] 69 | let endpoint = self.endpoint.clone(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | if let Some(connecting) = futures::ready!(Future::poll(accepting.as_mut(), cx)) { [INFO] [stdout] | ----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), TunnelLifecycleError::Error, ::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/daemon/mod.rs:835:15 [INFO] [stdout] | [INFO] [stdout] 834 | let close_handle: Weak = Arc::downgrade(&tunnel); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 835 | match this [INFO] [stdout] | _______________^ [INFO] [stdout] 836 | | .clone() [INFO] [stdout] 837 | | .tunnel_lifecycle(tunnel, shutdown_request_listener) [INFO] [stdout] 838 | | .await [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/dropkick.rs:218:26 [INFO] [stdout] | [INFO] [stdout] 217 | fn dropkick(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | if let Some(inner) = self.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ext/stream.rs:13:27 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct BoundCounter(Dropkick); [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ext/stream.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | Registered(BoundCounter), [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 72 | Registered(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/common/tunnel_source/mod.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 77 | drop(accepting); [INFO] [stdout] | ^^^^^---------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Pin> + std::marker::Send>>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 77 - drop(accepting); [INFO] [stdout] 77 + let _ = accepting; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snocat` (lib) due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(tokio::sync::watch::Sender>, tokio::sync::watch::Receiver>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/protocol/tunnel/quinn_tunnel.rs:154:40 [INFO] [stdout] | [INFO] [stdout] 81 | let outgoing_cancellation: Arc> = [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | authenticated_notifier: Arc::new(watch::channel(None).0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/tunnel_source/mod.rs:76:47 [INFO] [stdout] | [INFO] [stdout] 69 | let endpoint = self.endpoint.clone(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | if let Some(connecting) = futures::ready!(Future::poll(accepting.as_mut(), cx)) { [INFO] [stdout] | ----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/dropkick.rs:218:26 [INFO] [stdout] | [INFO] [stdout] 217 | fn dropkick(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | if let Some(inner) = self.take() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ext/stream.rs:13:27 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct BoundCounter(Dropkick); [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ext/stream.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | Registered(BoundCounter), [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 72 | Registered(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/common/tunnel_source/mod.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 77 | drop(accepting); [INFO] [stdout] | ^^^^^---------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Pin> + std::marker::Send>>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 77 - drop(accepting); [INFO] [stdout] 77 + let _ = accepting; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snocat` (lib test) due to 10 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7e962dbca7ebe2abd3c3813e231863f64507a17876d0d3867179139198c39e25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e962dbca7ebe2abd3c3813e231863f64507a17876d0d3867179139198c39e25", kill_on_drop: false }` [INFO] [stdout] 7e962dbca7ebe2abd3c3813e231863f64507a17876d0d3867179139198c39e25