[INFO] fetching crate smr 0.1.2... [INFO] checking smr-0.1.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate smr 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate smr 0.1.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smr 0.1.2 [INFO] finished tweaking crates.io crate smr 0.1.2 [INFO] tweaked toml for crates.io crate smr 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 194 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (available: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (available: v0.8.20) [INFO] [stderr] Adding ctor v0.1.26 (available: v0.2.8) [INFO] [stderr] Adding env_logger v0.7.1 (available: v0.11.5) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (available: v2.1.0) [INFO] [stderr] Adding ipc-channel v0.15.0 (available: v0.18.3) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding memoffset v0.6.5 (available: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (available: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (available: v0.6.0) [INFO] [stderr] Adding nix v0.22.3 (available: v0.29.0) [INFO] [stderr] Adding parking_lot v0.11.2 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (available: v0.9.10) [INFO] [stderr] Adding phf v0.10.1 (available: v0.11.2) [INFO] [stderr] Adding phf_generator v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding phf_macros v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding pretty_env_logger v0.4.0 (available: v0.5.0) [INFO] [stderr] Adding procfs v0.10.1 (available: v0.16.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.2.16 (available: v0.5.6) [INFO] [stderr] Adding ringbuffer v0.8.5 (available: v0.15.0) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding strum v0.21.0 (available: v0.26.3) [INFO] [stderr] Adding strum_macros v0.21.1 (available: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding syscallz v0.16.2 (available: v0.17.0) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding uuid v0.8.2 (available: v1.10.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b93072b7a754836ba404aaec9880fd1b37c63113049b7758d77aaac108940118 [INFO] running `Command { std: "docker" "start" "-a" "b93072b7a754836ba404aaec9880fd1b37c63113049b7758d77aaac108940118", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b93072b7a754836ba404aaec9880fd1b37c63113049b7758d77aaac108940118", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b93072b7a754836ba404aaec9880fd1b37c63113049b7758d77aaac108940118", kill_on_drop: false }` [INFO] [stdout] b93072b7a754836ba404aaec9880fd1b37c63113049b7758d77aaac108940118 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28df91d1f5835ec4f20af0779a3e73c71bdda95c067a15c11224c8bfd6e21095 [INFO] running `Command { std: "docker" "start" "-a" "28df91d1f5835ec4f20af0779a3e73c71bdda95c067a15c11224c8bfd6e21095", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling seccomp-sys v0.1.3 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling syscallz v0.16.2 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking ringbuffer v0.8.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking prctl v1.0.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking nix v0.22.3 [INFO] [stderr] Checking procfs v0.10.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking ipc-channel v0.15.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking smr v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `tokio::sync::RwLockReadGuard` that must be used [INFO] [stdout] --> src/pm.rs:185:7 [INFO] [stdout] | [INFO] [stdout] 185 | term.read().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the RwLock will immediately unlock [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 185 | let _ = term.read().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `WorkerManager` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pm_test.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 94 | let pm: PmHandle = (*PM_ADD_REQ.lock()).clone(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | for _ in 0..500 { [INFO] [stdout] 96 | let w = pm.start_worker(()).await.unwrap().grab(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `WorkerManager` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pm_test.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 122 | let pm: PmHandle = (*PM_SLOW_ECHO_REQ.lock()).clone(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | for _ in 0..30 { [INFO] [stdout] 124 | let w = pm.start_worker(()).await.unwrap().grab(); [INFO] [stdout] | ^ [INFO] [stdout] 125 | / tokio::select! { [INFO] [stdout] 126 | | _ = w.invoke(SlowEchoReq { [INFO] [stdout] 127 | | x: 42, [INFO] [stdout] 128 | | delay: Duration::from_millis(15), [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `tokio::sync::RwLockReadGuard` that must be used [INFO] [stdout] --> src/pm.rs:185:7 [INFO] [stdout] | [INFO] [stdout] 185 | term.read().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the RwLock will immediately unlock [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 185 | let _ = term.read().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smr` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "28df91d1f5835ec4f20af0779a3e73c71bdda95c067a15c11224c8bfd6e21095", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28df91d1f5835ec4f20af0779a3e73c71bdda95c067a15c11224c8bfd6e21095", kill_on_drop: false }` [INFO] [stdout] 28df91d1f5835ec4f20af0779a3e73c71bdda95c067a15c11224c8bfd6e21095