[INFO] fetching crate silver-platter 0.5.38... [INFO] checking silver-platter-0.5.38 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate silver-platter 0.5.38 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate silver-platter 0.5.38 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate silver-platter 0.5.38 [INFO] finished tweaking crates.io crate silver-platter 0.5.38 [INFO] tweaked toml for crates.io crate silver-platter 0.5.38 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate silver-platter 0.5.38 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f63203feccd3db9a6ae38c78316a7691a9dd35d72bbdec602c1cff636f61f128 [INFO] running `Command { std: "docker" "start" "-a" "f63203feccd3db9a6ae38c78316a7691a9dd35d72bbdec602c1cff636f61f128", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f63203feccd3db9a6ae38c78316a7691a9dd35d72bbdec602c1cff636f61f128", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f63203feccd3db9a6ae38c78316a7691a9dd35d72bbdec602c1cff636f61f128", kill_on_drop: false }` [INFO] [stdout] f63203feccd3db9a6ae38c78316a7691a9dd35d72bbdec602c1cff636f61f128 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e11e3c36bb64b0d1a2749d88cb32ef92a1fe16492e4103fea0708de02b50ea2 [INFO] running `Command { std: "docker" "start" "-a" "4e11e3c36bb64b0d1a2749d88cb32ef92a1fe16492e4103fea0708de02b50ea2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling once_cell v1.20.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling cc v1.1.19 [INFO] [stderr] Compiling pyo3-build-config v0.22.3 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking rowan v0.15.16 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling pyo3-ffi v0.22.3 [INFO] [stderr] Compiling pyo3-macros-backend v0.22.3 [INFO] [stderr] Compiling pyo3 v0.22.3 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling deb822-derive v0.1.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling pest v2.7.12 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking lazy-regex v3.3.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling pest_meta v2.7.12 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling pyo3-macros v0.22.3 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking whoami v1.5.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling pest_generator v2.7.12 [INFO] [stderr] Checking dirty-tracker v0.3.0 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking patchkit v0.1.8 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking hyper-util v0.1.8 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Compiling pest_derive v2.7.12 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking merge3 v0.2.0 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking distro-info v0.4.0 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking makefile-lossless v0.1.4 [INFO] [stderr] Checking deb822-lossless v0.1.26 [INFO] [stderr] Checking debversion v0.4.3 [INFO] [stderr] Checking pyo3-filelike v0.3.0 [INFO] [stderr] Checking dep3 v0.1.26 [INFO] [stderr] Checking configparser v3.1.0 [INFO] [stderr] Checking debian-changelog v0.1.14 [INFO] [stderr] Checking debian-control v0.1.35 [INFO] [stderr] Checking debian-copyright v0.1.25 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking breezyshim v0.1.197 [INFO] [stderr] Checking debian-analyzer v0.158.14 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking silver-platter v0.5.38 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `pyo3::Bound<'_, PyAny>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/uploader.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 479 | let m = py.import_bound("breezy.plugins.debian.import_dsc")?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | let dbc = m.getattr("DistributionBranch")?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | let dbc = dbc.call1((branch.to_object(py), py.None()))?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | [INFO] [stdout] 483 | dbc.call_method1("revid_of_version", (version.to_object(py),))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/debian/uploader.rs:877:9 [INFO] [stdout] | [INFO] [stdout] 877 | let mut team_upload = false; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `pyo3::Bound<'_, PyAny>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/mod.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 163 | let m = py.import_bound("debian.deb822")?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let changes = m.getattr("Changes")?.call1((contents,))?; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | changes.call_method1("get", ("Binary",))?.extract() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `pyo3::Bound<'_, PyAny>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/mod.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 229 | let m = py.import_bound("breezy.plugins.debian.import_dsc")?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let db = m [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | db.call_method1("revid_of_version", (version,))?.extract() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `ref_resume_branch` is never read [INFO] [stdout] --> src/publish.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | let mut ref_resume_branch = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:317:36 [INFO] [stdout] | [INFO] [stdout] 233 | mut resume_proposal: Option, [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut ref_resume_branch = None; [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | if let Some(resume_proposal) = resume_proposal.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `pyo3::Bound<'_, PyAny>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/uploader.rs:483:9 [INFO] [stdout] | [INFO] [stdout] 479 | let m = py.import_bound("breezy.plugins.debian.import_dsc")?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | let dbc = m.getattr("DistributionBranch")?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | let dbc = dbc.call1((branch.to_object(py), py.None()))?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | [INFO] [stdout] 483 | dbc.call_method1("revid_of_version", (version.to_object(py),))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:624:13 [INFO] [stdout] | [INFO] [stdout] 603 | forge: Option, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | let forge = if let Some(forge) = forge { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | self.local_tree().branch().as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:664:13 [INFO] [stdout] | [INFO] [stdout] 651 | forge: Option, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | let forge = if let Some(forge) = forge { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 664 | self.local_tree().branch().as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:701:13 [INFO] [stdout] | [INFO] [stdout] 683 | let forge = match breezyshim::forge::get_forge(main_branch) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 701 | self.local_tree().branch().as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:731:13 [INFO] [stdout] | [INFO] [stdout] 726 | outf: Box, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 731 | self.base_tree()?.as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `commit_id` and `message` are never read [INFO] [stdout] --> src/debian/uploader.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 224 | pub struct GitRevision { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 225 | commit_id: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 226 | headers: HashMap, [INFO] [stdout] 227 | message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/debian/vcswatch.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | CommitterNotAllowed(String), [INFO] [stdout] | ------------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `PackageIgnored` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | CommitterNotAllowed(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/debian/vcswatch.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | RecentCommits(i64, i64), [INFO] [stdout] | ------------- ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `PackageIgnored` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 29 | RecentCommits((), ()), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/debian/uploader.rs:877:9 [INFO] [stdout] | [INFO] [stdout] 877 | let mut team_upload = false; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `silver-platter` (lib) due to 9 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `pyo3::Bound<'_, PyAny>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/mod.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 163 | let m = py.import_bound("debian.deb822")?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let changes = m.getattr("Changes")?.call1((contents,))?; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | [INFO] [stdout] 166 | changes.call_method1("get", ("Binary",))?.extract() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `pyo3::Bound<'_, PyAny>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/mod.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 229 | let m = py.import_bound("breezy.plugins.debian.import_dsc")?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let db = m [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | db.call_method1("revid_of_version", (version,))?.extract() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `breezyshim::ControlDir` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/debian/mod.rs:377:9 [INFO] [stdout] | [INFO] [stdout] 376 | let branch = create_branch_convenience(&url, None, &ControlDirFormat::default()).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | branch.controldir().open_workingtree().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `ref_resume_branch` is never read [INFO] [stdout] --> src/publish.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | let mut ref_resume_branch = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:317:36 [INFO] [stdout] | [INFO] [stdout] 233 | mut resume_proposal: Option, [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut ref_resume_branch = None; [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | if let Some(resume_proposal) = resume_proposal.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:624:13 [INFO] [stdout] | [INFO] [stdout] 603 | forge: Option, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | let forge = if let Some(forge) = forge { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | self.local_tree().branch().as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:664:13 [INFO] [stdout] | [INFO] [stdout] 651 | forge: Option, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | let forge = if let Some(forge) = forge { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 664 | self.local_tree().branch().as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:701:13 [INFO] [stdout] | [INFO] [stdout] 683 | let forge = match breezyshim::forge::get_forge(main_branch) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 701 | self.local_tree().branch().as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:731:13 [INFO] [stdout] | [INFO] [stdout] 726 | outf: Box, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 731 | self.base_tree()?.as_ref(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `commit_id` and `message` are never read [INFO] [stdout] --> src/debian/uploader.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 224 | pub struct GitRevision { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 225 | commit_id: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 226 | headers: HashMap, [INFO] [stdout] 227 | message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/debian/vcswatch.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | CommitterNotAllowed(String), [INFO] [stdout] | ------------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `PackageIgnored` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | CommitterNotAllowed(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/debian/vcswatch.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 29 | RecentCommits(i64, i64), [INFO] [stdout] | ------------- ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `PackageIgnored` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 29 | RecentCommits((), ()), [INFO] [stdout] | ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `silver-platter` (lib test) due to 10 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4e11e3c36bb64b0d1a2749d88cb32ef92a1fe16492e4103fea0708de02b50ea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e11e3c36bb64b0d1a2749d88cb32ef92a1fe16492e4103fea0708de02b50ea2", kill_on_drop: false }` [INFO] [stdout] 4e11e3c36bb64b0d1a2749d88cb32ef92a1fe16492e4103fea0708de02b50ea2