[INFO] fetching crate shipyard 0.7.2... [INFO] checking shipyard-0.7.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate shipyard 0.7.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate shipyard 0.7.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shipyard 0.7.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate shipyard 0.7.2 [INFO] tweaked toml for crates.io crate shipyard 0.7.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 104e955cb4129216da346df16bebad120daf4c2e1ffd25a4008b90fd38c34f48 [INFO] running `Command { std: "docker" "start" "-a" "104e955cb4129216da346df16bebad120daf4c2e1ffd25a4008b90fd38c34f48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "104e955cb4129216da346df16bebad120daf4c2e1ffd25a4008b90fd38c34f48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "104e955cb4129216da346df16bebad120daf4c2e1ffd25a4008b90fd38c34f48", kill_on_drop: false }` [INFO] [stdout] 104e955cb4129216da346df16bebad120daf4c2e1ffd25a4008b90fd38c34f48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34371f5d0eb3ebe3e17c98bc2a83cce73fac8fa45c6d514a1a747a2ba7586d7e [INFO] running `Command { std: "docker" "start" "-a" "34371f5d0eb3ebe3e17c98bc2a83cce73fac8fa45c6d514a1a747a2ba7586d7e", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling shipyard_proc v0.4.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking shipyard v0.7.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/mod.rs:129:32 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn rename(&mut self, old: &dyn Label, new: Box) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | if let Some(batches) = self.workloads.remove(old) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ARefMut<'_, &mut Scheduler>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:640:9 [INFO] [stdout] | [INFO] [stdout] 638 | name: impl AsLabel, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 639 | ) -> Result<(), error::SetDefaultWorkload> { [INFO] [stdout] 640 | / self.scheduler [INFO] [stdout] 641 | | .borrow_mut() [INFO] [stdout] 642 | | .map_err(|_| error::SetDefaultWorkload::Borrow)? [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ARef<'_, &Scheduler>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 715 | pub fn contains_workload(&self, name: impl AsLabel) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 716 | let label = name.as_label(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | [INFO] [stdout] 718 | self.scheduler.borrow().unwrap().contains_workload(&*label) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shipyard` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler/mod.rs:129:32 [INFO] [stdout] | [INFO] [stdout] 128 | pub(crate) fn rename(&mut self, old: &dyn Label, new: Box) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | if let Some(batches) = self.workloads.remove(old) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ARefMut<'_, &mut Scheduler>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:640:9 [INFO] [stdout] | [INFO] [stdout] 638 | name: impl AsLabel, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 639 | ) -> Result<(), error::SetDefaultWorkload> { [INFO] [stdout] 640 | / self.scheduler [INFO] [stdout] 641 | | .borrow_mut() [INFO] [stdout] 642 | | .map_err(|_| error::SetDefaultWorkload::Borrow)? [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ARef<'_, &Scheduler>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/world.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 715 | pub fn contains_workload(&self, name: impl AsLabel) -> bool { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 716 | let label = name.as_label(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | [INFO] [stdout] 718 | self.scheduler.borrow().unwrap().contains_workload(&*label) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shipyard` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "34371f5d0eb3ebe3e17c98bc2a83cce73fac8fa45c6d514a1a747a2ba7586d7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34371f5d0eb3ebe3e17c98bc2a83cce73fac8fa45c6d514a1a747a2ba7586d7e", kill_on_drop: false }` [INFO] [stdout] 34371f5d0eb3ebe3e17c98bc2a83cce73fac8fa45c6d514a1a747a2ba7586d7e