[INFO] fetching crate servant-codec 0.1.0... [INFO] checking servant-codec-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate servant-codec 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate servant-codec 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate servant-codec 0.1.0 [INFO] finished tweaking crates.io crate servant-codec 0.1.0 [INFO] tweaked toml for crates.io crate servant-codec 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate servant-codec 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d082e85e3076a2b97fedbc6355fae4472bc7e28d61e3336477c2283358ded2e9 [INFO] running `Command { std: "docker" "start" "-a" "d082e85e3076a2b97fedbc6355fae4472bc7e28d61e3336477c2283358ded2e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d082e85e3076a2b97fedbc6355fae4472bc7e28d61e3336477c2283358ded2e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d082e85e3076a2b97fedbc6355fae4472bc7e28d61e3336477c2283358ded2e9", kill_on_drop: false }` [INFO] [stdout] d082e85e3076a2b97fedbc6355fae4472bc7e28d61e3336477c2283358ded2e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a187ad4512ea3f14753e19eb9d416bc91e56819f0075697a8bc23905fa86c81 [INFO] running `Command { std: "docker" "start" "-a" "7a187ad4512ea3f14753e19eb9d416bc91e56819f0075697a8bc23905fa86c81", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.7 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.0 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Checking bytes v0.5.3 [INFO] [stderr] Compiling test-case v1.0.0-alpha-1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling ring v0.16.9 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling pin-project-internal v0.4.6 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking pin-project v0.4.6 [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.1 [INFO] [stderr] Checking futures v0.3.1 [INFO] [stderr] Checking futures_codec v0.3.4 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking servant-codec v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `rng::rand_gen` [INFO] [stdout] --> src/utility/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use rng::rand_gen; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `type_of::type_of` [INFO] [stdout] --> src/utility/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use type_of::type_of; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rng::rand_gen` [INFO] [stdout] --> src/utility/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use rng::rand_gen; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/length/main.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 19 | let mut framed = Framed::new(cur, BytesCodec {}); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | let msg = Bytes::from("Hello World!"); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let mut framed2 = Framed::new(cur, BytesCodec {}); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | while let Some(msg2) = framed2.try_next().await.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `servant-codec` (example "length") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/length_codec/length.rs:89:32 [INFO] [stdout] | [INFO] [stdout] 88 | let mut framed = Framed::new(cur, BytesCodec {}); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | if let Some(msg) = framed.try_next().await.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/length_codec/length.rs:111:36 [INFO] [stdout] | [INFO] [stdout] 103 | let mut framed = Framed::new(cur, BytesCodec {}); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | let msg = Bytes::from("Hello World!"); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let mut framed2 = Framed::new(cur, BytesCodec {}); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | while let Some(msg2) = framed2.try_next().await.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/record_codec.rs:77:52 [INFO] [stdout] | [INFO] [stdout] 77 | #[derive(Debug, Clone, Default, Eq, PartialEq, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^--------------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Person` [INFO] [stdout] 78 | struct Person { [INFO] [stdout] | ------ `Person` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `serde::Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `serde::Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `serde::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/record_codec.rs:77:70 [INFO] [stdout] | [INFO] [stdout] 77 | #[derive(Debug, Clone, Default, Eq, PartialEq, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^----------------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Person` [INFO] [stdout] 78 | struct Person { [INFO] [stdout] | ------ `Person` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `serde::Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `serde::Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `serde::Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/record_codec.rs:83:52 [INFO] [stdout] | [INFO] [stdout] 83 | #[derive(Debug, Clone, Default, Eq, PartialEq, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^--------------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Person2` [INFO] [stdout] 84 | struct Person2 { [INFO] [stdout] | ------- `Person2` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `serde::Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `serde::Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `serde::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/record_codec.rs:83:70 [INFO] [stdout] | [INFO] [stdout] 83 | #[derive(Debug, Clone, Default, Eq, PartialEq, serde::Serialize, serde::Deserialize)] [INFO] [stdout] | ^----------------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Person2` [INFO] [stdout] 84 | struct Person2 { [INFO] [stdout] | ------- `Person2` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `serde::Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `serde::Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `serde::Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `servant-codec` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7a187ad4512ea3f14753e19eb9d416bc91e56819f0075697a8bc23905fa86c81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a187ad4512ea3f14753e19eb9d416bc91e56819f0075697a8bc23905fa86c81", kill_on_drop: false }` [INFO] [stdout] 7a187ad4512ea3f14753e19eb9d416bc91e56819f0075697a8bc23905fa86c81