[INFO] fetching crate serde_derive 1.0.210... [INFO] checking serde_derive-1.0.210 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate serde_derive 1.0.210 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate serde_derive 1.0.210 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_derive 1.0.210 [INFO] finished tweaking crates.io crate serde_derive 1.0.210 [INFO] tweaked toml for crates.io crate serde_derive 1.0.210 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a119be8af1e02f25c9695bf63ce908914360973cb779c1b76330864df653719 [INFO] running `Command { std: "docker" "start" "-a" "1a119be8af1e02f25c9695bf63ce908914360973cb779c1b76330864df653719", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a119be8af1e02f25c9695bf63ce908914360973cb779c1b76330864df653719", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a119be8af1e02f25c9695bf63ce908914360973cb779c1b76330864df653719", kill_on_drop: false }` [INFO] [stdout] 1a119be8af1e02f25c9695bf63ce908914360973cb779c1b76330864df653719 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54aa32dd08f809c0339e2217c84385a817929459e918c095b9006ee5e920dac8 [INFO] running `Command { std: "docker" "start" "-a" "54aa32dd08f809c0339e2217c84385a817929459e918c095b9006ee5e920dac8", kill_on_drop: false }` [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.79 [INFO] [stderr] Checking serde_derive v1.0.210 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(Option<(proc_macro2::TokenStream, ())>, Option<(proc_macro2::TokenStream, std::string::String)>, Option<(proc_macro2::TokenStream, std::string::String)>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internals/attr.rs:683:11 [INFO] [stdout] | [INFO] [stdout] 679 | untagged: BoolAttr, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 683 | match ( [INFO] [stdout] | ___________^ [INFO] [stdout] 684 | | untagged.0.get_with_tokens(), [INFO] [stdout] 685 | | internal_tag.get_with_tokens(), [INFO] [stdout] 686 | | content.get_with_tokens(), [INFO] [stdout] 687 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&syn::Data, Option<(proc_macro2::TokenStream, ())>, Option<(proc_macro2::TokenStream, ())>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internals/attr.rs:743:11 [INFO] [stdout] | [INFO] [stdout] 740 | field_identifier: BoolAttr, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 741 | variant_identifier: BoolAttr, [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 742 | ) -> Identifier { [INFO] [stdout] 743 | match ( [INFO] [stdout] | ___________^ [INFO] [stdout] 744 | | &item.data, [INFO] [stdout] 745 | | field_identifier.0.get_with_tokens(), [INFO] [stdout] 746 | | variant_identifier.0.get_with_tokens(), [INFO] [stdout] 747 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Generics` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:989:17 [INFO] [stdout] | [INFO] [stdout] 970 | let serialize_fields = serialize_struct_visitor(fields, params, true, &struct_trait); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 977 | let let_mut = mut_if(serialized_fields.peek().is_some()); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 989 | let wrapper_generics = bound::with_lifetime_bound(¶ms.generics, "'__a"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 992 | / quote_block! { [INFO] [stdout] 993 | | #[doc(hidden)] [INFO] [stdout] 994 | | struct __EnumFlatten #wrapper_generics #where_clause { [INFO] [stdout] 995 | | data: (#(&'__a #fields_ty,)*), [INFO] [stdout] ... | [INFO] [stdout] 1021 | | }) [INFO] [stdout] 1022 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1025 | / quote_block! { [INFO] [stdout] 1026 | let #let_mut __serde_state = _serde::Serializer::serialize_map( [INFO] [stdout] 1027 | __serializer, [INFO] [stdout] 1028 | _serde::__private::None)?; [INFO] [stdout] ... [INFO] [stdout] 1035 | _serde::ser::SerializeMap::end(__serde_state) [INFO] [stdout] 1036 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1039 | / quote_block! { [INFO] [stdout] 1040 | let #let_mut __serde_state = _serde::Serializer::serialize_map( [INFO] [stdout] 1041 | __serializer, [INFO] [stdout] 1042 | _serde::__private::None)?; [INFO] [stdout] 1043 | #(#serialize_fields)* [INFO] [stdout] 1044 | _serde::ser::SerializeMap::end(__serde_state) [INFO] [stdout] 1045 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_derive` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(Option<(proc_macro2::TokenStream, ())>, Option<(proc_macro2::TokenStream, std::string::String)>, Option<(proc_macro2::TokenStream, std::string::String)>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internals/attr.rs:683:11 [INFO] [stdout] | [INFO] [stdout] 679 | untagged: BoolAttr, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 683 | match ( [INFO] [stdout] | ___________^ [INFO] [stdout] 684 | | untagged.0.get_with_tokens(), [INFO] [stdout] 685 | | internal_tag.get_with_tokens(), [INFO] [stdout] 686 | | content.get_with_tokens(), [INFO] [stdout] 687 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&syn::Data, Option<(proc_macro2::TokenStream, ())>, Option<(proc_macro2::TokenStream, ())>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internals/attr.rs:743:11 [INFO] [stdout] | [INFO] [stdout] 740 | field_identifier: BoolAttr, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 741 | variant_identifier: BoolAttr, [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 742 | ) -> Identifier { [INFO] [stdout] 743 | match ( [INFO] [stdout] | ___________^ [INFO] [stdout] 744 | | &item.data, [INFO] [stdout] 745 | | field_identifier.0.get_with_tokens(), [INFO] [stdout] 746 | | variant_identifier.0.get_with_tokens(), [INFO] [stdout] 747 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Generics` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:989:17 [INFO] [stdout] | [INFO] [stdout] 970 | let serialize_fields = serialize_struct_visitor(fields, params, true, &struct_trait); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 977 | let let_mut = mut_if(serialized_fields.peek().is_some()); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 989 | let wrapper_generics = bound::with_lifetime_bound(¶ms.generics, "'__a"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 992 | / quote_block! { [INFO] [stdout] 993 | | #[doc(hidden)] [INFO] [stdout] 994 | | struct __EnumFlatten #wrapper_generics #where_clause { [INFO] [stdout] 995 | | data: (#(&'__a #fields_ty,)*), [INFO] [stdout] ... | [INFO] [stdout] 1021 | | }) [INFO] [stdout] 1022 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1025 | / quote_block! { [INFO] [stdout] 1026 | let #let_mut __serde_state = _serde::Serializer::serialize_map( [INFO] [stdout] 1027 | __serializer, [INFO] [stdout] 1028 | _serde::__private::None)?; [INFO] [stdout] ... [INFO] [stdout] 1035 | _serde::ser::SerializeMap::end(__serde_state) [INFO] [stdout] 1036 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1039 | / quote_block! { [INFO] [stdout] 1040 | let #let_mut __serde_state = _serde::Serializer::serialize_map( [INFO] [stdout] 1041 | __serializer, [INFO] [stdout] 1042 | _serde::__private::None)?; [INFO] [stdout] 1043 | #(#serialize_fields)* [INFO] [stdout] 1044 | _serde::ser::SerializeMap::end(__serde_state) [INFO] [stdout] 1045 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_derive` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "54aa32dd08f809c0339e2217c84385a817929459e918c095b9006ee5e920dac8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54aa32dd08f809c0339e2217c84385a817929459e918c095b9006ee5e920dac8", kill_on_drop: false }` [INFO] [stdout] 54aa32dd08f809c0339e2217c84385a817929459e918c095b9006ee5e920dac8