[INFO] fetching crate serde_columnar_derive 0.3.5... [INFO] checking serde_columnar_derive-0.3.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate serde_columnar_derive 0.3.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate serde_columnar_derive 0.3.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_columnar_derive 0.3.5 [INFO] finished tweaking crates.io crate serde_columnar_derive 0.3.5 [INFO] tweaked toml for crates.io crate serde_columnar_derive 0.3.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4edddcc440015a86d3e9a9391dd16cb9614b2f5c040dbabb1445cb9da2705e2c [INFO] running `Command { std: "docker" "start" "-a" "4edddcc440015a86d3e9a9391dd16cb9614b2f5c040dbabb1445cb9da2705e2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4edddcc440015a86d3e9a9391dd16cb9614b2f5c040dbabb1445cb9da2705e2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4edddcc440015a86d3e9a9391dd16cb9614b2f5c040dbabb1445cb9da2705e2c", kill_on_drop: false }` [INFO] [stdout] 4edddcc440015a86d3e9a9391dd16cb9614b2f5c040dbabb1445cb9da2705e2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b2df6fe6a633085d00cea3b01d3b8223122a95e55acb3aaa17eafe9d8fbdd83 [INFO] running `Command { std: "docker" "start" "-a" "4b2df6fe6a633085d00cea3b01d3b8223122a95e55acb3aaa17eafe9d8fbdd83", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking darling_core v0.20.10 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking serde_columnar_derive v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `exhaustive` [INFO] [stdout] --> src/args.rs:452:30 [INFO] [stdout] | [INFO] [stdout] 452 | #[cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(exhaustive)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(exhaustive)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `exhaustive` [INFO] [stdout] --> src/args.rs:452:30 [INFO] [stdout] | [INFO] [stdout] 452 | #[cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(exhaustive)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(exhaustive)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 118 | fn get_strategy_column(&self, ty: TokenStream) -> syn::Result { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let self_ty = &self.ty(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:128:36 [INFO] [stdout] | [INFO] [stdout] 118 | fn get_strategy_column(&self, ty: TokenStream) -> syn::Result { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let self_ty = &self.ty(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:162:25 [INFO] [stdout] | [INFO] [stdout] 143 | lifetime: GenericArgument, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | map_name_fn: Option, [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let args = vec![lifetime]; [INFO] [stdout] | ^^^^ [INFO] [stdout] 163 | last_segment.arguments = [INFO] [stdout] 164 | PathArguments::AngleBracketed(parse_quote!(<#(#args),*>)); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:11 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn columnar(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | match expand_columnar(attr_args, st) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `vis` is never read [INFO] [stdout] --> src/args.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct FieldArgs { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | pub vis: syn::Visibility, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldArgs` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `skip` is never read [INFO] [stdout] --> src/args.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct VariantArgs { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 66 | pub skip: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VariantArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ident`, `attrs`, `index`, and `optional` are never used [INFO] [stdout] --> src/args.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 100 | pub trait Args { [INFO] [stdout] | ---- methods in this trait [INFO] [stdout] 101 | fn ident(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 102 | fn ty(&self) -> Option; [INFO] [stdout] 103 | fn attrs(&self) -> &[syn::Attribute]; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 104 | fn index(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 105 | fn optional(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `original` and `borrowed` are never read [INFO] [stdout] --> src/attr.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct Context<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | pub original: &'a syn::DeriveInput, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 60 | pub derive_args: DeriveArgs, [INFO] [stdout] 61 | pub borrowed: BorrowedLifetimes, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ColumnarSerAttributes` is never used [INFO] [stdout] --> src/attr.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | pub trait ColumnarSerAttributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:162:25 [INFO] [stdout] | [INFO] [stdout] 143 | lifetime: GenericArgument, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | map_name_fn: Option, [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let args = vec![lifetime]; [INFO] [stdout] | ^^^^ [INFO] [stdout] 163 | last_segment.arguments = [INFO] [stdout] 164 | PathArguments::AngleBracketed(parse_quote!(<#(#args),*>)); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:11 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn columnar(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | match expand_columnar(attr_args, st) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `vis` is never read [INFO] [stdout] --> src/args.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct FieldArgs { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | pub vis: syn::Visibility, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldArgs` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `skip` is never read [INFO] [stdout] --> src/args.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct VariantArgs { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 66 | pub skip: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VariantArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ident`, `attrs`, `index`, and `optional` are never used [INFO] [stdout] --> src/args.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 100 | pub trait Args { [INFO] [stdout] | ---- methods in this trait [INFO] [stdout] 101 | fn ident(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 102 | fn ty(&self) -> Option; [INFO] [stdout] 103 | fn attrs(&self) -> &[syn::Attribute]; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 104 | fn index(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 105 | fn optional(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `original` and `borrowed` are never read [INFO] [stdout] --> src/attr.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct Context<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | pub original: &'a syn::DeriveInput, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 60 | pub derive_args: DeriveArgs, [INFO] [stdout] 61 | pub borrowed: BorrowedLifetimes, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ColumnarSerAttributes` is never used [INFO] [stdout] --> src/attr.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | pub trait ColumnarSerAttributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_columnar_derive` (lib) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `serde_columnar_derive` (lib test) due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4b2df6fe6a633085d00cea3b01d3b8223122a95e55acb3aaa17eafe9d8fbdd83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b2df6fe6a633085d00cea3b01d3b8223122a95e55acb3aaa17eafe9d8fbdd83", kill_on_drop: false }` [INFO] [stdout] 4b2df6fe6a633085d00cea3b01d3b8223122a95e55acb3aaa17eafe9d8fbdd83