[INFO] fetching crate scf-core 1.2.1... [INFO] checking scf-core-1.2.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate scf-core 1.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate scf-core 1.2.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scf-core 1.2.1 [INFO] finished tweaking crates.io crate scf-core 1.2.1 [INFO] tweaked toml for crates.io crate scf-core 1.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding arc-swap v0.3.11 (available: v1.7.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding humantime v1.3.0 (available: v2.1.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding log4rs v0.8.3 (available: v1.3.0) [INFO] [stderr] Adding ordered-float v1.1.1 (available: v4.3.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding serde-value v0.5.3 (available: v0.7.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] [stderr] Adding thread-id v3.3.0 (available: v4.2.2) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea91ff3651e7b7cd62ad3e4c78b829d23d54e2b1042999fcd73b596ae03c29ec [INFO] running `Command { std: "docker" "start" "-a" "ea91ff3651e7b7cd62ad3e4c78b829d23d54e2b1042999fcd73b596ae03c29ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea91ff3651e7b7cd62ad3e4c78b829d23d54e2b1042999fcd73b596ae03c29ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea91ff3651e7b7cd62ad3e4c78b829d23d54e2b1042999fcd73b596ae03c29ec", kill_on_drop: false }` [INFO] [stdout] ea91ff3651e7b7cd62ad3e4c78b829d23d54e2b1042999fcd73b596ae03c29ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9cb894659f36f9738aa28c8ac71926da5fa7c08e743d3170f25d7d4d4115fafa [INFO] running `Command { std: "docker" "start" "-a" "9cb894659f36f9738aa28c8ac71926da5fa7c08e743d3170f25d7d4d4115fafa", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking antidote v1.0.0 [INFO] [stderr] Checking lang_extension v1.0.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking arc-swap v0.3.11 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking scf-core v1.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/default/mod.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 99 | let lock = self.property_provider.read().unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | match lock(config.get_raw_key().as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/manager/default/mod.rs:177:53 [INFO] [stdout] | [INFO] [stdout] 177 | let raw_property = property.as_ref().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn property::RawProperty` does not implement `Clone`, so calling `clone` on `&dyn property::RawProperty` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scf-core` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9cb894659f36f9738aa28c8ac71926da5fa7c08e743d3170f25d7d4d4115fafa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cb894659f36f9738aa28c8ac71926da5fa7c08e743d3170f25d7d4d4115fafa", kill_on_drop: false }` [INFO] [stdout] 9cb894659f36f9738aa28c8ac71926da5fa7c08e743d3170f25d7d4d4115fafa