[INFO] fetching crate satex-core 0.2.2... [INFO] checking satex-core-0.2.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate satex-core 0.2.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate satex-core 0.2.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate satex-core 0.2.2 [INFO] finished tweaking crates.io crate satex-core 0.2.2 [INFO] tweaked toml for crates.io crate satex-core 0.2.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding sync_wrapper v0.1.2 (available: v1.0.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c7b6b048b583135984dfbceab24a512b44700ac98c0a6c633083c8a2a487c67 [INFO] running `Command { std: "docker" "start" "-a" "0c7b6b048b583135984dfbceab24a512b44700ac98c0a6c633083c8a2a487c67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c7b6b048b583135984dfbceab24a512b44700ac98c0a6c633083c8a2a487c67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c7b6b048b583135984dfbceab24a512b44700ac98c0a6c633083c8a2a487c67", kill_on_drop: false }` [INFO] [stdout] 0c7b6b048b583135984dfbceab24a512b44700ac98c0a6c633083c8a2a487c67 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37aa54cd071a9abaa2079593673871a8bbd62e56aef944a61e6f4c5e91d934b8 [INFO] running `Command { std: "docker" "start" "-a" "37aa54cd071a9abaa2079593673871a8bbd62e56aef944a61e6f4c5e91d934b8", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.159 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling concat-idents v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking http-serde v2.1.1 [INFO] [stderr] Checking serde-this-or-that v0.4.2 [INFO] [stderr] Checking satex-core v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | match ready!(Pin::new(&mut self.inner).poll_frame(cx)?) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll::Ok, ::Error>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:199:22 [INFO] [stdout] | [INFO] [stdout] 199 | match ready!(stream.try_poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] 123 | { [INFO] [stdout] 124 | impl<'a> From for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] ... [INFO] [stdout] 129 | impl<'a> From<&'a str> for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | match ready!(Pin::new(&mut self.inner).poll_frame(cx)?) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll::Ok, ::Error>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:199:22 [INFO] [stdout] | [INFO] [stdout] 199 | match ready!(stream.try_poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `satex-core` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] 123 | { [INFO] [stdout] 124 | impl<'a> From for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] ... [INFO] [stdout] 129 | impl<'a> From<&'a str> for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `satex-core` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "37aa54cd071a9abaa2079593673871a8bbd62e56aef944a61e6f4c5e91d934b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37aa54cd071a9abaa2079593673871a8bbd62e56aef944a61e6f4c5e91d934b8", kill_on_drop: false }` [INFO] [stdout] 37aa54cd071a9abaa2079593673871a8bbd62e56aef944a61e6f4c5e91d934b8