[INFO] fetching crate sampr 0.1.0... [INFO] checking sampr-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate sampr 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sampr 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sampr 0.1.0 [INFO] finished tweaking crates.io crate sampr 0.1.0 [INFO] tweaked toml for crates.io crate sampr 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate sampr 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1162d75912311c7be8a06d5767db046158e1733516b90a6198a872b3ce1c355d [INFO] running `Command { std: "docker" "start" "-a" "1162d75912311c7be8a06d5767db046158e1733516b90a6198a872b3ce1c355d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1162d75912311c7be8a06d5767db046158e1733516b90a6198a872b3ce1c355d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1162d75912311c7be8a06d5767db046158e1733516b90a6198a872b3ce1c355d", kill_on_drop: false }` [INFO] [stdout] 1162d75912311c7be8a06d5767db046158e1733516b90a6198a872b3ce1c355d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b17e9414b35482c0e7a90e8d342dd5de4e545bf5242e86e7147519c7402d18bd [INFO] running `Command { std: "docker" "start" "-a" "b17e9414b35482c0e7a90e8d342dd5de4e545bf5242e86e7147519c7402d18bd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling async-trait v0.1.68 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking sampr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `futures::stream::SelectAll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 230 | async fn run(mut self) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let mut async_items = SelectAll::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 243 | let mut envelope = tokio::select! { [INFO] [stdout] | ________________________________- [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] 244 | | res = async_items.next(), if !async_items.is_empty() => { [INFO] [stdout] 245 | | if let Some(mut task_output) = res { [INFO] [stdout] 246 | | task_output.call(&mut self.actor, &mut self.ctx).await; [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | / tokio::select! { [INFO] [stdout] 280 | | res = async_items.next(), if !async_items.is_empty() => { [INFO] [stdout] 281 | | if let Some(mut task_output) = res { [INFO] [stdout] 282 | | task_output.call(&mut self.actor, &mut self.ctx).await; [INFO] [stdout] ... | [INFO] [stdout] 289 | | } [INFO] [stdout] 290 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sampr` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `futures::stream::SelectAll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 230 | async fn run(mut self) { [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let mut async_items = SelectAll::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 243 | let mut envelope = tokio::select! { [INFO] [stdout] | ________________________________- [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] | |________________________________| [INFO] [stdout] 244 | | res = async_items.next(), if !async_items.is_empty() => { [INFO] [stdout] 245 | | if let Some(mut task_output) = res { [INFO] [stdout] 246 | | task_output.call(&mut self.actor, &mut self.ctx).await; [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | / tokio::select! { [INFO] [stdout] 280 | | res = async_items.next(), if !async_items.is_empty() => { [INFO] [stdout] 281 | | if let Some(mut task_output) = res { [INFO] [stdout] 282 | | task_output.call(&mut self.actor, &mut self.ctx).await; [INFO] [stdout] ... | [INFO] [stdout] 289 | | } [INFO] [stdout] 290 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sampr` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "b17e9414b35482c0e7a90e8d342dd5de4e545bf5242e86e7147519c7402d18bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b17e9414b35482c0e7a90e8d342dd5de4e545bf5242e86e7147519c7402d18bd", kill_on_drop: false }` [INFO] [stdout] b17e9414b35482c0e7a90e8d342dd5de4e545bf5242e86e7147519c7402d18bd