[INFO] fetching crate salvo-http3 0.3.0... [INFO] checking salvo-http3-0.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate salvo-http3 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate salvo-http3 0.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate salvo-http3 0.3.0 [INFO] finished tweaking crates.io crate salvo-http3 0.3.0 [INFO] tweaked toml for crates.io crate salvo-http3 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 123 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0187e66db2ea5de516d0ca2ec9d3886e9fd3888f53feb3685a4d5e0a1f35e0d [INFO] running `Command { std: "docker" "start" "-a" "e0187e66db2ea5de516d0ca2ec9d3886e9fd3888f53feb3685a4d5e0a1f35e0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0187e66db2ea5de516d0ca2ec9d3886e9fd3888f53feb3685a4d5e0a1f35e0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0187e66db2ea5de516d0ca2ec9d3886e9fd3888f53feb3685a4d5e0a1f35e0d", kill_on_drop: false }` [INFO] [stdout] e0187e66db2ea5de516d0ca2ec9d3886e9fd3888f53feb3685a4d5e0a1f35e0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 79000e41472365a378e2b63b925f18b1d3ba1d14d49d8dbcf6d4a72357cab100 [INFO] running `Command { std: "docker" "start" "-a" "79000e41472365a378e2b63b925f18b1d3ba1d14d49d8dbcf6d4a72357cab100", kill_on_drop: false }` [INFO] [stderr] Checking rustls-pki-types v1.9.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking quinn-udp v0.5.5 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking rcgen v0.13.1 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking quinn-proto v0.11.8 [INFO] [stderr] Checking quinn v0.11.5 [INFO] [stderr] Checking salvo-http3 v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, SharedState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 69 | fn maybe_conn_err>(&self, err: E) -> Error { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | if let Some(ref e) = self.shared_state().0.read().unwrap().error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Pair` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/request.rs:1426:9 [INFO] [stdout] | [INFO] [stdout] 1420 | async fn request_sequence_check(request: F, check: FC) [INFO] [stdout] | ------- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1426 | let mut pair = Pair::default(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1469 | / tokio::select! { res = server_fut => check(res) [INFO] [stdout] 1470 | | , _ = client_fut => panic!("client resolved first") }; [INFO] [stdout] | | - [INFO] [stdout] | |_________________________________________________________| [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Buf>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webtransport/server.rs:414:15 [INFO] [stdout] | [INFO] [stdout] 413 | let mut conn = self.conn.lock().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | match ready!(conn.inner.conn.poll_accept_datagram(cx))? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http3_quinn.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | match ready!(self.datagrams.poll_next_unpin(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salvo-http3` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, SharedState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 69 | fn maybe_conn_err>(&self, err: E) -> Error { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | if let Some(ref e) = self.shared_state().0.read().unwrap().error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Buf>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/webtransport/server.rs:414:15 [INFO] [stdout] | [INFO] [stdout] 413 | let mut conn = self.conn.lock().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | match ready!(conn.inner.conn.poll_accept_datagram(cx))? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::task::Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http3_quinn.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | match ready!(self.datagrams.poll_next_unpin(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/connection.rs:312:19 [INFO] [stdout] | [INFO] [stdout] 309 | let connection = server.endpoint.accept().await.unwrap().await.unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | let (mut send, _recv) = connection.open_bi().await.unwrap(); [INFO] [stdout] | -------- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | for _ in 0..100 { [INFO] [stdout] 312 | match send.write(b"I'm not really a server").await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `error::Kind` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/request.rs:390:19 [INFO] [stdout] | [INFO] [stdout] 387 | let err = future::poll_fn(|cx| driver.poll_close(cx)) [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 390 | match err.kind() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `error::Kind` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/request.rs:452:19 [INFO] [stdout] | [INFO] [stdout] 449 | let err = future::poll_fn(|cx| driver.poll_close(cx)) [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | match err.kind() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/client/builder.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn send_settings(&mut self, value: bool) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | #![deny(missing_docs, clippy::self_named_module_files)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/server/builder.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn send_settings(&mut self, value: bool) -> &mut Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salvo-http3` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "79000e41472365a378e2b63b925f18b1d3ba1d14d49d8dbcf6d4a72357cab100", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79000e41472365a378e2b63b925f18b1d3ba1d14d49d8dbcf6d4a72357cab100", kill_on_drop: false }` [INFO] [stdout] 79000e41472365a378e2b63b925f18b1d3ba1d14d49d8dbcf6d4a72357cab100