[INFO] fetching crate salsa 0.17.0-pre.2... [INFO] checking salsa-0.17.0-pre.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate salsa 0.17.0-pre.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate salsa 0.17.0-pre.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate salsa 0.17.0-pre.2 [INFO] finished tweaking crates.io crate salsa 0.17.0-pre.2 [INFO] tweaked toml for crates.io crate salsa 0.17.0-pre.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate salsa 0.17.0-pre.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d80cc2cc4cb881a19f9f07570825fc813d408ca08559f8710c48605328211ba8 [INFO] running `Command { std: "docker" "start" "-a" "d80cc2cc4cb881a19f9f07570825fc813d408ca08559f8710c48605328211ba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d80cc2cc4cb881a19f9f07570825fc813d408ca08559f8710c48605328211ba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d80cc2cc4cb881a19f9f07570825fc813d408ca08559f8710c48605328211ba8", kill_on_drop: false }` [INFO] [stdout] d80cc2cc4cb881a19f9f07570825fc813d408ca08559f8710c48605328211ba8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5690b3c0716e3f84e5befb6ea64fcb213e1f79cc67c6b3256ceb5620fdfca0e [INFO] running `Command { std: "docker" "start" "-a" "f5690b3c0716e3f84e5befb6ea64fcb213e1f79cc67c6b3256ceb5620fdfca0e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling syn v1.0.32 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling indexmap v1.4.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking parking_lot_core v0.8.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling salsa-macros v0.17.0-pre.2 [INFO] [stderr] Checking salsa v0.17.0-pre.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `State` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blocking_future.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn wait(self) -> Option { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut guard = self.slot.lock.lock(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | match mem::replace(&mut *guard, State::Dead) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `State` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blocking_future.rs:32:15 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn wait(self) -> Option { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut guard = self.slot.lock.lock(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | match mem::replace(&mut *guard, State::Dead) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `lock_api::Mutex::Value, DatabaseKeyIndex>>; 2]>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:779:42 [INFO] [stdout] | [INFO] [stdout] 765 | let mut write = self.slot.state.write(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 766 | [INFO] [stdout] 767 | let old_value = match self.memo.take() { [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | QueryState::InProgress { id, waiting } => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `lock_api::Mutex::Value, DatabaseKeyIndex>>; 2]>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derived/slot.rs:779:42 [INFO] [stdout] | [INFO] [stdout] 765 | let mut write = self.slot.state.write(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 766 | [INFO] [stdout] 767 | let old_value = match self.memo.take() { [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | QueryState::InProgress { id, waiting } => { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `indexmap::map::Entry<'_, ::Key, Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:220:23 [INFO] [stdout] | [INFO] [stdout] 208 | let mut slots = self.slots.write(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | match slots.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `indexmap::map::Entry<'_, ::Key, Arc>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:220:23 [INFO] [stdout] | [INFO] [stdout] 208 | let mut slots = self.slots.write(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | match slots.entry(key.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salsa` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `salsa` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "f5690b3c0716e3f84e5befb6ea64fcb213e1f79cc67c6b3256ceb5620fdfca0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5690b3c0716e3f84e5befb6ea64fcb213e1f79cc67c6b3256ceb5620fdfca0e", kill_on_drop: false }` [INFO] [stdout] f5690b3c0716e3f84e5befb6ea64fcb213e1f79cc67c6b3256ceb5620fdfca0e