[INFO] fetching crate rust_hdl_private_macros 0.44.0... [INFO] checking rust_hdl_private_macros-0.44.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rust_hdl_private_macros 0.44.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rust_hdl_private_macros 0.44.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust_hdl_private_macros 0.44.0 [INFO] finished tweaking crates.io crate rust_hdl_private_macros 0.44.0 [INFO] tweaked toml for crates.io crate rust_hdl_private_macros 0.44.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf9c491ed7dea989431928537d5228b784d5fd2f53cfb45d592acecf77df96d7 [INFO] running `Command { std: "docker" "start" "-a" "bf9c491ed7dea989431928537d5228b784d5fd2f53cfb45d592acecf77df96d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf9c491ed7dea989431928537d5228b784d5fd2f53cfb45d592acecf77df96d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf9c491ed7dea989431928537d5228b784d5fd2f53cfb45d592acecf77df96d7", kill_on_drop: false }` [INFO] [stdout] bf9c491ed7dea989431928537d5228b784d5fd2f53cfb45d592acecf77df96d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e7d51a7fb8c4e499ae5e60ec535c6f3708baf117bb8523e3653d94bbbc76c7cf [INFO] running `Command { std: "docker" "start" "-a" "e7d51a7fb8c4e499ae5e60ec535c6f3708baf117bb8523e3653d94bbbc76c7cf", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking rust_hdl_private_macros v0.44.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `DFFSetupArgs` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect_gen.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | let args: DFFSetupArgs = m.mac.parse_body()?; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(quote! { [INFO] [stdout] | ________________- [INFO] [stdout] 145 | | #( [INFO] [stdout] 146 | | logic::logic_connect_fn(&mut #me.#dff.clock); [INFO] [stdout] 147 | | logic::logic_connect_fn(&mut #me.#dff.d); [INFO] [stdout] 148 | | )* [INFO] [stdout] 149 | | }) [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Ok(quote! { [INFO] [stdout] | ________________- [INFO] [stdout] 155 | | #( [INFO] [stdout] 156 | | logic::logic_connect_fn(&mut #me.#dff.clock); [INFO] [stdout] 157 | | )* [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DFFSetupArgs` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hdl_gen.rs:606:17 [INFO] [stdout] | [INFO] [stdout] 606 | ... let args: DFFSetupArgs = x.mac.parse_body()?; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 624 | ... Ok(quote!( [INFO] [stdout] | __________- [INFO] [stdout] | |__________| [INFO] [stdout] 625 | | ... { [INFO] [stdout] 626 | | ... let mut ret = vec![]; [INFO] [stdout] 627 | | ... #(ret.push(ast::VerilogStatement::Assignment(ast::VerilogExpression::Signal(#dffs_clk.to_string()), ast::VerilogExpression:... [INFO] [stdout] ... | [INFO] [stdout] 630 | | ... } [INFO] [stdout] 631 | | ... )) [INFO] [stdout] | | - [INFO] [stdout] | |_______| [INFO] [stdout] | |_______these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | ... Ok(quote!( [INFO] [stdout] | __________- [INFO] [stdout] | |__________| [INFO] [stdout] 643 | | ... { [INFO] [stdout] 644 | | ... let mut ret = vec![]; [INFO] [stdout] 645 | | ... #(ret.push(ast::VerilogStatement::Assignment(ast::VerilogExpression::Signal(#dffs_clk.to_string()), ast::VerilogExpression:... [INFO] [stdout] 646 | | ... ast::VerilogStatement::Macro(ret) [INFO] [stdout] 647 | | ... } [INFO] [stdout] 648 | | ... )) [INFO] [stdout] | | - [INFO] [stdout] | |_______| [INFO] [stdout] | |_______these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DFFSetupArgs` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect_gen.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | let args: DFFSetupArgs = m.mac.parse_body()?; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(quote! { [INFO] [stdout] | ________________- [INFO] [stdout] 145 | | #( [INFO] [stdout] 146 | | logic::logic_connect_fn(&mut #me.#dff.clock); [INFO] [stdout] 147 | | logic::logic_connect_fn(&mut #me.#dff.d); [INFO] [stdout] 148 | | )* [INFO] [stdout] 149 | | }) [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Ok(quote! { [INFO] [stdout] | ________________- [INFO] [stdout] 155 | | #( [INFO] [stdout] 156 | | logic::logic_connect_fn(&mut #me.#dff.clock); [INFO] [stdout] 157 | | )* [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 24 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | match get_impl_for_logic_block(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 34 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | match get_impl_for_logic_interface(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:11 [INFO] [stdout] | [INFO] [stdout] 44 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | match get_logic_state_impls(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 54 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | match get_impl_for_logic_struct(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn hdl_gen(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let orig = TS::from(item.clone()); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let parse = parse_macro_input!(item as syn::ItemFn); [INFO] [stdout] 66 | let connects = match connect_gen(&parse) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match hdl_gen_process(parse) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_hdl_private_macros` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `DFFSetupArgs` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hdl_gen.rs:606:17 [INFO] [stdout] | [INFO] [stdout] 606 | ... let args: DFFSetupArgs = x.mac.parse_body()?; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 624 | ... Ok(quote!( [INFO] [stdout] | __________- [INFO] [stdout] | |__________| [INFO] [stdout] 625 | | ... { [INFO] [stdout] 626 | | ... let mut ret = vec![]; [INFO] [stdout] 627 | | ... #(ret.push(ast::VerilogStatement::Assignment(ast::VerilogExpression::Signal(#dffs_clk.to_string()), ast::VerilogExpression:... [INFO] [stdout] ... | [INFO] [stdout] 630 | | ... } [INFO] [stdout] 631 | | ... )) [INFO] [stdout] | | - [INFO] [stdout] | |_______| [INFO] [stdout] | |_______these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | ... Ok(quote!( [INFO] [stdout] | __________- [INFO] [stdout] | |__________| [INFO] [stdout] 643 | | ... { [INFO] [stdout] 644 | | ... let mut ret = vec![]; [INFO] [stdout] 645 | | ... #(ret.push(ast::VerilogStatement::Assignment(ast::VerilogExpression::Signal(#dffs_clk.to_string()), ast::VerilogExpression:... [INFO] [stdout] 646 | | ... ast::VerilogStatement::Macro(ret) [INFO] [stdout] 647 | | ... } [INFO] [stdout] 648 | | ... )) [INFO] [stdout] | | - [INFO] [stdout] | |_______| [INFO] [stdout] | |_______these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 24 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | match get_impl_for_logic_block(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 34 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | [INFO] [stdout] 36 | match get_impl_for_logic_interface(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:46:11 [INFO] [stdout] | [INFO] [stdout] 44 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | match get_logic_state_impls(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:11 [INFO] [stdout] | [INFO] [stdout] 54 | let input = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | match get_impl_for_logic_struct(&input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn hdl_gen(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let orig = TS::from(item.clone()); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let parse = parse_macro_input!(item as syn::ItemFn); [INFO] [stdout] 66 | let connects = match connect_gen(&parse) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | match hdl_gen_process(parse) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_hdl_private_macros` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "e7d51a7fb8c4e499ae5e60ec535c6f3708baf117bb8523e3653d94bbbc76c7cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7d51a7fb8c4e499ae5e60ec535c6f3708baf117bb8523e3653d94bbbc76c7cf", kill_on_drop: false }` [INFO] [stdout] e7d51a7fb8c4e499ae5e60ec535c6f3708baf117bb8523e3653d94bbbc76c7cf