[INFO] fetching crate russh-keys 0.46.0-beta.3... [INFO] checking russh-keys-0.46.0-beta.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate russh-keys 0.46.0-beta.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate russh-keys 0.46.0-beta.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate russh-keys 0.46.0-beta.3 [INFO] finished tweaking crates.io crate russh-keys 0.46.0-beta.3 [INFO] tweaked toml for crates.io crate russh-keys 0.46.0-beta.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 183 packages to latest compatible versions [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding delegate v0.12.0 (available: v0.13.0) [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding password-hash v0.4.2 (available: v0.5.0) [INFO] [stderr] Adding pbkdf2 v0.11.0 (available: v0.12.2) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (available: v0.8.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-strings v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97242b22adb170b9a8ccdbd1762cf7d86c422324e126b38492dfc7dea767e806 [INFO] running `Command { std: "docker" "start" "-a" "97242b22adb170b9a8ccdbd1762cf7d86c422324e126b38492dfc7dea767e806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97242b22adb170b9a8ccdbd1762cf7d86c422324e126b38492dfc7dea767e806", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97242b22adb170b9a8ccdbd1762cf7d86c422324e126b38492dfc7dea767e806", kill_on_drop: false }` [INFO] [stdout] 97242b22adb170b9a8ccdbd1762cf7d86c422324e126b38492dfc7dea767e806 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8f11b72f2bdd9ec010fbce7fc83f8ee3c7df5979012ef665373d86882f243ef [INFO] running `Command { std: "docker" "start" "-a" "a8f11b72f2bdd9ec010fbce7fc83f8ee3c7df5979012ef665373d86882f243ef", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking russh-cryptovec v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking russh-keys v0.46.0-beta.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `ssh_key::PrivateKey` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format/openssh.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 15 | let pk = PrivateKey::from_bytes(secret)?; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | KeyPair::try_from(&match password { [INFO] [stdout] | ________________________^ [INFO] [stdout] 17 | | Some(password) => pk.decrypt(password)?, [INFO] [stdout] 18 | | None => pk, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `russh-keys` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `ssh_key::PrivateKey` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format/openssh.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 15 | let pk = PrivateKey::from_bytes(secret)?; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | KeyPair::try_from(&match password { [INFO] [stdout] | ________________________^ [INFO] [stdout] 17 | | Some(password) => pk.decrypt(password)?, [INFO] [stdout] 18 | | None => pk, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `key::PublicKey` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1015:17 [INFO] [stdout] | [INFO] [stdout] 976 | let key = decode_secret_key(key, None).unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1015 | let public = key.clone_public_key().unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `russh-keys` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "a8f11b72f2bdd9ec010fbce7fc83f8ee3c7df5979012ef665373d86882f243ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8f11b72f2bdd9ec010fbce7fc83f8ee3c7df5979012ef665373d86882f243ef", kill_on_drop: false }` [INFO] [stdout] a8f11b72f2bdd9ec010fbce7fc83f8ee3c7df5979012ef665373d86882f243ef