[INFO] fetching crate russh 0.46.0-beta.4... [INFO] checking russh-0.46.0-beta.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate russh 0.46.0-beta.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate russh 0.46.0-beta.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate russh 0.46.0-beta.4 [INFO] finished tweaking crates.io crate russh 0.46.0-beta.4 [INFO] tweaked toml for crates.io crate russh 0.46.0-beta.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate russh 0.46.0-beta.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4d86cb99472639edae9658449dd19b6cd630f1541cf561b1a4f4563de4b946d [INFO] running `Command { std: "docker" "start" "-a" "d4d86cb99472639edae9658449dd19b6cd630f1541cf561b1a4f4563de4b946d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4d86cb99472639edae9658449dd19b6cd630f1541cf561b1a4f4563de4b946d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4d86cb99472639edae9658449dd19b6cd630f1541cf561b1a4f4563de4b946d", kill_on_drop: false }` [INFO] [stdout] d4d86cb99472639edae9658449dd19b6cd630f1541cf561b1a4f4563de4b946d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3c248615b28aa2160fc4a7de47d8cfacaefa46fc2654c482e1b74517169f896 [INFO] running `Command { std: "docker" "start" "-a" "a3c248615b28aa2160fc4a7de47d8cfacaefa46fc2654c482e1b74517169f896", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling ahash v0.8.9 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking der v0.7.8 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking russh-cryptovec v0.7.3 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking polyval v0.6.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking aes v0.8.3 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ghash v0.5.0 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking termion v2.0.3 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-fd v0.3.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking russh-keys v0.46.0-beta.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking russh-sftp v2.0.0-beta.4 [INFO] [stderr] Checking russh v0.46.0-beta.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking ratatui v0.26.1 [INFO] [stdout] error: this value of type `tokio::io::WriteHalf` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session.rs:424:27 [INFO] [stdout] | [INFO] [stdout] 409 | mut self, [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | mut stream: SshRead, [INFO] [stdout] 411 | mut handler: H, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | let (stream_read, mut stream_write) = stream.split(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 433 | pin!(keepalive_timer); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | pin!(inactivity_timer); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | pin!(reading); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | / tokio::select! { [INFO] [stdout] 449 | | r = &mut reading => { [INFO] [stdout] 450 | | let (stream_read, mut buffer, mut opening_cipher) = match r { [INFO] [stdout] 451 | | Ok((_, stream_read, buffer, opening_cipher)) => (stream_read, buffer, opening_cipher), [INFO] [stdout] ... | [INFO] [stdout] 576 | | } [INFO] [stdout] 577 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:880:13 [INFO] [stdout] | [INFO] [stdout] 880 | let mut result: Result = [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 902 | pin!(keepalive_timer); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 906 | pin!(inactivity_timer); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 909 | pin!(reading); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 915 | / tokio::select! { [INFO] [stdout] 916 | | r = &mut reading => { [INFO] [stdout] 917 | | let (stream_read, mut buffer, mut opening_cipher) = match r { [INFO] [stdout] 918 | | Ok((_, stream_read, buffer, opening_cipher)) => (stream_read, buffer, opening_cipher), [INFO] [stdout] ... | [INFO] [stdout] 998 | | } [INFO] [stdout] 999 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::io::WriteHalf` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session.rs:424:27 [INFO] [stdout] | [INFO] [stdout] 409 | mut self, [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 410 | mut stream: SshRead, [INFO] [stdout] 411 | mut handler: H, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 424 | let (stream_read, mut stream_write) = stream.split(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 433 | pin!(keepalive_timer); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | pin!(inactivity_timer); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | pin!(reading); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | / tokio::select! { [INFO] [stdout] 449 | | r = &mut reading => { [INFO] [stdout] 450 | | let (stream_read, mut buffer, mut opening_cipher) = match r { [INFO] [stdout] 451 | | Ok((_, stream_read, buffer, opening_cipher)) => (stream_read, buffer, opening_cipher), [INFO] [stdout] ... | [INFO] [stdout] 576 | | } [INFO] [stdout] 577 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::UnboundedSender<<::Handler as server::Handler>::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:570:14 [INFO] [stdout] | [INFO] [stdout] 560 | config: Arc, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | let (error_tx, mut error_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | / tokio::select! { [INFO] [stdout] 574 | | accept_result = socket.accept() => { [INFO] [stdout] 575 | | match accept_result { [INFO] [stdout] 576 | | Ok((socket, _)) => { [INFO] [stdout] ... | [INFO] [stdout] 603 | | } [INFO] [stdout] 604 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `algo` are never read [INFO] [stdout] --> src/auth.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | PublicKey { [INFO] [stdout] | --------- fields in this variant [INFO] [stdout] 140 | key: CryptoVec, [INFO] [stdout] | ^^^ [INFO] [stdout] 141 | algo: CryptoVec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CurrentRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `russh` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/mod.rs:880:13 [INFO] [stdout] | [INFO] [stdout] 880 | let mut result: Result = [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 902 | pin!(keepalive_timer); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 906 | pin!(inactivity_timer); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 909 | pin!(reading); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 915 | / tokio::select! { [INFO] [stdout] 916 | | r = &mut reading => { [INFO] [stdout] 917 | | let (stream_read, mut buffer, mut opening_cipher) = match r { [INFO] [stdout] 918 | | Ok((_, stream_read, buffer, opening_cipher)) => (stream_read, buffer, opening_cipher), [INFO] [stdout] ... | [INFO] [stdout] 998 | | } [INFO] [stdout] 999 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `russh_cryptovec::CryptoVec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 50 | let mut session = client::connect(config, addr, Client {}).await.unwrap(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let mut channel = session.channel_open_session().await.unwrap(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let msg = channel.wait().await.unwrap(); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | match msg { [INFO] [stdout] 65 | ChannelMsg::Data { data: msg_data } => { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::UnboundedSender<<::Handler as server::Handler>::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/mod.rs:570:14 [INFO] [stdout] | [INFO] [stdout] 560 | config: Arc, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | let (error_tx, mut error_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | / tokio::select! { [INFO] [stdout] 574 | | accept_result = socket.accept() => { [INFO] [stdout] 575 | | match accept_result { [INFO] [stdout] 576 | | Ok((socket, _)) => { [INFO] [stdout] ... | [INFO] [stdout] 603 | | } [INFO] [stdout] 604 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Server` is never constructed [INFO] [stdout] --> src/tests.rs:177:16 [INFO] [stdout] | [INFO] [stdout] 177 | struct Server {} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `algo` are never read [INFO] [stdout] --> src/auth.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | PublicKey { [INFO] [stdout] | --------- fields in this variant [INFO] [stdout] 140 | key: CryptoVec, [INFO] [stdout] | ^^^ [INFO] [stdout] 141 | algo: CryptoVec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CurrentRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `russh` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a3c248615b28aa2160fc4a7de47d8cfacaefa46fc2654c482e1b74517169f896", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3c248615b28aa2160fc4a7de47d8cfacaefa46fc2654c482e1b74517169f896", kill_on_drop: false }` [INFO] [stdout] a3c248615b28aa2160fc4a7de47d8cfacaefa46fc2654c482e1b74517169f896