[INFO] fetching crate run-clang-tidy 0.3.0... [INFO] checking run-clang-tidy-0.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate run-clang-tidy 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate run-clang-tidy 0.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate run-clang-tidy 0.3.0 [INFO] finished tweaking crates.io crate run-clang-tidy 0.3.0 [INFO] tweaked toml for crates.io crate run-clang-tidy 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate run-clang-tidy 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eee43527ada143574ab3fb9a3c6964f506782a0d6c1770f0d791c785e434afad [INFO] running `Command { std: "docker" "start" "-a" "eee43527ada143574ab3fb9a3c6964f506782a0d6c1770f0d791c785e434afad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eee43527ada143574ab3fb9a3c6964f506782a0d6c1770f0d791c785e434afad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eee43527ada143574ab3fb9a3c6964f506782a0d6c1770f0d791c785e434afad", kill_on_drop: false }` [INFO] [stdout] eee43527ada143574ab3fb9a3c6964f506782a0d6c1770f0d791c785e434afad [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ed65119ca6d1a529480a7717fa19abb138d2868d756de9ffaf8715a9392bab3 [INFO] running `Command { std: "docker" "start" "-a" "8ed65119ca6d1a529480a7717fa19abb138d2868d756de9ffaf8715a9392bab3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling schemars v0.8.16 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling serde_derive_internals v0.26.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling run-clang-tidy v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling schemars_derive v0.8.16 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking globmatch v0.3.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/cli/handlers.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | fn display(&self, pi: &std::panic::PanicInfo<'_>, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/cli/handlers.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | fn display(&self, pi: &std::panic::PanicInfo<'_>, f: &mut fmt::Formatter<'_>) -> fmt::Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `clap::Command` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / clap::Command::new(crate_name!()) [INFO] [stdout] 87 | | .arg_required_else_help(true) [INFO] [stdout] 88 | | .version(crate_version!()) [INFO] [stdout] 89 | | .author(crate_authors!()) [INFO] [stdout] ... | [INFO] [stdout] 92 | | arg!() [INFO] [stdout] | | ------------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 97 | | / arg!(-t --tidy ... "Optional path to the .clang-tidy configuration file. \ [INFO] [stdout] 98 | | | Overrides configuration. If no path is provided, \ [INFO] [stdout] 99 | | | `clang-tidy` will attempt a search for the compile commands \ [INFO] [stdout] 100 | | | through all parent paths of the file that is being analyzed.") [INFO] [stdout] | | | - [INFO] [stdout] | | |__________________________________________________________________________________________________| [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 119 | | / arg!(-c --command ... "Optional path to executable or clang-tidy command. \ [INFO] [stdout] 120 | | | Overrides configuration, defaults to `clang-tidy`") [INFO] [stdout] | | | - [INFO] [stdout] | | |_________________________________________________________________________________________________| [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 126 | | / arg!(-j --jobs ... "Optional parameter to define the number of jobs to use. \ [INFO] [stdout] 127 | | | If provided without value (e.g., '-j') all available logical \ [INFO] [stdout] 128 | | | cores are used. Maximum value is 255") [INFO] [stdout] | | | - [INFO] [stdout] | | |__________________________________________________________________________| [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 133 | | | .arg(arg!(-v --verbose ... "Verbosity, use -vv... for verbose output.").global(true)) [INFO] [stdout] | | | ------------------------------------------------------------------ [INFO] [stdout] | | | | [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | | | .arg(arg!(--fix "Fix findings, if possible. Executes clang-tidy with the -fix and -fix-errors options.")) [INFO] [stdout] | |______________|__________________---------------------------------------------------------------------------------------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | | .arg( [INFO] [stdout] 136 | | arg!(-q --quiet "Suppress all output except for errors; overrides -v") [INFO] [stdout] | | ---------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `clap::Command` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/mod.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / clap::Command::new(crate_name!()) [INFO] [stdout] 87 | | .arg_required_else_help(true) [INFO] [stdout] 88 | | .version(crate_version!()) [INFO] [stdout] 89 | | .author(crate_authors!()) [INFO] [stdout] ... | [INFO] [stdout] 92 | | arg!() [INFO] [stdout] | | ------------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 97 | | / arg!(-t --tidy ... "Optional path to the .clang-tidy configuration file. \ [INFO] [stdout] 98 | | | Overrides configuration. If no path is provided, \ [INFO] [stdout] 99 | | | `clang-tidy` will attempt a search for the compile commands \ [INFO] [stdout] 100 | | | through all parent paths of the file that is being analyzed.") [INFO] [stdout] | | | - [INFO] [stdout] | | |__________________________________________________________________________________________________| [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 119 | | / arg!(-c --command ... "Optional path to executable or clang-tidy command. \ [INFO] [stdout] 120 | | | Overrides configuration, defaults to `clang-tidy`") [INFO] [stdout] | | | - [INFO] [stdout] | | |_________________________________________________________________________________________________| [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |_________________________________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 126 | | / arg!(-j --jobs ... "Optional parameter to define the number of jobs to use. \ [INFO] [stdout] 127 | | | If provided without value (e.g., '-j') all available logical \ [INFO] [stdout] 128 | | | cores are used. Maximum value is 255") [INFO] [stdout] | | | - [INFO] [stdout] | | |__________________________________________________________________________| [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | |__________________________________________________________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 133 | | | .arg(arg!(-v --verbose ... "Verbosity, use -vv... for verbose output.").global(true)) [INFO] [stdout] | | | ------------------------------------------------------------------ [INFO] [stdout] | | | | [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | | | .arg(arg!(--fix "Fix findings, if possible. Executes clang-tidy with the -fix and -fix-errors options.")) [INFO] [stdout] | |______________|__________________---------------------------------------------------------------------------------------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | | .arg( [INFO] [stdout] 136 | | arg!(-q --quiet "Suppress all output except for errors; overrides -v") [INFO] [stdout] | | ---------------------------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run-clang-tidy` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run-clang-tidy` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8ed65119ca6d1a529480a7717fa19abb138d2868d756de9ffaf8715a9392bab3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ed65119ca6d1a529480a7717fa19abb138d2868d756de9ffaf8715a9392bab3", kill_on_drop: false }` [INFO] [stdout] 8ed65119ca6d1a529480a7717fa19abb138d2868d756de9ffaf8715a9392bab3