[INFO] fetching crate rsfs 0.4.1... [INFO] checking rsfs-0.4.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rsfs 0.4.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rsfs 0.4.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsfs 0.4.1 [INFO] finished tweaking crates.io crate rsfs 0.4.1 [INFO] tweaked toml for crates.io crate rsfs 0.4.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding owning_ref v0.3.3 (available: v0.4.1) [INFO] [stderr] Adding parking_lot v0.4.8 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.2.14 (available: v0.9.10) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding smallvec v0.6.14 (available: v1.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 621ee9f6ae2eeb2b86686f48499fafb691c280d26d242be51209d85de6108b57 [INFO] running `Command { std: "docker" "start" "-a" "621ee9f6ae2eeb2b86686f48499fafb691c280d26d242be51209d85de6108b57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "621ee9f6ae2eeb2b86686f48499fafb691c280d26d242be51209d85de6108b57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "621ee9f6ae2eeb2b86686f48499fafb691c280d26d242be51209d85de6108b57", kill_on_drop: false }` [INFO] [stdout] 621ee9f6ae2eeb2b86686f48499fafb691c280d26d242be51209d85de6108b57 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd36e846cca5b4c9ddd4e21e0aba8ec2adccd431c99d90d9492b1ea8c7b698b4 [INFO] running `Command { std: "docker" "start" "-a" "dd36e846cca5b4c9ddd4e21e0aba8ec2adccd431c99d90d9492b1ea8c7b698b4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking rsfs v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mem/unix.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | let mut dst = &mut self.data; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::parking_lot::MutexGuard<'_, mem::fs::FileSystem>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:927:9 [INFO] [stdout] | [INFO] [stdout] 926 | fn read_dir>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 927 | self.0.lock().read_dir(&path, &path, &mut 0) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:974:9 [INFO] [stdout] | [INFO] [stdout] 972 | fn open_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 973 | use fs::OpenOptions; [INFO] [stdout] 974 | self.new_openopts().read(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:978:9 [INFO] [stdout] | [INFO] [stdout] 976 | fn create_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | use fs::OpenOptions; [INFO] [stdout] 978 | self.new_openopts().write(true).create(true).truncate(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mem/unix.rs:1933:14 [INFO] [stdout] | [INFO] [stdout] 1933 | let (mut fs, may_base) = self.traverse(normalize(&path), level)?; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mem/unix.rs:1958:21 [INFO] [stdout] | [INFO] [stdout] 1958 | let mut child = *child; // copy out of the borrow [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::parking_lot::MutexGuard<'_, mem::unix::FileSystem>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:927:9 [INFO] [stdout] | [INFO] [stdout] 926 | fn read_dir>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 927 | self.0.lock().read_dir(&path, &path, &mut 0) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::unix::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:974:9 [INFO] [stdout] | [INFO] [stdout] 972 | fn open_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 973 | use fs::OpenOptions; [INFO] [stdout] 974 | self.new_openopts().read(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::unix::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:978:9 [INFO] [stdout] | [INFO] [stdout] 976 | fn create_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | use fs::OpenOptions; [INFO] [stdout] 978 | self.new_openopts().write(true).create(true).truncate(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1757:18 [INFO] [stdout] | [INFO] [stdout] 1757 | unsafe { Box::from_raw(removed.ptr()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1757 | unsafe { let _ = Box::from_raw(removed.ptr()); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1814:30 [INFO] [stdout] | [INFO] [stdout] 1814 | unsafe { Box::from_raw(removed.ptr()); } // free the memory [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1814 | unsafe { let _ = Box::from_raw(removed.ptr()); } // free the memory [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1831:30 [INFO] [stdout] | [INFO] [stdout] 1831 | unsafe { Box::from_raw(child.remove().ptr()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1831 | unsafe { let _ = Box::from_raw(child.remove().ptr()); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1840:26 [INFO] [stdout] | [INFO] [stdout] 1840 | unsafe { Box::from_raw(fs.ptr()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1840 | unsafe { let _ = Box::from_raw(fs.ptr()); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/ptr.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | this.ptr == other.ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 27 | std::ptr::addr_eq(this.ptr, other.ptr) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 27 | std::ptr::eq(this.ptr, other.ptr) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsfs` (lib) due to 7 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mem/unix.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | let mut dst = &mut self.data; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::parking_lot::MutexGuard<'_, mem::fs::FileSystem>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:927:9 [INFO] [stdout] | [INFO] [stdout] 926 | fn read_dir>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 927 | self.0.lock().read_dir(&path, &path, &mut 0) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:974:9 [INFO] [stdout] | [INFO] [stdout] 972 | fn open_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 973 | use fs::OpenOptions; [INFO] [stdout] 974 | self.new_openopts().read(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:978:9 [INFO] [stdout] | [INFO] [stdout] 976 | fn create_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | use fs::OpenOptions; [INFO] [stdout] 978 | self.new_openopts().write(true).create(true).truncate(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mem/unix.rs:1933:14 [INFO] [stdout] | [INFO] [stdout] 1933 | let (mut fs, may_base) = self.traverse(normalize(&path), level)?; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mem/unix.rs:1958:21 [INFO] [stdout] | [INFO] [stdout] 1958 | let mut child = *child; // copy out of the borrow [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::parking_lot::MutexGuard<'_, mem::fs::FileCursor>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:2733:17 [INFO] [stdout] | [INFO] [stdout] 2676 | let fs = FS::with_mode(0o300); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2733 | let cursor = f.cursor.lock(); // re-check the initial f [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::parking_lot::MutexGuard<'_, mem::unix::FileSystem>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:927:9 [INFO] [stdout] | [INFO] [stdout] 926 | fn read_dir>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 927 | self.0.lock().read_dir(&path, &path, &mut 0) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::unix::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:974:9 [INFO] [stdout] | [INFO] [stdout] 972 | fn open_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 973 | use fs::OpenOptions; [INFO] [stdout] 974 | self.new_openopts().read(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::unix::OpenOptions` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:978:9 [INFO] [stdout] | [INFO] [stdout] 976 | fn create_file>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | use fs::OpenOptions; [INFO] [stdout] 978 | self.new_openopts().write(true).create(true).truncate(true).open(path.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `mem::fs::parking_lot::MutexGuard<'_, mem::unix::FileCursor>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:2733:17 [INFO] [stdout] | [INFO] [stdout] 2676 | let fs = FS::with_mode(0o300); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2733 | let cursor = f.cursor.lock(); // re-check the initial f [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1757:18 [INFO] [stdout] | [INFO] [stdout] 1757 | unsafe { Box::from_raw(removed.ptr()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1757 | unsafe { let _ = Box::from_raw(removed.ptr()); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1814:30 [INFO] [stdout] | [INFO] [stdout] 1814 | unsafe { Box::from_raw(removed.ptr()); } // free the memory [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1814 | unsafe { let _ = Box::from_raw(removed.ptr()); } // free the memory [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1831:30 [INFO] [stdout] | [INFO] [stdout] 1831 | unsafe { Box::from_raw(child.remove().ptr()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1831 | unsafe { let _ = Box::from_raw(child.remove().ptr()); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/mem/unix.rs:1840:26 [INFO] [stdout] | [INFO] [stdout] 1840 | unsafe { Box::from_raw(fs.ptr()); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1840 | unsafe { let _ = Box::from_raw(fs.ptr()); } [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/ptr.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | this.ptr == other.ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 27 | std::ptr::addr_eq(this.ptr, other.ptr) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 27 | std::ptr::eq(this.ptr, other.ptr) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsfs` (lib test) due to 9 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dd36e846cca5b4c9ddd4e21e0aba8ec2adccd431c99d90d9492b1ea8c7b698b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd36e846cca5b4c9ddd4e21e0aba8ec2adccd431c99d90d9492b1ea8c7b698b4", kill_on_drop: false }` [INFO] [stdout] dd36e846cca5b4c9ddd4e21e0aba8ec2adccd431c99d90d9492b1ea8c7b698b4