[INFO] fetching crate rscel 1.0.2... [INFO] checking rscel-1.0.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rscel 1.0.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rscel 1.0.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rscel 1.0.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rscel 1.0.2 [INFO] tweaked toml for crates.io crate rscel 1.0.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rscel 1.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 254b1c5743da54119496633d80b98a0354ef74413f5617afd9765c6293afd9c1 [INFO] running `Command { std: "docker" "start" "-a" "254b1c5743da54119496633d80b98a0354ef74413f5617afd9765c6293afd9c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "254b1c5743da54119496633d80b98a0354ef74413f5617afd9765c6293afd9c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "254b1c5743da54119496633d80b98a0354ef74413f5617afd9765c6293afd9c1", kill_on_drop: false }` [INFO] [stdout] 254b1c5743da54119496633d80b98a0354ef74413f5617afd9765c6293afd9c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d54c450434260d8286f19d63bec8e464463e504f01c192a84ed751899f786ae8 [INFO] running `Command { std: "docker" "start" "-a" "d54c450434260d8286f19d63bec8e464463e504f01c192a84ed751899f786ae8", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling protobuf v3.5.0 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling protoc-bin-vendored-win32 v3.0.0 [INFO] [stderr] Compiling protoc-bin-vendored-macos-x86_64 v3.0.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-ppcle_64 v3.0.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_64 v3.0.0 [INFO] [stderr] Compiling rust_decimal v1.35.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-aarch_64 v3.0.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_32 v3.0.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling protoc-bin-vendored v3.0.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking winnow v0.6.16 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling test-case-core v3.3.1 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling test-case-macros v3.3.1 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking test-case v3.3.1 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking protobuf-support v3.5.0 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Compiling protobuf-parse v3.5.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling protobuf-codegen v3.5.0 [INFO] [stderr] Checking duration-str v0.11.2 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Compiling rscel v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(CelValue, CelValue)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cel_value.rs:336:15 [INFO] [stdout] | [INFO] [stdout] 331 | let type1 = self.as_type(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | let type2 = rhs_value.as_type(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(CelValue, CelValue)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cel_value.rs:638:23 [INFO] [stdout] | [INFO] [stdout] 626 | .error_prop_or(rhs_val.clone(), |lhs_val, rhs_val| { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 638 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(NodeValue, NodeValue)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/compiled_node.rs:152:15 [INFO] [stdout] | [INFO] [stdout] 142 | child1: CompiledNode, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | child2: CompiledNode, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | bytecode: Vec, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | resolve: F, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | match (child1.inner, child2.inner) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(cel_value::CelValue, cel_value::CelValue)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cel_value.rs:336:15 [INFO] [stdout] | [INFO] [stdout] 331 | let type1 = self.as_type(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | let type2 = rhs_value.as_type(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(cel_value::CelValue, cel_value::CelValue)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cel_value.rs:638:23 [INFO] [stdout] | [INFO] [stdout] 626 | .error_prop_or(rhs_val.clone(), |lhs_val, rhs_val| { [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 638 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(NodeValue, NodeValue)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/compiled_node.rs:152:15 [INFO] [stdout] | [INFO] [stdout] 142 | child1: CompiledNode, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | child2: CompiledNode, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | bytecode: Vec, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | resolve: F, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | match (child1.inner, child2.inner) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rscel` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/general_tests.rs:432:11 [INFO] [stdout] | [INFO] [stdout] 416 | let mut ctx = CelContext::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | let mut exec1 = BindContext::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | let mut exec2 = BindContext::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 432 | match ctx.exec("main", &exec2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cel_value::CelValue` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/type_prop_tests.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 22 | let mut ctx = CelContext::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let exec_ctx = BindContext::new(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let eval_res = ctx.exec("main", &exec_ctx); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | if cfg!(feature = "type_prop") { [INFO] [stdout] 29 | if let CelValue::Float(f) = eval_res.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `cel_value::CelValue` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/type_prop_tests.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 53 | fn test_equation(prog: &str, res: CelValue) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut ctx = CelContext::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let exec_ctx = BindContext::new(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let eval_res = ctx.exec("main", &exec_ctx); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | assert_eq!(eval_res.unwrap(), res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rscel` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "d54c450434260d8286f19d63bec8e464463e504f01c192a84ed751899f786ae8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d54c450434260d8286f19d63bec8e464463e504f01c192a84ed751899f786ae8", kill_on_drop: false }` [INFO] [stdout] d54c450434260d8286f19d63bec8e464463e504f01c192a84ed751899f786ae8