[INFO] fetching crate rsbwapi 0.3.3... [INFO] checking rsbwapi-0.3.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rsbwapi 0.3.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rsbwapi 0.3.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsbwapi 0.3.3 [INFO] finished tweaking crates.io crate rsbwapi 0.3.3 [INFO] tweaked toml for crates.io crate rsbwapi 0.3.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 134 packages to latest compatible versions [INFO] [stderr] Adding atomic v0.5.3 (available: v0.6.0) [INFO] [stderr] Adding auto_enums v0.7.12 (available: v0.8.6) [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding derive_utils v0.11.2 (available: v0.14.2) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding image v0.24.9 (available: v0.25.2) [INFO] [stderr] Adding imageproc v0.23.0 (available: v0.25.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (available: v0.8.0) [INFO] [stderr] Adding nalgebra v0.30.1 (available: v0.33.0) [INFO] [stderr] Adding owned_ttf_parser v0.15.2 (available: v0.24.0) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_distr v0.2.2 (available: v0.4.3) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding simba v0.7.3 (available: v0.9.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding ttf-parser v0.15.2 (available: v0.24.1) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdaa8c5ec55be11862edd9276be2088fbad023e62a4fcb9b4df4b6963a8008da [INFO] running `Command { std: "docker" "start" "-a" "cdaa8c5ec55be11862edd9276be2088fbad023e62a4fcb9b4df4b6963a8008da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdaa8c5ec55be11862edd9276be2088fbad023e62a4fcb9b4df4b6963a8008da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdaa8c5ec55be11862edd9276be2088fbad023e62a4fcb9b4df4b6963a8008da", kill_on_drop: false }` [INFO] [stdout] cdaa8c5ec55be11862edd9276be2088fbad023e62a4fcb9b4df4b6963a8008da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76827d23db41770d12d022fe68b831d7cccf52507b237b584aa629e618036690 [INFO] running `Command { std: "docker" "start" "-a" "76827d23db41770d12d022fe68b831d7cccf52507b237b584aa629e618036690", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking fdeflate v0.3.5 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling bwapi_wrapper v0.3.3 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking png v0.17.14 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking rstar v0.12.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking rsbwapi v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::iter::Map, {closure@src/game.rs:179:25: 179:36}>, {closure@src/game.rs:180:18: 180:27}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 171 | let pred = pred.into_predicate(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | / self.inner [INFO] [stdout] 175 | | .deref() [INFO] [stdout] 176 | | .rtree [INFO] [stdout] 177 | | .borrow() [INFO] [stdout] 178 | | .nearest_neighbor_iter_with_distance_2(&[center.x, center.y]) [INFO] [stdout] 179 | | .take_while(|&(_, d_2)| d_2 <= radius_squared as i32) [INFO] [stdout] 180 | | .map(|(ul, _)| self.get_unit(ul.id).expect("Unit from RTree to be present")) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, RTree>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 192 | let pred = pred.into_predicate(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | / self.inner [INFO] [stdout] 194 | | .rtree [INFO] [stdout] 195 | | .borrow() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::iter::Map, {closure@src/game.rs:241:25: 241:36}>, {closure@src/game.rs:242:21: 242:30}>, {closure@src/game.rs:243:18: 243:27}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 222 | let pred = pred.into_predicate(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | / self.inner [INFO] [stdout] 237 | | .deref() [INFO] [stdout] 238 | | .rtree [INFO] [stdout] 239 | | .borrow() [INFO] [stdout] ... | [INFO] [stdout] 242 | | .filter(|(ul, _)| ul.location.envelope().intersects(&query_envelope)) [INFO] [stdout] 243 | | .map(|(ul, _)| self.get_unit(ul.id).expect("Unit from RTree to be present")) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:751:30 [INFO] [stdout] | [INFO] [stdout] 748 | builder: B, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 751 | if let Some(self_) = self.self_() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/shm.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) struct Shm(usize, NonNull); [INFO] [stdout] | --- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) struct Shm((), NonNull); [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `UnitCommandExt` is never used [INFO] [stdout] --> src/unit.rs:1355:7 [INFO] [stdout] | [INFO] [stdout] 1355 | trait UnitCommandExt { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsbwapi` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "76827d23db41770d12d022fe68b831d7cccf52507b237b584aa629e618036690", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76827d23db41770d12d022fe68b831d7cccf52507b237b584aa629e618036690", kill_on_drop: false }` [INFO] [stdout] 76827d23db41770d12d022fe68b831d7cccf52507b237b584aa629e618036690