[INFO] fetching crate rpmrepo_metadata 0.3.0... [INFO] checking rpmrepo_metadata-0.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rpmrepo_metadata 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rpmrepo_metadata 0.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rpmrepo_metadata 0.3.0 [INFO] removed 1 missing tests [INFO] finished tweaking crates.io crate rpmrepo_metadata 0.3.0 [INFO] tweaked toml for crates.io crate rpmrepo_metadata 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 150 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cpio v0.2.2 (available: v0.4.0) [INFO] [stderr] Adding enum-primitive-derive v0.2.2 (available: v0.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding niffler v2.5.0 (available: v2.6.0) [INFO] [stderr] Adding pyo3 v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-build-config v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-ffi v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros-backend v0.20.3 (available: v0.22.3) [INFO] [stderr] Adding quick-xml v0.23.1 (available: v0.36.2) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (available: v0.8.4) [INFO] [stderr] Adding rpm v0.12.1 (available: v0.15.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding zstd v0.12.4 (available: v0.13.2) [INFO] [stderr] Adding zstd-safe v6.0.6 (available: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 680f948c1557cce9608d00453e6071d751de24bd5d02050a7a5caa6786953d71 [INFO] running `Command { std: "docker" "start" "-a" "680f948c1557cce9608d00453e6071d751de24bd5d02050a7a5caa6786953d71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "680f948c1557cce9608d00453e6071d751de24bd5d02050a7a5caa6786953d71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "680f948c1557cce9608d00453e6071d751de24bd5d02050a7a5caa6786953d71", kill_on_drop: false }` [INFO] [stdout] 680f948c1557cce9608d00453e6071d751de24bd5d02050a7a5caa6786953d71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f734e7433e8524a900b1b0a323107f443773c7b16b705e4f55817595c715e53d [INFO] running `Command { std: "docker" "start" "-a" "f734e7433e8524a900b1b0a323107f443773c7b16b705e4f55817595c715e53d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling zstd-safe v6.0.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking quick-xml v0.23.1 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking zstd v0.12.4 [INFO] [stderr] Checking niffler v2.5.0 [INFO] [stderr] Checking rpmrepo_metadata v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/metadata.rs:725:47 [INFO] [stdout] | [INFO] [stdout] 725 | pub fn to_values<'a>(&'a self) -> Result<(&str, &'a str), MetadataError> { [INFO] [stdout] | -- ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/metadata.rs:725:47 [INFO] [stdout] | [INFO] [stdout] 725 | pub fn to_values<'a>(&'a self) -> Result<(&str, &'a str), MetadataError> { [INFO] [stdout] | -- ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/repository.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufRead` [INFO] [stdout] --> src/repository.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{BufRead, BufReader, Write}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/repository.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BufRead` [INFO] [stdout] --> src/repository.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{BufRead, BufReader, Write}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hash` [INFO] [stdout] --> src/metadata.rs:626:27 [INFO] [stdout] | [INFO] [stdout] 626 | Self::Unknown(hash) => unimplemented!(), [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_hash` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `updateinfo_path` [INFO] [stdout] --> src/repository.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | let (updateinfo_path, updateinfo_writer) = utils::xml_writer_for_path( [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_updateinfo_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `GenericArray::OutputSize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 21 | fn get_digest(mut reader: Box) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(hex::encode(hasher.finalize().as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rpmvercmp` is never used [INFO] [stdout] --> src/common.rs:251:8 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn rpmvercmp(evr1: &str, evr2: &str) -> Ordering { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TAG_REBOOT_SUGGESTED` is never used [INFO] [stdout] --> src/updateinfo.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | const TAG_REBOOT_SUGGESTED: &[u8] = b"reboot_suggested"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/common.rs:132:37 [INFO] [stdout] | [INFO] [stdout] 132 | let mut version1_part = version1.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/common.rs:133:37 [INFO] [stdout] | [INFO] [stdout] 133 | let mut version2_part = version2.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hash` [INFO] [stdout] --> src/metadata.rs:626:27 [INFO] [stdout] | [INFO] [stdout] 626 | Self::Unknown(hash) => unimplemented!(), [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_hash` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpmrepo_metadata` (lib) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `updateinfo_path` [INFO] [stdout] --> src/repository.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | let (updateinfo_path, updateinfo_writer) = utils::xml_writer_for_path( [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_updateinfo_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `GenericArray::OutputSize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 21 | fn get_digest(mut reader: Box) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(hex::encode(hasher.finalize().as_ref())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TAG_REBOOT_SUGGESTED` is never used [INFO] [stdout] --> src/updateinfo.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | const TAG_REBOOT_SUGGESTED: &[u8] = b"reboot_suggested"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/common.rs:132:37 [INFO] [stdout] | [INFO] [stdout] 132 | let mut version1_part = version1.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/common.rs:133:37 [INFO] [stdout] | [INFO] [stdout] 133 | let mut version2_part = version2.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpmrepo_metadata` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f734e7433e8524a900b1b0a323107f443773c7b16b705e4f55817595c715e53d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f734e7433e8524a900b1b0a323107f443773c7b16b705e4f55817595c715e53d", kill_on_drop: false }` [INFO] [stdout] f734e7433e8524a900b1b0a323107f443773c7b16b705e4f55817595c715e53d