[INFO] fetching crate rpcx_client 0.3.0... [INFO] checking rpcx_client-0.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rpcx_client 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rpcx_client 0.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rpcx_client 0.3.0 [INFO] finished tweaking crates.io crate rpcx_client 0.3.0 [INFO] tweaked toml for crates.io crate rpcx_client 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 106 packages to latest compatible versions [INFO] [stderr] Adding enum-primitive-derive v0.1.2 (available: v0.3.0) [INFO] [stderr] Adding enum-primitive-derive v0.2.2 (available: v0.3.0) [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding num-traits v0.1.43 (available: v0.2.19) [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.86) [INFO] [stderr] Adding quote v0.3.15 (available: v1.0.37) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.37) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding strum v0.21.0 (available: v0.26.3) [INFO] [stderr] Adding strum_macros v0.21.1 (available: v0.26.4) [INFO] [stderr] Adding syn v0.11.11 (available: v2.0.79) [INFO] [stderr] Adding syn v0.15.44 (available: v2.0.79) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding unicode-xid v0.0.4 (available: v0.2.6) [INFO] [stderr] Adding unicode-xid v0.1.0 (available: v0.2.6) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9330680ada96e7d01a0834ee2a97c988ecac2705f18cade71d006a830192945 [INFO] running `Command { std: "docker" "start" "-a" "b9330680ada96e7d01a0834ee2a97c988ecac2705f18cade71d006a830192945", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9330680ada96e7d01a0834ee2a97c988ecac2705f18cade71d006a830192945", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9330680ada96e7d01a0834ee2a97c988ecac2705f18cade71d006a830192945", kill_on_drop: false }` [INFO] [stdout] b9330680ada96e7d01a0834ee2a97c988ecac2705f18cade71d006a830192945 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f956d2618a346e88fa23271d74bd842a156715e1b6a86cb708acbc5be72f4662 [INFO] running `Command { std: "docker" "start" "-a" "f956d2618a346e88fa23271d74bd842a156715e1b6a86cb708acbc5be72f4662", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling futures-sink v0.3.30 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling futures-io v0.3.30 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling adler2 v2.0.0 [INFO] [stderr] Compiling futures-channel v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling mio v1.0.2 [INFO] [stderr] Compiling miniz_oxide v0.8.0 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling bytes v1.7.2 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling strum v0.21.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling flate2 v1.0.34 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking hashbag v0.1.12 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking evmap v10.0.2 [INFO] [stderr] Compiling enum-primitive-derive v0.1.2 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling enum-primitive-derive v0.2.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking jumphash v0.1.8 [INFO] [stderr] Checking weighted-rs v0.1.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rpcx_protocol v0.3.0 [INFO] [stderr] Compiling rpcx_derive v0.3.0 [INFO] [stderr] Checking rpcx_client v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/client.rs:250:52 [INFO] [stdout] | [INFO] [stdout] 250 | internal_call.error = String::from(err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/client.rs:250:52 [INFO] [stdout] | [INFO] [stdout] 250 | internal_call.error = String::from(err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/client.rs:265:52 [INFO] [stdout] | [INFO] [stdout] 265 | internal_call.error = String::from(err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/client.rs:265:52 [INFO] [stdout] | [INFO] [stdout] 265 | internal_call.error = String::from(err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/client.rs:282:52 [INFO] [stdout] | [INFO] [stdout] 282 | internal_call.error = String::from(err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/client.rs:282:52 [INFO] [stdout] | [INFO] [stdout] 282 | internal_call.error = String::from(err.description()); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 244 | let calls = self.calls.clone(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let mut m = calls.lock().unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | if let Some(call) = m.remove(&seq) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 244 | let calls = self.calls.clone(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | let mut m = calls.lock().unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | if let Some(call) = m.remove(&seq) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), rpcx_protocol::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 302 | let rt = Runtime::new().unwrap(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let arc_call_1 = callfuture.unwrap().clone(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let mut arc_call_2 = arc_call_1.lock().unwrap(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | let mut reply: T = Default::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | match reply.from_slice(self.opt.serialize_type, &reply_data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), rpcx_protocol::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:334:15 [INFO] [stdout] | [INFO] [stdout] 302 | let rt = Runtime::new().unwrap(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let arc_call_1 = callfuture.unwrap().clone(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let mut arc_call_2 = arc_call_1.lock().unwrap(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | let mut reply: T = Default::default(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | match reply.from_slice(self.opt.serialize_type, &reply_data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpcx_client` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpcx_client` (lib) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f956d2618a346e88fa23271d74bd842a156715e1b6a86cb708acbc5be72f4662", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f956d2618a346e88fa23271d74bd842a156715e1b6a86cb708acbc5be72f4662", kill_on_drop: false }` [INFO] [stdout] f956d2618a346e88fa23271d74bd842a156715e1b6a86cb708acbc5be72f4662