[INFO] fetching crate routerify-websocket 3.0.0... [INFO] checking routerify-websocket-3.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate routerify-websocket 3.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate routerify-websocket 3.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate routerify-websocket 3.0.0 [INFO] finished tweaking crates.io crate routerify-websocket 3.0.0 [INFO] tweaked toml for crates.io crate routerify-websocket 3.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate routerify-websocket 3.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 753e8b568769a9ff7d508ff2e0a163870d5de9dc3c43187d43276942832abd18 [INFO] running `Command { std: "docker" "start" "-a" "753e8b568769a9ff7d508ff2e0a163870d5de9dc3c43187d43276942832abd18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "753e8b568769a9ff7d508ff2e0a163870d5de9dc3c43187d43276942832abd18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "753e8b568769a9ff7d508ff2e0a163870d5de9dc3c43187d43276942832abd18", kill_on_drop: false }` [INFO] [stdout] 753e8b568769a9ff7d508ff2e0a163870d5de9dc3c43187d43276942832abd18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f48e4bfb7f06613de0a6f8f401c1ade7f4d1237c5e226f492561bb207581594d [INFO] running `Command { std: "docker" "start" "-a" "f48e4bfb7f06613de0a6f8f401c1ade7f4d1237c5e226f492561bb207581594d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Checking headers v0.3.5 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tungstenite v0.16.0 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking tokio-tungstenite v0.16.1 [INFO] [stderr] Checking routerify v3.0.0 [INFO] [stderr] Checking routerify-websocket v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 181 | fn encode_header(h: T) -> HeaderValue { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | val.into_iter().nth(0).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | match ready!(Pin::new(&mut self.inner).poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 76 | match ready!(Pin::new(&mut self.inner).poll_ready(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | match ready!(Pin::new(&mut self.inner).poll_flush(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | match ready!(Pin::new(&mut self.inner).poll_close(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Display)] [INFO] [stdout] | -^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `_derive_more_DisplayAs` is not local [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_derive_more_DisplayAs_impl` and up 2 bodies [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `derive_more` crate, try updating your dependency with `cargo update -p derive_more` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `routerify-websocket` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 181 | fn encode_header(h: T) -> HeaderValue { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | val.into_iter().nth(0).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | match ready!(Pin::new(&mut self.inner).poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 76 | match ready!(Pin::new(&mut self.inner).poll_ready(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | match ready!(Pin::new(&mut self.inner).poll_flush(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | match ready!(Pin::new(&mut self.inner).poll_close(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Display)] [INFO] [stdout] | -^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `_derive_more_DisplayAs` is not local [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_derive_more_DisplayAs_impl` and up 2 bodies [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `derive_more` crate, try updating your dependency with `cargo update -p derive_more` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `routerify-websocket` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f48e4bfb7f06613de0a6f8f401c1ade7f4d1237c5e226f492561bb207581594d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f48e4bfb7f06613de0a6f8f401c1ade7f4d1237c5e226f492561bb207581594d", kill_on_drop: false }` [INFO] [stdout] f48e4bfb7f06613de0a6f8f401c1ade7f4d1237c5e226f492561bb207581594d