[INFO] fetching crate rome_rowan 0.0.1... [INFO] checking rome_rowan-0.0.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rome_rowan 0.0.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rome_rowan 0.0.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rome_rowan 0.0.1 [INFO] finished tweaking crates.io crate rome_rowan 0.0.1 [INFO] tweaked toml for crates.io crate rome_rowan 0.0.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding memoffset v0.8.0 (available: v0.9.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78a1e07bbccdfea0e787a59e5ce59f7424caddbf7f1c2741b0d994ec161bb97e [INFO] running `Command { std: "docker" "start" "-a" "78a1e07bbccdfea0e787a59e5ce59f7424caddbf7f1c2741b0d994ec161bb97e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78a1e07bbccdfea0e787a59e5ce59f7424caddbf7f1c2741b0d994ec161bb97e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78a1e07bbccdfea0e787a59e5ce59f7424caddbf7f1c2741b0d994ec161bb97e", kill_on_drop: false }` [INFO] [stdout] 78a1e07bbccdfea0e787a59e5ce59f7424caddbf7f1c2741b0d994ec161bb97e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6380298936d865cad87653a8f1d9588b3e5f255d6435e4c48503acdbab65b4cb [INFO] running `Command { std: "docker" "start" "-a" "6380298936d865cad87653a8f1d9588b3e5f255d6435e4c48503acdbab65b4cb", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking iai v0.1.1 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking rome_text_size v0.0.1 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rome_text_edit v0.0.1 [INFO] [stderr] Checking rome_rowan v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `NodeOrToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursor/node.rs:345:21 [INFO] [stdout] | [INFO] [stdout] 336 | let mut children = self.children_with_tokens().filter(|child| { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let left = children.next().unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let right = children.next(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | if let Some(right) = right { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/ast/mod.rs:737:1 [INFO] [stdout] | [INFO] [stdout] 737 | / mod tests { [INFO] [stdout] 738 | | use crate::raw_language::{ [INFO] [stdout] 739 | | LiteralExpression, RawLanguage, RawLanguageKind, RawSyntaxTreeBuilder, [INFO] [stdout] 740 | | SeparatedExpressionList, [INFO] [stdout] ... | [INFO] [stdout] 1066 | | } [INFO] [stdout] 1067 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] note: the name `tests` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/ast/mod.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub use batch::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/ast/mod.rs:737:1 [INFO] [stdout] | [INFO] [stdout] 737 | / mod tests { [INFO] [stdout] 738 | | use crate::raw_language::{ [INFO] [stdout] 739 | | LiteralExpression, RawLanguage, RawLanguageKind, RawSyntaxTreeBuilder, [INFO] [stdout] 740 | | SeparatedExpressionList, [INFO] [stdout] ... | [INFO] [stdout] 1066 | | } [INFO] [stdout] 1067 | | } [INFO] [stdout] | |_^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syntax::token::SyntaxToken<::Language>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mutation.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 125 | next_token: SyntaxToken, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | / next_token [INFO] [stdout] 136 | | .with_leading_trivia_pieces(leading_trivia) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syntax::node::SyntaxSlot` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:350:34 [INFO] [stdout] | [INFO] [stdout] 346 | fn last(self) -> Option [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Some(Self::slot_to_node(&self.inner.last()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/arc.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | this.ptr() == other.ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 89 | std::ptr::addr_eq(this.ptr(), other.ptr()) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 89 | std::ptr::eq(this.ptr(), other.ptr()) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rome_rowan` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `NodeOrToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cursor/node.rs:345:21 [INFO] [stdout] | [INFO] [stdout] 336 | let mut children = self.children_with_tokens().filter(|child| { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let left = children.next().unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 342 | let right = children.next(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | if let Some(right) = right { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syntax::token::SyntaxToken<::Language>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mutation.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 125 | next_token: SyntaxToken, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | / next_token [INFO] [stdout] 136 | | .with_leading_trivia_pieces(leading_trivia) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `syntax::node::SyntaxSlot` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:350:34 [INFO] [stdout] | [INFO] [stdout] 346 | fn last(self) -> Option [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Some(Self::slot_to_node(&self.inner.last()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/arc.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | this.ptr() == other.ptr() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 89 | std::ptr::addr_eq(this.ptr(), other.ptr()) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 89 | std::ptr::eq(this.ptr(), other.ptr()) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rome_rowan` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6380298936d865cad87653a8f1d9588b3e5f255d6435e4c48503acdbab65b4cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6380298936d865cad87653a8f1d9588b3e5f255d6435e4c48503acdbab65b4cb", kill_on_drop: false }` [INFO] [stdout] 6380298936d865cad87653a8f1d9588b3e5f255d6435e4c48503acdbab65b4cb