[INFO] fetching crate rod 0.2.4... [INFO] checking rod-0.2.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rod 0.2.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rod 0.2.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rod 0.2.4 [INFO] finished tweaking crates.io crate rod 0.2.4 [INFO] tweaked toml for crates.io crate rod 0.2.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rod 0.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf1e1869eeada63e1ef524785b3cbcca2502538fc0565c9177be053c21097788 [INFO] running `Command { std: "docker" "start" "-a" "bf1e1869eeada63e1ef524785b3cbcca2502538fc0565c9177be053c21097788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf1e1869eeada63e1ef524785b3cbcca2502538fc0565c9177be053c21097788", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf1e1869eeada63e1ef524785b3cbcca2502538fc0565c9177be053c21097788", kill_on_drop: false }` [INFO] [stdout] bf1e1869eeada63e1ef524785b3cbcca2502538fc0565c9177be053c21097788 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c51ff2d95bdd5a9eb18d7c8012821b1de625cef694c5ce91431b2262cb3d28a [INFO] running `Command { std: "docker" "start" "-a" "6c51ff2d95bdd5a9eb18d7c8012821b1de625cef694c5ce91431b2262cb3d28a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.116 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.6 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.6 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.78 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Compiling semver v1.0.9 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.4 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking block-buffer v0.10.0 [INFO] [stderr] Checking crypto-common v0.1.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking digest v0.10.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Compiling crc32fast v1.3.1 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking pem v1.0.2 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Compiling sysinfo v0.23.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking headers v0.3.7 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking yasna v0.4.0 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking size_format v1.0.2 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking java-utils v0.1.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking multicast-socket v0.2.2 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking ctrlc v3.2.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling async-stream-impl v0.3.2 [INFO] [stderr] Compiling zeroize_derive v1.3.2 [INFO] [stderr] Checking zeroize v1.5.5 [INFO] [stderr] Checking async-stream v0.3.2 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking simple_asn1 v0.6.1 [INFO] [stderr] Checking tungstenite v0.14.0 [INFO] [stderr] Checking tungstenite v0.17.2 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking serde v1.0.136 [INFO] [stderr] Checking futures-executor v0.3.19 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Checking tokio-util v0.7.2 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking tokio-tungstenite v0.15.0 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking tokio-tungstenite v0.17.1 [INFO] [stderr] Checking tokio-test v0.4.2 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking jsonwebtoken v8.1.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking jsonwebkey v0.3.5 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking warp v0.3.2 [INFO] [stderr] Checking rod v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `future` [INFO] [stdout] --> src/adapters/ws_server.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | use futures_util::{future, StreamExt}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Error as IoError` [INFO] [stdout] --> src/adapters/ws_server.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::io::Error as IoError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/adapters/ws_server.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `future` [INFO] [stdout] --> src/adapters/ws_server.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | use futures_util::{future, StreamExt}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Error as IoError` [INFO] [stdout] --> src/adapters/ws_server.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | use std::io::Error as IoError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/adapters/ws_server.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters/memory_storage.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 22 | fn handle_get(&self, get: Get, ctx: &ActorContext) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | if let Some(children) = self.store.read().unwrap().get(&get.node_id).cloned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, HashMap>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters/memory_storage.rs:23:33 [INFO] [stdout] | [INFO] [stdout] 22 | fn handle_get(&self, get: Get, ctx: &ActorContext) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | if let Some(children) = self.store.read().unwrap().get(&get.node_id).cloned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:262:33 [INFO] [stdout] | [INFO] [stdout] 261 | let put = Put::new(updated_nodes, None, my_addr); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | if let Some(router) = &*self.router.read().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rod` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::sync::RwLockReadGuard<'_, std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:262:33 [INFO] [stdout] | [INFO] [stdout] 261 | let put = Put::new(updated_nodes, None, my_addr); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | if let Some(router) = &*self.router.read().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rod` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6c51ff2d95bdd5a9eb18d7c8012821b1de625cef694c5ce91431b2262cb3d28a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c51ff2d95bdd5a9eb18d7c8012821b1de625cef694c5ce91431b2262cb3d28a", kill_on_drop: false }` [INFO] [stdout] 6c51ff2d95bdd5a9eb18d7c8012821b1de625cef694c5ce91431b2262cb3d28a