[INFO] fetching crate rivia 0.2.10... [INFO] checking rivia-0.2.10 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rivia 0.2.10 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rivia 0.2.10 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rivia 0.2.10 [INFO] finished tweaking crates.io crate rivia 0.2.10 [INFO] tweaked toml for crates.io crate rivia 0.2.10 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate rivia 0.2.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fa11c62a2a7ce0f851ba64c2104531e9d8e2a6c04af8ad6899a6b2aec420e40 [INFO] running `Command { std: "docker" "start" "-a" "0fa11c62a2a7ce0f851ba64c2104531e9d8e2a6c04af8ad6899a6b2aec420e40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fa11c62a2a7ce0f851ba64c2104531e9d8e2a6c04af8ad6899a6b2aec420e40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fa11c62a2a7ce0f851ba64c2104531e9d8e2a6c04af8ad6899a6b2aec420e40", kill_on_drop: false }` [INFO] [stdout] 0fa11c62a2a7ce0f851ba64c2104531e9d8e2a6c04af8ad6899a6b2aec420e40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e2daa149187450fe5b608fc4ba18db018b2a269af8ee541fb549fdeedc74693 [INFO] running `Command { std: "docker" "start" "-a" "4e2daa149187450fe5b608fc4ba18db018b2a269af8ee541fb549fdeedc74693", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking rivia v0.2.10 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 20 | let mut x = x.into_iter(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut y = y.into_iter(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | loop { [INFO] [stdout] 23 | let (a, b) = (x.next(), y.next()); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 202 | fn first_result(mut self) -> RvResult [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:226:15 [INFO] [stdout] | [INFO] [stdout] 222 | fn single(mut self) -> RvResult [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 275 | fn some(mut self) -> bool [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | self.next().is_some() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rivia` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 20 | let mut x = x.into_iter(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut y = y.into_iter(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | loop { [INFO] [stdout] 23 | let (a, b) = (x.next(), y.next()); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 202 | fn first_result(mut self) -> RvResult [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:226:15 [INFO] [stdout] | [INFO] [stdout] 222 | fn single(mut self) -> RvResult [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/iter.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 275 | fn some(mut self) -> bool [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | self.next().is_some() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result Fn(&'a std::path::Path, bool) -> Result + Send + Sync>, errors::RvError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/fs/entry_iter.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 162 | let vfs = Memfs::new(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let tmpdir = PathBuf::new(); [INFO] [stdout] 164 | let guard = vfs.read_guard(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | if let Err(e) = vfs._entry_iter(&guard, &tmpdir) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `memfs::entry::MemfsEntry` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/fs/memfs/vfs.rs:2919:17 [INFO] [stdout] | [INFO] [stdout] 2834 | let vfs = Memfs::new(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2860 | let entries = vfs._clone_entries(&vfs.read_guard(), &dir1).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2880 | let entries = vfs._clone_entries(&vfs.read_guard(), &dir2).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2902 | let entries = vfs._clone_entries(&vfs.read_guard(), &dir3).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2919 | let root = vfs._clone_entry(&vfs.read_guard(), &vfs.root()).unwrap(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MemfsGuard<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/fs/memfs/vfs.rs:3086:17 [INFO] [stdout] | [INFO] [stdout] 3071 | let vfs = Memfs::new().upcast(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3086 | let guard = memfs.read_guard(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rivia` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4e2daa149187450fe5b608fc4ba18db018b2a269af8ee541fb549fdeedc74693", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e2daa149187450fe5b608fc4ba18db018b2a269af8ee541fb549fdeedc74693", kill_on_drop: false }` [INFO] [stdout] 4e2daa149187450fe5b608fc4ba18db018b2a269af8ee541fb549fdeedc74693