[INFO] fetching crate rf-core 0.6.0... [INFO] checking rf-core-0.6.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rf-core 0.6.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rf-core 0.6.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rf-core 0.6.0 [INFO] finished tweaking crates.io crate rf-core 0.6.0 [INFO] tweaked toml for crates.io crate rf-core 0.6.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f40baf245c92c8e55e413be7a4f5fe8073b0166f3ffcfcb896d017c10ec7bfef [INFO] running `Command { std: "docker" "start" "-a" "f40baf245c92c8e55e413be7a4f5fe8073b0166f3ffcfcb896d017c10ec7bfef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f40baf245c92c8e55e413be7a4f5fe8073b0166f3ffcfcb896d017c10ec7bfef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f40baf245c92c8e55e413be7a4f5fe8073b0166f3ffcfcb896d017c10ec7bfef", kill_on_drop: false }` [INFO] [stdout] f40baf245c92c8e55e413be7a4f5fe8073b0166f3ffcfcb896d017c10ec7bfef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b00318ba15c6928274e202b093c6e6a08981129b16daff6c201c012ff0f19775 [INFO] running `Command { std: "docker" "start" "-a" "b00318ba15c6928274e202b093c6e6a08981129b16daff6c201c012ff0f19775", kill_on_drop: false }` [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rf-core v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lang.rs:158:10 [INFO] [stdout] | [INFO] [stdout] 158 | |mut vm| { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `stack` and `is_folding` are never used [INFO] [stdout] --> src/vm/vm_status.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl VMStatus { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | pub fn stack(&self) -> &VecDeque<(Path, i32, Option)> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn is_folding(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lang.rs:158:10 [INFO] [stdout] | [INFO] [stdout] 158 | |mut vm| { [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `status` [INFO] [stdout] --> src/vm/round_vm.rs:378:13 [INFO] [stdout] | [INFO] [stdout] 378 | let status = VMStatus::new(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_status` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm` [INFO] [stdout] --> src/vm/round_vm.rs:383:13 [INFO] [stdout] | [INFO] [stdout] 383 | fn expr(vm: &mut RoundVM) -> i32 { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_vm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm` [INFO] [stdout] --> src/vm/round_vm.rs:454:34 [INFO] [stdout] | [INFO] [stdout] 454 | let result = vm.isolate(|vm| 5 * 3); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_vm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `stack` is never used [INFO] [stdout] --> src/vm/vm_status.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl VMStatus { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | pub fn stack(&self) -> &VecDeque<(Path, i32, Option)> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm` [INFO] [stdout] --> tests/by_equivalence/mod.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | |vm| 0, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_vm` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm` [INFO] [stdout] --> tests/by_equivalence/mod.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 113 | |vm| 0, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_vm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm` [INFO] [stdout] --> tests/by_round/mod.rs:48:54 [INFO] [stdout] | [INFO] [stdout] 48 | let result = round(&mut init_with_ctx(context), |vm| 10); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_vm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm1` [INFO] [stdout] --> tests/by_round/mod.rs:129:14 [INFO] [stdout] | [INFO] [stdout] 129 | |vm1| 0, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_vm1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm1` [INFO] [stdout] --> tests/by_round/mod.rs:139:14 [INFO] [stdout] | [INFO] [stdout] 139 | |vm1| 0, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_vm1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm3` [INFO] [stdout] --> tests/by_round/mod.rs:140:32 [INFO] [stdout] | [INFO] [stdout] 140 | |vm2, _| rep(vm2, |vm3| 0, |vm4, _| expr_2(vm4)), [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_vm3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm1` [INFO] [stdout] --> tests/by_round/mod.rs:234:67 [INFO] [stdout] | [INFO] [stdout] 234 | let result = round(&mut init_with_ctx(context), |vm| nbr(vm, |vm1| 7)); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_vm1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm` [INFO] [stdout] --> tests/by_round/mod.rs:274:47 [INFO] [stdout] | [INFO] [stdout] 274 | let program = |vm: &mut RoundVM| rep(vm, |vm| 9, |vm1, a| a * 2); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_vm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vm1` [INFO] [stdout] --> tests/by_round/mod.rs:274:55 [INFO] [stdout] | [INFO] [stdout] 274 | let program = |vm: &mut RoundVM| rep(vm, |vm| 9, |vm1, a| a * 2); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_vm1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HashSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/gradient/mod.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 202 | let final_topology = run_on_topology(gradient, topology, &scheduling); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | [INFO] [stdout] 204 | let actual_exports: HashMap = final_topology [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let expected_exports: HashMap = HashMap::from([ [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | let actual_paths = e [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `A` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/utils/mod.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|(id, (mut vm_1, mut vm_2))| { [INFO] [stdout] | -------------------------- [INFO] [stdout] | | | | [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | if id == curr { [INFO] [stdout] 113 | let res_1 = round(&mut vm_1, program_1); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `self_id` is never read [INFO] [stdout] --> tests/utils/mod.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 136 | pub struct DeviceState { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 137 | pub self_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DeviceState` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `devices` is never read [INFO] [stdout] --> tests/utils/mod.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 150 | pub struct Topology { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 151 | pub devices: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Topology` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rf-core` (test "mod") due to 3 previous errors; 11 warnings emitted [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b00318ba15c6928274e202b093c6e6a08981129b16daff6c201c012ff0f19775", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b00318ba15c6928274e202b093c6e6a08981129b16daff6c201c012ff0f19775", kill_on_drop: false }` [INFO] [stdout] b00318ba15c6928274e202b093c6e6a08981129b16daff6c201c012ff0f19775