[INFO] fetching crate retty 0.29.0... [INFO] checking retty-0.29.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate retty 0.29.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate retty 0.29.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate retty 0.29.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate retty 0.29.0 [INFO] tweaked toml for crates.io crate retty 0.29.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate retty 0.29.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 12eea44e3b8f66e78e7b5c7735c8b9925b82616d309720c60d43c7ff920a8820 [INFO] running `Command { std: "docker" "start" "-a" "12eea44e3b8f66e78e7b5c7735c8b9925b82616d309720c60d43c7ff920a8820", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "12eea44e3b8f66e78e7b5c7735c8b9925b82616d309720c60d43c7ff920a8820", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12eea44e3b8f66e78e7b5c7735c8b9925b82616d309720c60d43c7ff920a8820", kill_on_drop: false }` [INFO] [stdout] 12eea44e3b8f66e78e7b5c7735c8b9925b82616d309720c60d43c7ff920a8820 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77d19067352c168b88eac5cca1d9a0179ab9becadea85a0cd187715b57902c32 [INFO] running `Command { std: "docker" "start" "-a" "77d19067352c168b88eac5cca1d9a0179ab9becadea85a0cd187715b57902c32", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking waitgroup v0.1.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking async-broadcast v0.7.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking core_affinity v0.8.1 [INFO] [stderr] Checking ctrlc v3.4.2 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking async-fs v2.1.1 [INFO] [stderr] Checking async-io v2.3.1 [INFO] [stderr] Checking async-signal v0.2.5 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking async-process v2.1.0 [INFO] [stderr] Checking smol v2.0.0 [INFO] [stderr] Checking async-transport v0.5.0 [INFO] [stderr] Checking retty v0.29.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `waitgroup::Worker` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/bootstrap_tcp/mod.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 139 | mut socket: TcpStream, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | max_payload_size: usize, [INFO] [stdout] 141 | pipeline: Rc>, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | mut close_rx: async_broadcast::Receiver<()>, [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let _w = worker; [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 180 | / tokio::select! { [INFO] [stdout] 181 | | _ = close_rx.recv() => { [INFO] [stdout] 182 | | trace!("pipeline socket exit loop"); [INFO] [stdout] 183 | | break; [INFO] [stdout] ... | [INFO] [stdout] 213 | | } [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/handler.rs:132:30 [INFO] [stdout] | [INFO] [stdout] 130 | fn handle_read_internal(&mut self, ctx: &dyn ContextInternal, msg: Box) { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | if let Some(ctx) = ctx.as_any().downcast_ref::>() { [INFO] [stdout] 132 | if let Ok(msg) = msg.downcast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/pipeline_internal.rs:182:28 [INFO] [stdout] | [INFO] [stdout] 178 | let (mut handler, context) = ( [INFO] [stdout] | ----------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | if let Some(msg) = handler.poll_write_internal(&*context) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retty` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "77d19067352c168b88eac5cca1d9a0179ab9becadea85a0cd187715b57902c32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77d19067352c168b88eac5cca1d9a0179ab9becadea85a0cd187715b57902c32", kill_on_drop: false }` [INFO] [stdout] 77d19067352c168b88eac5cca1d9a0179ab9becadea85a0cd187715b57902c32