[INFO] fetching crate requiem-router 0.2.4... [INFO] checking requiem-router-0.2.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate requiem-router 0.2.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate requiem-router 0.2.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate requiem-router 0.2.4 [INFO] finished tweaking crates.io crate requiem-router 0.2.4 [INFO] tweaked toml for crates.io crate requiem-router 0.2.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (available: v1.7.2) [INFO] [stderr] Adding bytestring v0.1.5 (available: v1.3.1) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d98bdf63a3e1e6b43961c53de835f53813a6b33c9cc9031eb0fcafc862cca453 [INFO] running `Command { std: "docker" "start" "-a" "d98bdf63a3e1e6b43961c53de835f53813a6b33c9cc9031eb0fcafc862cca453", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d98bdf63a3e1e6b43961c53de835f53813a6b33c9cc9031eb0fcafc862cca453", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d98bdf63a3e1e6b43961c53de835f53813a6b33c9cc9031eb0fcafc862cca453", kill_on_drop: false }` [INFO] [stdout] d98bdf63a3e1e6b43961c53de835f53813a6b33c9cc9031eb0fcafc862cca453 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff9c3c829a88855fe54aca435decbdcdf69bf666a1dd85423c58f016aecb0f90 [INFO] running `Command { std: "docker" "start" "-a" "ff9c3c829a88855fe54aca435decbdcdf69bf666a1dd85423c58f016aecb0f90", kill_on_drop: false }` [INFO] [stderr] Checking bytestring v0.1.5 [INFO] [stderr] Checking requiem-router v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/url.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 34 - static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] 34 + static DEFAULT_QUOTER: Quoter = Quoter::new(b"@:", b"/+"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/url.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 34 - static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] 34 + static DEFAULT_QUOTER: Quoter = Quoter::new(b"@:", b"/+"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec<(regex::Regex, Vec<&str>, usize)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(path: T) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut data = Vec::new(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `resource` is never read [INFO] [stdout] --> src/router.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct ResourceInfo { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 9 | resource: ResourceId, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:297:40 [INFO] [stdout] | [INFO] [stdout] 297 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:329:44 [INFO] [stdout] | [INFO] [stdout] 329 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:416:40 [INFO] [stdout] | [INFO] [stdout] 416 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:455:44 [INFO] [stdout] | [INFO] [stdout] 455 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `requiem-router` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Vec<(regex::Regex, Vec<&str>, usize)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(path: T) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut data = Vec::new(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `resource` is never read [INFO] [stdout] --> src/router.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct ResourceInfo { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 9 | resource: ResourceId, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:297:40 [INFO] [stdout] | [INFO] [stdout] 297 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:329:44 [INFO] [stdout] | [INFO] [stdout] 329 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:416:40 [INFO] [stdout] | [INFO] [stdout] 416 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:455:44 [INFO] [stdout] | [INFO] [stdout] 455 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `requiem-router` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ff9c3c829a88855fe54aca435decbdcdf69bf666a1dd85423c58f016aecb0f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff9c3c829a88855fe54aca435decbdcdf69bf666a1dd85423c58f016aecb0f90", kill_on_drop: false }` [INFO] [stdout] ff9c3c829a88855fe54aca435decbdcdf69bf666a1dd85423c58f016aecb0f90