[INFO] fetching crate reool 0.30.0... [INFO] checking reool-0.30.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate reool 0.30.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate reool 0.30.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reool 0.30.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate reool 0.30.0 [INFO] tweaked toml for crates.io crate reool 0.30.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate reool 0.30.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ccf42dd0b73fa108b828a312d7fed70d77fade4e0cbad75e651e38ab6a7fa05 [INFO] running `Command { std: "docker" "start" "-a" "0ccf42dd0b73fa108b828a312d7fed70d77fade4e0cbad75e651e38ab6a7fa05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ccf42dd0b73fa108b828a312d7fed70d77fade4e0cbad75e651e38ab6a7fa05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ccf42dd0b73fa108b828a312d7fed70d77fade4e0cbad75e651e38ab6a7fa05", kill_on_drop: false }` [INFO] [stdout] 0ccf42dd0b73fa108b828a312d7fed70d77fade4e0cbad75e651e38ab6a7fa05 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0f93f7cda7b4588997b7b3cf22ac411ad3ab7ebfaccda6a89ab08d57d08ea91 [INFO] running `Command { std: "docker" "start" "-a" "b0f93f7cda7b4588997b7b3cf22ac411ad3ab7ebfaccda6a89ab08d57d08ea91", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-core v0.3.16 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling futures-task v0.3.16 [INFO] [stderr] Checking futures-sink v0.3.16 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-channel v0.3.16 [INFO] [stderr] Compiling futures-macro v0.3.16 [INFO] [stderr] Compiling futures-util v0.3.16 [INFO] [stderr] Compiling tokio v1.9.0 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking futures-io v0.3.16 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling async-trait v0.1.51 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling tokio-macros v1.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Compiling enum-as-inner v0.3.3 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking tokio-stream v0.1.7 [INFO] [stderr] Checking combine v4.6.0 [INFO] [stderr] Checking futures-executor v0.3.16 [INFO] [stderr] Checking trust-dns-proto v0.20.3 [INFO] [stderr] Checking futures v0.3.16 [INFO] [stderr] Checking trust-dns-resolver v0.20.3 [INFO] [stderr] Checking redis v0.21.0 [INFO] [stderr] Checking reool v0.30.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redis_ops.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 82 | fn client_id<'a>(&'a mut self) -> RedisFuture { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redis_ops.rs:86:64 [INFO] [stdout] | [INFO] [stdout] 86 | fn client_kill_id<'a>(&'a mut self, id: i64) -> RedisFuture<()> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redis_ops.rs:99:48 [INFO] [stdout] | [INFO] [stdout] 99 | fn db_size<'a>(&'a mut self) -> RedisFuture { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redis_ops.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 82 | fn client_id<'a>(&'a mut self) -> RedisFuture { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redis_ops.rs:86:64 [INFO] [stdout] | [INFO] [stdout] 86 | fn client_kill_id<'a>(&'a mut self, id: i64) -> RedisFuture<()> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redis_ops.rs:99:48 [INFO] [stdout] | [INFO] [stdout] 99 | fn db_size<'a>(&'a mut self) -> RedisFuture { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Managed, Duration)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pools/pool_internal/inner_pool/mod.rs:187:50 [INFO] [stdout] | [INFO] [stdout] 182 | fn check_out(&mut self, payload: CheckoutPayload) { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | if let Some((mut managed, idle_since)) = self.get_idle() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Result, CheckoutError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pools/pool_internal/inner_pool/mod.rs:346:39 [INFO] [stdout] | [INFO] [stdout] 344 | pub fn try_fulfill(self, mut managed: Managed) -> Fulfillment { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | managed.checked_out_at = Some(Instant::now()); [INFO] [stdout] 346 | if let Err(Ok(mut managed)) = self.sender.send(Ok(managed)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pools/pool_internal/managed.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 79 | let mut send_back = factory.send_back_cloned(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | if let Some(connection) = self.connection.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Managed, Duration)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pools/pool_internal/inner_pool/mod.rs:187:50 [INFO] [stdout] | [INFO] [stdout] 182 | fn check_out(&mut self, payload: CheckoutPayload) { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | if let Some((mut managed, idle_since)) = self.get_idle() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), Result, error::CheckoutError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pools/pool_internal/inner_pool/mod.rs:346:39 [INFO] [stdout] | [INFO] [stdout] 344 | pub fn try_fulfill(self, mut managed: Managed) -> Fulfillment { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | managed.checked_out_at = Some(Instant::now()); [INFO] [stdout] 346 | if let Err(Ok(mut managed)) = self.sender.send(Ok(managed)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pools/pool_internal/managed.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 79 | let mut send_back = factory.send_back_cloned(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | if let Some(connection) = self.connection.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reool` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reool` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b0f93f7cda7b4588997b7b3cf22ac411ad3ab7ebfaccda6a89ab08d57d08ea91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0f93f7cda7b4588997b7b3cf22ac411ad3ab7ebfaccda6a89ab08d57d08ea91", kill_on_drop: false }` [INFO] [stdout] b0f93f7cda7b4588997b7b3cf22ac411ad3ab7ebfaccda6a89ab08d57d08ea91