[INFO] fetching crate rental-impl 0.5.5... [INFO] checking rental-impl-0.5.5 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate rental-impl 0.5.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rental-impl 0.5.5 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rental-impl 0.5.5 [INFO] finished tweaking crates.io crate rental-impl 0.5.5 [INFO] tweaked toml for crates.io crate rental-impl 0.5.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9876dc79a08493ad945963c728546e5f95b14c0a699764e4da9a838c54f7dd44 [INFO] running `Command { std: "docker" "start" "-a" "9876dc79a08493ad945963c728546e5f95b14c0a699764e4da9a838c54f7dd44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9876dc79a08493ad945963c728546e5f95b14c0a699764e4da9a838c54f7dd44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9876dc79a08493ad945963c728546e5f95b14c0a699764e4da9a838c54f7dd44", kill_on_drop: false }` [INFO] [stdout] 9876dc79a08493ad945963c728546e5f95b14c0a699764e4da9a838c54f7dd44 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2e1d4da1aa332ee40a307ff41ba5a32cb2d0842430ea0c6809df25a58cf7366 [INFO] running `Command { std: "docker" "start" "-a" "d2e1d4da1aa332ee40a307ff41ba5a32cb2d0842430ea0c6809df25a58cf7366", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking rental-impl v0.5.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/lib.rs:1428:106 [INFO] [stdout] | [INFO] [stdout] 1428 | let prev_new_exprs_reverse = &borrows[0 .. idx].iter().map(|b| &b.new_expr).rev().collect::>();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/lib.rs:1428:106 [INFO] [stdout] | [INFO] [stdout] 1428 | let prev_new_exprs_reverse = &borrows[0 .. idx].iter().map(|b| &b.new_expr).rev().collect::>();; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TypeParam` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:779:7 [INFO] [stdout] | [INFO] [stdout] 109 | let attribs = get_struct_attribs(struct_info); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let (fields, fields_brace) = prepare_fields(struct_info); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let where_extra = if let Some(ref struct_where_clause) = struct_where_clause { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let (ref self_ref_param, ref self_lt_ref_param, ref self_mut_param, ref self_move_param, ref self_arg) = if attribs.is_deref_suffix { [INFO] [stdout] | ______________________________________________________________________________________________________________- [INFO] [stdout] 153 | | (quote!(_self: &Self), quote!(_self: &'__s Self), quote!(_self: &mut Self), quote!(_self: Self), quote!(_self)) [INFO] [stdout] 154 | | } else { [INFO] [stdout] 155 | | (quote!(&self), quote!(&'__s self), quote!(&mut self), quote!(self), quote!(self)) [INFO] [stdout] 156 | | }; [INFO] [stdout] | |_____- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let borrow_quotes = &make_borrow_quotes(self_arg, &fields, attribs.is_rental_mut); [INFO] [stdout] | ------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let struct_rlt_params = &struct_rlt_args.iter().zip(struct_rlt_args.iter().skip(1)).map(|(rlt_arg, next_rlt_arg)| { [INFO] [stdout] | ______________________________- [INFO] [stdout] 173 | | syn::LifetimeDef { [INFO] [stdout] 174 | | attrs: Vec::with_capacity(0), [INFO] [stdout] 175 | | lifetime: (*rlt_arg).clone(), [INFO] [stdout] ... | [INFO] [stdout] 183 | | colon_token: Default::default(), [INFO] [stdout] 184 | | })).collect::>(); [INFO] [stdout] | |___________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let borrow_lt_params = &struct_rlt_params.iter().cloned() [INFO] [stdout] | _____________________________- [INFO] [stdout] 187 | | .chain( struct_lt_params.iter().map(|lt_def| { [INFO] [stdout] 188 | | let mut lt_def = (*lt_def).clone(); [INFO] [stdout] 189 | | lt_def.bounds.push(struct_rlt_args[0].clone()); [INFO] [stdout] 190 | | lt_def [INFO] [stdout] 191 | | })).collect::>(); [INFO] [stdout] | |_______________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let tail_closure_quotes = make_tail_closure_quotes(&fields, borrow_quotes, attribs.is_rental_mut); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let rstruct = syn::ItemStruct{ [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let borrow_struct = syn::ItemStruct{ [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let borrow_mut_struct = syn::ItemStruct{ [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let static_assert_prefix_stable_derefs = &prefix_tys.iter().map(|field| { [INFO] [stdout] | _______________________________________________- [INFO] [stdout] 284 | | if attribs.is_rental_mut { [INFO] [stdout] 285 | | quote_spanned!(field.span()/*.resolved_at(def_site)*/ => __rental_prelude::static_assert_mut_stable_deref::<#field>();) [INFO] [stdout] 286 | | } else { [INFO] [stdout] 287 | | quote_spanned!(field.span()/*.resolved_at(def_site)*/ => __rental_prelude::static_assert_stable_deref::<#field>();) [INFO] [stdout] 288 | | } [INFO] [stdout] 289 | | }).collect::>(); [INFO] [stdout] | |__________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | let prefix_clone_traits = iter::repeat(quote!(__rental_prelude::CloneStableDeref)).take(prefix_tys.len()); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | let mapped_suffix_param = replacer.fold_type_param(map_suffix_param.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 832 | map_where_clause.predicates.push(parse_quote!( [INFO] [stdout] | __________________________________________- [INFO] [stdout] 833 | | __F: for<#(#suffix_rlt_args),*> __rental_prelude::FnOnce(#suffix_orig_ty) -> #mapped_suffix_ty [INFO] [stdout] 834 | | )); [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 835 | try_map_where_clause.predicates.push(parse_quote!( [INFO] [stdout] | ______________________________________________- [INFO] [stdout] 836 | | __F: for<#(#suffix_rlt_args),*> __rental_prelude::FnOnce(#suffix_orig_ty) -> __rental_prelude::Result<#mapped_suffix_ty, __E> [INFO] [stdout] 837 | | )); [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 838 | [INFO] [stdout] 839 | / quote_spanned!(struct_span => [INFO] [stdout] 840 | | #[allow(dead_code)] [INFO] [stdout] 841 | | impl #struct_impl_params #item_ident #struct_impl_args #struct_where_clause { [INFO] [stdout] 842 | | /// Maps the suffix field of the rental struct to a different type. [INFO] [stdout] ... | [INFO] [stdout] 875 | | } [INFO] [stdout] 876 | | ).to_tokens(tokens); [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TypeParam` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:779:7 [INFO] [stdout] | [INFO] [stdout] 109 | let attribs = get_struct_attribs(struct_info); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let (fields, fields_brace) = prepare_fields(struct_info); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let where_extra = if let Some(ref struct_where_clause) = struct_where_clause { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let (ref self_ref_param, ref self_lt_ref_param, ref self_mut_param, ref self_move_param, ref self_arg) = if attribs.is_deref_suffix { [INFO] [stdout] | ______________________________________________________________________________________________________________- [INFO] [stdout] 153 | | (quote!(_self: &Self), quote!(_self: &'__s Self), quote!(_self: &mut Self), quote!(_self: Self), quote!(_self)) [INFO] [stdout] 154 | | } else { [INFO] [stdout] 155 | | (quote!(&self), quote!(&'__s self), quote!(&mut self), quote!(self), quote!(self)) [INFO] [stdout] 156 | | }; [INFO] [stdout] | |_____- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let borrow_quotes = &make_borrow_quotes(self_arg, &fields, attribs.is_rental_mut); [INFO] [stdout] | ------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let struct_rlt_params = &struct_rlt_args.iter().zip(struct_rlt_args.iter().skip(1)).map(|(rlt_arg, next_rlt_arg)| { [INFO] [stdout] | ______________________________- [INFO] [stdout] 173 | | syn::LifetimeDef { [INFO] [stdout] 174 | | attrs: Vec::with_capacity(0), [INFO] [stdout] 175 | | lifetime: (*rlt_arg).clone(), [INFO] [stdout] ... | [INFO] [stdout] 183 | | colon_token: Default::default(), [INFO] [stdout] 184 | | })).collect::>(); [INFO] [stdout] | |___________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let borrow_lt_params = &struct_rlt_params.iter().cloned() [INFO] [stdout] | _____________________________- [INFO] [stdout] 187 | | .chain( struct_lt_params.iter().map(|lt_def| { [INFO] [stdout] 188 | | let mut lt_def = (*lt_def).clone(); [INFO] [stdout] 189 | | lt_def.bounds.push(struct_rlt_args[0].clone()); [INFO] [stdout] 190 | | lt_def [INFO] [stdout] 191 | | })).collect::>(); [INFO] [stdout] | |_______________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let tail_closure_quotes = make_tail_closure_quotes(&fields, borrow_quotes, attribs.is_rental_mut); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let rstruct = syn::ItemStruct{ [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let borrow_struct = syn::ItemStruct{ [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let borrow_mut_struct = syn::ItemStruct{ [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let static_assert_prefix_stable_derefs = &prefix_tys.iter().map(|field| { [INFO] [stdout] | _______________________________________________- [INFO] [stdout] 284 | | if attribs.is_rental_mut { [INFO] [stdout] 285 | | quote_spanned!(field.span()/*.resolved_at(def_site)*/ => __rental_prelude::static_assert_mut_stable_deref::<#field>();) [INFO] [stdout] 286 | | } else { [INFO] [stdout] 287 | | quote_spanned!(field.span()/*.resolved_at(def_site)*/ => __rental_prelude::static_assert_stable_deref::<#field>();) [INFO] [stdout] 288 | | } [INFO] [stdout] 289 | | }).collect::>(); [INFO] [stdout] | |__________________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | let prefix_clone_traits = iter::repeat(quote!(__rental_prelude::CloneStableDeref)).take(prefix_tys.len()); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | let mapped_suffix_param = replacer.fold_type_param(map_suffix_param.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 832 | map_where_clause.predicates.push(parse_quote!( [INFO] [stdout] | __________________________________________- [INFO] [stdout] 833 | | __F: for<#(#suffix_rlt_args),*> __rental_prelude::FnOnce(#suffix_orig_ty) -> #mapped_suffix_ty [INFO] [stdout] 834 | | )); [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 835 | try_map_where_clause.predicates.push(parse_quote!( [INFO] [stdout] | ______________________________________________- [INFO] [stdout] 836 | | __F: for<#(#suffix_rlt_args),*> __rental_prelude::FnOnce(#suffix_orig_ty) -> __rental_prelude::Result<#mapped_suffix_ty, __E> [INFO] [stdout] 837 | | )); [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 838 | [INFO] [stdout] 839 | / quote_spanned!(struct_span => [INFO] [stdout] 840 | | #[allow(dead_code)] [INFO] [stdout] 841 | | impl #struct_impl_params #item_ident #struct_impl_args #struct_where_clause { [INFO] [stdout] 842 | | /// Maps the suffix field of the rental struct to a different type. [INFO] [stdout] ... | [INFO] [stdout] 875 | | } [INFO] [stdout] 876 | | ).to_tokens(tokens); [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(syn::Type, syn::Type, Vec<&GenericArgument>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1275:71 [INFO] [stdout] | [INFO] [stdout] 1253 | let (field_ty, deref) = if idx == fields.len() - 1 { [INFO] [stdout] | -------- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1275 | let (ref borrow_ty_hack, ref borrow_mut_ty_hack, ref field_args) = if let syn::Type::Path(syn::TypePath{ref qself, path: ref ty_path}) ... [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 1276 | | let seg_idx = ty_path.segments.len() - 1; [INFO] [stdout] 1277 | | let ty_name = &ty_path.segments[seg_idx].ident.to_string(); [INFO] [stdout] ... | [INFO] [stdout] 1305 | | panic!("Field `{}` must be a type path.", fields[idx].name) [INFO] [stdout] 1306 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 1310 | quote!(<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::Borrow) [INFO] [stdout] | ------------------------------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1311 | } else { [INFO] [stdout] 1312 | quote!(__rental_prelude::PhantomData<<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::Borrow>) [INFO] [stdout] | ------------------------------------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1315 | quote!(#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1316 | } else { [INFO] [stdout] 1317 | quote!(__rental_prelude::PhantomData<#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>>) [INFO] [stdout] | --------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1326 | quote!(<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::BorrowMut) [INFO] [stdout] | --------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1327 | } else if !is_rental_mut { [INFO] [stdout] 1328 | quote!(<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::Borrow) [INFO] [stdout] | ------------------------------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1329 | } else { [INFO] [stdout] 1330 | quote!(__rental_prelude::PhantomData<<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::BorrowMut>) [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1333 | quote!(#borrow_mut_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | ------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1334 | } else if !is_rental_mut { [INFO] [stdout] 1335 | quote!(#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1336 | } else { [INFO] [stdout] 1337 | quote!(__rental_prelude::PhantomData<#borrow_mut_ty_hack<#(#field_rlt_args,)* #(#field_args),*>>) [INFO] [stdout] | ------------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1349 | quote!(#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1352 | quote!(#borrow_mut_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | ------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rental-impl` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(syn::Type, syn::Type, Vec<&GenericArgument>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1275:71 [INFO] [stdout] | [INFO] [stdout] 1253 | let (field_ty, deref) = if idx == fields.len() - 1 { [INFO] [stdout] | -------- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1275 | let (ref borrow_ty_hack, ref borrow_mut_ty_hack, ref field_args) = if let syn::Type::Path(syn::TypePath{ref qself, path: ref ty_path}) ... [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 1276 | | let seg_idx = ty_path.segments.len() - 1; [INFO] [stdout] 1277 | | let ty_name = &ty_path.segments[seg_idx].ident.to_string(); [INFO] [stdout] ... | [INFO] [stdout] 1305 | | panic!("Field `{}` must be a type path.", fields[idx].name) [INFO] [stdout] 1306 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 1310 | quote!(<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::Borrow) [INFO] [stdout] | ------------------------------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1311 | } else { [INFO] [stdout] 1312 | quote!(__rental_prelude::PhantomData<<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::Borrow>) [INFO] [stdout] | ------------------------------------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1315 | quote!(#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1316 | } else { [INFO] [stdout] 1317 | quote!(__rental_prelude::PhantomData<#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>>) [INFO] [stdout] | --------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1326 | quote!(<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::BorrowMut) [INFO] [stdout] | --------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1327 | } else if !is_rental_mut { [INFO] [stdout] 1328 | quote!(<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::Borrow) [INFO] [stdout] | ------------------------------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1329 | } else { [INFO] [stdout] 1330 | quote!(__rental_prelude::PhantomData<<#field_ty as __rental_prelude::#rental_trait_ident<#(#field_rlt_args),*>>::BorrowMut>) [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1333 | quote!(#borrow_mut_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | ------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1334 | } else if !is_rental_mut { [INFO] [stdout] 1335 | quote!(#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1336 | } else { [INFO] [stdout] 1337 | quote!(__rental_prelude::PhantomData<#borrow_mut_ty_hack<#(#field_rlt_args,)* #(#field_args),*>>) [INFO] [stdout] | ------------------------------------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1349 | quote!(#borrow_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | -------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1352 | quote!(#borrow_mut_ty_hack<#(#field_rlt_args,)* #(#field_args),*>) [INFO] [stdout] | ------------------------------------------------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rental-impl` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d2e1d4da1aa332ee40a307ff41ba5a32cb2d0842430ea0c6809df25a58cf7366", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2e1d4da1aa332ee40a307ff41ba5a32cb2d0842430ea0c6809df25a58cf7366", kill_on_drop: false }` [INFO] [stdout] d2e1d4da1aa332ee40a307ff41ba5a32cb2d0842430ea0c6809df25a58cf7366