[INFO] fetching crate relayport-rs 0.5.0... [INFO] checking relayport-rs-0.5.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate relayport-rs 0.5.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate relayport-rs 0.5.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate relayport-rs 0.5.0 [INFO] finished tweaking crates.io crate relayport-rs 0.5.0 [INFO] tweaked toml for crates.io crate relayport-rs 0.5.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 51 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1146097c15266405037309b8e9e05458e51935604f287f9e13b30eea8dc07388 [INFO] running `Command { std: "docker" "start" "-a" "1146097c15266405037309b8e9e05458e51935604f287f9e13b30eea8dc07388", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1146097c15266405037309b8e9e05458e51935604f287f9e13b30eea8dc07388", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1146097c15266405037309b8e9e05458e51935604f287f9e13b30eea8dc07388", kill_on_drop: false }` [INFO] [stdout] 1146097c15266405037309b8e9e05458e51935604f287f9e13b30eea8dc07388 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16c6f63ef8b265948f953a13513b77c18d18e68c69e48bddcff157ed9597a44c [INFO] running `Command { std: "docker" "start" "-a" "16c6f63ef8b265948f953a13513b77c18d18e68c69e48bddcff157ed9597a44c", kill_on_drop: false }` [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking relayport-rs v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::broadcast::Receiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/tcp.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | let mut cancel = cancel.resubscribe(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 316 | / tokio::select! { [INFO] [stdout] 317 | | biased; [INFO] [stdout] 318 | | _ = self.spawn_bidirectional_relay(client_stream, relay_addr, cancel.resubscribe()) => { continue } [INFO] [stdout] 319 | | result = cancel.recv() => {match result { [INFO] [stdout] ... | [INFO] [stdout] 327 | | }} [INFO] [stdout] 328 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RelayStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/tcp.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut relay = RelaySocket::build() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 364 | match tokio::join!(handle) { [INFO] [stdout] | -------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::broadcast::Receiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/tcp.rs:313:17 [INFO] [stdout] | [INFO] [stdout] 313 | let mut cancel = cancel.resubscribe(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 316 | / tokio::select! { [INFO] [stdout] 317 | | biased; [INFO] [stdout] 318 | | _ = self.spawn_bidirectional_relay(client_stream, relay_addr, cancel.resubscribe()) => { continue } [INFO] [stdout] 319 | | result = cancel.recv() => {match result { [INFO] [stdout] ... | [INFO] [stdout] 327 | | }} [INFO] [stdout] 328 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RelayStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/tcp.rs:340:13 [INFO] [stdout] | [INFO] [stdout] 340 | let mut relay = RelaySocket::build() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 364 | match tokio::join!(handle) { [INFO] [stdout] | -------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/udp.rs:224:14 [INFO] [stdout] | [INFO] [stdout] 224 | let (cancel_tx, cancel_rx) = tokio::sync::mpsc::channel(24); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | / tokio::select! { [INFO] [stdout] 251 | | biased; [INFO] [stdout] 252 | | _ = self.spawn_bidirectional_relay(client_socket, remote_socket, command.resubscribe(), cancel_tx.clone()) => { continue } [INFO] [stdout] 253 | | result = command.recv() => {match result { [INFO] [stdout] ... | [INFO] [stdout] 261 | | }} [INFO] [stdout] 262 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/udp.rs:224:14 [INFO] [stdout] | [INFO] [stdout] 224 | let (cancel_tx, cancel_rx) = tokio::sync::mpsc::channel(24); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | / tokio::select! { [INFO] [stdout] 251 | | biased; [INFO] [stdout] 252 | | _ = self.spawn_bidirectional_relay(client_socket, remote_socket, command.resubscribe(), cancel_tx.clone()) => { continue } [INFO] [stdout] 253 | | result = command.recv() => {match result { [INFO] [stdout] ... | [INFO] [stdout] 261 | | }} [INFO] [stdout] 262 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `InnerUdpSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/udp.rs:405:9 [INFO] [stdout] | [INFO] [stdout] 405 | let src_ = src.clone(); [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 427 | / tokio::select! { [INFO] [stdout] 428 | | biased; [INFO] [stdout] 429 | | result = copy_reader_to_writer => { [INFO] [stdout] 430 | | read_bytes = result [INFO] [stdout] ... | [INFO] [stdout] 452 | | } [INFO] [stdout] 453 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `relayport-rs` (lib test) due to 5 previous errors [INFO] [stdout] error: this value of type `InnerUdpSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/udp.rs:405:9 [INFO] [stdout] | [INFO] [stdout] 405 | let src_ = src.clone(); [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 427 | / tokio::select! { [INFO] [stdout] 428 | | biased; [INFO] [stdout] 429 | | result = copy_reader_to_writer => { [INFO] [stdout] 430 | | read_bytes = result [INFO] [stdout] ... | [INFO] [stdout] 452 | | } [INFO] [stdout] 453 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `relayport-rs` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "16c6f63ef8b265948f953a13513b77c18d18e68c69e48bddcff157ed9597a44c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16c6f63ef8b265948f953a13513b77c18d18e68c69e48bddcff157ed9597a44c", kill_on_drop: false }` [INFO] [stdout] 16c6f63ef8b265948f953a13513b77c18d18e68c69e48bddcff157ed9597a44c