[INFO] fetching crate reduct-rs 1.11.0... [INFO] checking reduct-rs-1.11.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate reduct-rs 1.11.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate reduct-rs 1.11.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reduct-rs 1.11.0 [INFO] finished tweaking crates.io crate reduct-rs 1.11.0 [INFO] tweaked toml for crates.io crate reduct-rs 1.11.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate reduct-rs 1.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dfef4dc3996569b73f054df290903fbccd7b747e3a649085fd3560b81f1fb4cc [INFO] running `Command { std: "docker" "start" "-a" "dfef4dc3996569b73f054df290903fbccd7b747e3a649085fd3560b81f1fb4cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dfef4dc3996569b73f054df290903fbccd7b747e3a649085fd3560b81f1fb4cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfef4dc3996569b73f054df290903fbccd7b747e3a649085fd3560b81f1fb4cc", kill_on_drop: false }` [INFO] [stdout] dfef4dc3996569b73f054df290903fbccd7b747e3a649085fd3560b81f1fb4cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f9b0f69dae9cf0a65b3661c6485c5bf7fbc876442f443f3cd0e66b7510b97dd [INFO] running `Command { std: "docker" "start" "-a" "5f9b0f69dae9cf0a65b3661c6485c5bf7fbc876442f443f3cd0e66b7510b97dd", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling indexmap v2.4.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling rstest_macros v0.22.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling int-enum-impl v0.5.0 [INFO] [stderr] Checking int-enum v0.5.0 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling test-with v0.13.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.22.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.6 [INFO] [stderr] Checking reduct-base v1.10.1 [INFO] [stderr] Checking reduct-rs v1.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/query.rs:235:32 [INFO] [stdout] | [INFO] [stdout] 230 | Ok(stream! { [INFO] [stdout] | ____________- [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 231 | | let mut last = false; [INFO] [stdout] 232 | | while !last { [INFO] [stdout] 233 | | let method = if head_only { Method::HEAD } else { Method::GET }; [INFO] [stdout] 234 | | let request = client.request(method, &format!("/b/{}/{}/batch?q={}", bucket, entry, response.id)); [INFO] [stdout] 235 | | let response = client.send_request(request).await?; [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 255 | | pin_mut!(stream); [INFO] [stdout] | | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter<(u64, HeaderValue)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/query.rs:294:35 [INFO] [stdout] | [INFO] [stdout] 292 | Ok(stream! { [INFO] [stdout] | ________- [INFO] [stdout] 293 | | let mut rest_data = BytesMut::new(); [INFO] [stdout] | | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | | for (timestamp, value) in sorted_records { [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] 295 | | let RecordHeader{content_length, content_type, labels} = parse_batched_header(value.to_str().unwrap()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | } [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_____- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/query.rs:309:47 [INFO] [stdout] | [INFO] [stdout] 307 | Some(Box::pin(stream! { [INFO] [stdout] | ___________________________________- [INFO] [stdout] 308 | | yield Ok(first_chunk); [INFO] [stdout] 309 | | while let Ok(bytes) = rx.recv().await { [INFO] [stdout] | | ^^^^^^^^^^^^^^^ [INFO] [stdout] 310 | | yield Ok(bytes); [INFO] [stdout] 311 | | } [INFO] [stdout] 312 | | })) [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/write_batched_records.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 133 | let stream = stream! { [INFO] [stdout] | ______________________________- [INFO] [stdout] 134 | | while let Some(record) = self.records.pop_front() { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 135 | | let mut stream = record.stream_bytes(); [INFO] [stdout] 136 | | while let Some(bytes) = stream.next().await { [INFO] [stdout] ... | [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | }; [INFO] [stdout] | |_________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/write_batched_records.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 133 | let stream = stream! { [INFO] [stdout] | ______________________________- [INFO] [stdout] 134 | | while let Some(record) = self.records.pop_front() { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 135 | | let mut stream = record.stream_bytes(); [INFO] [stdout] 136 | | while let Some(bytes) = stream.next().await { [INFO] [stdout] ... | [INFO] [stdout] 139 | | } [INFO] [stdout] 140 | | }; [INFO] [stdout] | |_________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/query.rs:235:32 [INFO] [stdout] | [INFO] [stdout] 230 | Ok(stream! { [INFO] [stdout] | ____________- [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 231 | | let mut last = false; [INFO] [stdout] 232 | | while !last { [INFO] [stdout] 233 | | let method = if head_only { Method::HEAD } else { Method::GET }; [INFO] [stdout] 234 | | let request = client.request(method, &format!("/b/{}/{}/batch?q={}", bucket, entry, response.id)); [INFO] [stdout] 235 | | let response = client.send_request(request).await?; [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 255 | | pin_mut!(stream); [INFO] [stdout] | | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reduct-rs` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::vec::IntoIter<(u64, HeaderValue)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/query.rs:294:35 [INFO] [stdout] | [INFO] [stdout] 292 | Ok(stream! { [INFO] [stdout] | ________- [INFO] [stdout] 293 | | let mut rest_data = BytesMut::new(); [INFO] [stdout] | | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | | for (timestamp, value) in sorted_records { [INFO] [stdout] | | ^^^^^^^^^^^^^^ [INFO] [stdout] 295 | | let RecordHeader{content_length, content_type, labels} = parse_batched_header(value.to_str().unwrap()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | } [INFO] [stdout] 344 | | }) [INFO] [stdout] | |_____- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/query.rs:309:47 [INFO] [stdout] | [INFO] [stdout] 307 | Some(Box::pin(stream! { [INFO] [stdout] | ___________________________________- [INFO] [stdout] 308 | | yield Ok(first_chunk); [INFO] [stdout] 309 | | while let Ok(bytes) = rx.recv().await { [INFO] [stdout] | | ^^^^^^^^^^^^^^^ [INFO] [stdout] 310 | | yield Ok(bytes); [INFO] [stdout] 311 | | } [INFO] [stdout] 312 | | })) [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reduct-rs` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5f9b0f69dae9cf0a65b3661c6485c5bf7fbc876442f443f3cd0e66b7510b97dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f9b0f69dae9cf0a65b3661c6485c5bf7fbc876442f443f3cd0e66b7510b97dd", kill_on_drop: false }` [INFO] [stdout] 5f9b0f69dae9cf0a65b3661c6485c5bf7fbc876442f443f3cd0e66b7510b97dd